From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115207 invoked by alias); 22 May 2017 15:26:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115193 invoked by uid 89); 22 May 2017 15:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=HCc:D*ca X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 May 2017 15:26:20 +0000 Received: by mail-wm0-f41.google.com with SMTP id e127so41917259wmg.1 for ; Mon, 22 May 2017 08:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Ma2EFiGa4P0yva3sm4ZmF+JtKlv/F8qPRJFlrjxatGI=; b=Grq2HQjyiDxnC/bBffAWLEZJ8jvgkqPvzBvhTCcxqJwHHc+zxn0qJC21P8Gk7ZgPG3 T/4cpkvq7LKif3tz7lAWylcmI0HL+hjEwZRkJ+D74NZL3z2V38Igy7Yy18iYEky8GthP qAGZcJWYKqMZyQGIK1qzLgz0iTxZynjbK2vwSbGfeh29IN7LKaiLL/Y6VIRCrMECz1oO pbLwC3/QpPKi4X/SdP7/RT8DoDJ3oKixKdK3+sEJwiQSodSgpbgWQl9eeGTCcHlsuDoi g5zUgXQfFwiO4LwzgJG2WsAfW24qGCPfMCSgpKGeJ7mqbJ6xQh/T1QmPRV1qupy2cNnp OzDg== X-Gm-Message-State: AODbwcC3bY/0e98t+76H2DsPnkI3BXWCm/4k+pOD+h0aHNC/9HjcApaS j2igpyIfPDX/2jps X-Received: by 10.28.198.13 with SMTP id w13mr25148944wmf.9.1495466781592; Mon, 22 May 2017 08:26:21 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id s10sm15034789wmb.8.2017.05.22.08.26.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 08:26:20 -0700 (PDT) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c To: Eli Zaretskii References: <20170504194442.63AAF60B72@joel.gnat.com> <83o9v3cs25.fsf@gnu.org> <91d9fc6cc7c07674a0b5cd02e7b1502b@polymtl.ca> <8360h38r1r.fsf@gnu.org> <20170517143136.mdnstf2u2jiydvnd@adacore.com> <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 22 May 2017 15:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <83vaouns1q.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00491.txt.bz2 On 05/21/2017 04:33 PM, Eli Zaretskii wrote: >> Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Fri, 19 May 2017 12:23:06 +0100 >> >> On 05/19/2017 12:17 PM, Eli Zaretskii wrote: >> >>> Fine with me, but Someone(TM) should figure out what to use instead of >>> "#if 0". >>> >> >> Something around >> __MINGW32__ / _GLIBCXX_USE_C99 / _GLIBCXX_HAVE_BROKEN_VSWPRINTF ? > > Here's what I came up with. OK to commit? Is there still a reason for the "#include <_mingw.h>"? I thought that was needed in the previous version for __MINGW64_VERSION_MAJOR, but this version of the patch doesn't use that symbol. Otherwise, if - older broken mingw releases get the replacement - newer fixed mingw releases don't get the replacement - mingw-w64 doesn't get the replacement (as it doesn't need one IIUC) then it's fine with me. It'd be useful for the archives if you expanded on which mingw versions and compilers you tested this on. Also likewise a short comment to the effect in the code would be likewise handy for future readers (please use /**/ style comments). Thanks, Pedro Alves