Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.rocm/multi-inferior-gpu.exp: Use allow_fork_tests
Date: Fri, 3 Jul 2026 11:51:33 +0100	[thread overview]
Message-ID: <f78f94f5-3047-4c3a-8b29-93181599b3f0@amd.com> (raw)
In-Reply-To: <20260702122412.330712-1-pedro@palves.net>



On 02/07/2026 13:24, Pedro Alves wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> The program of gdb.rocm/multi-inferior-gpu.exp uses fork, so make the
> testcase require allow_fork_tests.
> 
> Change-Id: I4c762be8d19c168f15962c68f8cbcc22ec3d6556

Hi Pedro,

Looks good.  Thanks.

Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

> ---
>   gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> index f632ca3bd85..5e07e4d982c 100644
> --- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> +++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> @@ -22,6 +22,7 @@ standard_testfile .cpp
> 
>   require allow_hipcc_tests
>   require hip_devices_support_debug_multi_process
> +require allow_fork_tests
> 
>   if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} {
>       return
> 
> base-commit: 18ca02157d9cc245f035452e397a07a3787034d0
> --
> 2.54.0
> 


      reply	other threads:[~2026-07-03 10:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 12:24 Pedro Alves
2026-07-03 10:51 ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f78f94f5-3047-4c3a-8b29-93181599b3f0@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox