From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UNmKJjy6HGWEESQAWB0awg (envelope-from ) for ; Tue, 03 Oct 2023 21:05:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=S9YnEYMJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 92FF41E0C3; Tue, 3 Oct 2023 21:05:00 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 831641E092 for ; Tue, 3 Oct 2023 21:04:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9FBCE3857713 for ; Wed, 4 Oct 2023 01:04:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FBCE3857713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696381497; bh=qICcfJ6uB5tkIXpjPFxHiO30MOT8zbUOj6byWi0Tf4Y=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S9YnEYMJbfO3mwrFQ/gSTpU38b22jLPq3swU0Bt1x8EJC9O2sAQUCJIYRHu9Bn8sp yJoT6lz/eQ5UtgwbzaI+R5MwdTxLE0zCZ65oJnveGEJSwn2582GICpr3GBA76i3PgF c34cEdn2GdNmlsSiCyOr7nOgogupJ3cX4o3Xp//0= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 956373858402 for ; Wed, 4 Oct 2023 01:04:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 956373858402 Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 469691E092; Tue, 3 Oct 2023 21:04:30 -0400 (EDT) Message-ID: Date: Tue, 3 Oct 2023 21:04:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Bump up 'match_max' Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20231003195338.334948-1-thiago.bauermann@linaro.org> In-Reply-To: <20231003195338.334948-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2023-10-03 15:53, Thiago Jung Bauermann via Gdb-patches wrote: > This fixes "ERROR: internal buffer is full." in gdb.base/maint.exp when > running with "make check-read1". > > Also take the opportunity to fix stray whitespace in the vicinity. > --- > gdb/testsuite/lib/gdb.exp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index de22da8d8a8c..c6ee4628f8f5 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -6533,13 +6533,14 @@ proc default_gdb_init { test_file_name } { > if { $gdb_wrapper_target != [current_target_name] } { > set gdb_wrapper_initialized 0 > } > - > + > # Unlike most tests, we have a small number of tests that generate > # a very large amount of output. We therefore increase the expect > # buffer size to be able to contain the entire test output. This > - # is especially needed by gdb.base/info-macros.exp. > - match_max -d 65536 > - # Also set this value for the currently running GDB. > + # is especially needed by gdb.base/info-macros.exp and > + # gdb.base/maint.exp. > + match_max -d 196608 > + # Also set this value for the currently running GDB. > match_max [match_max -d] > > # We want to add the name of the TCL testcase to the PASS/FAIL messages. Do you have details about what fails specifically? It runs fine here, so I'm curious which part of the test fills the buffer exactly. Also, my understanding is that check-read1 should have no effect on this, it shouldn't fill the buffer more than a regular "make check". It only makes it such that read system calls return at most 1 byte. Simon