From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TFi+C799+F9uMgAAWB0awg (envelope-from ) for ; Fri, 08 Jan 2021 10:43:59 -0500 Received: by simark.ca (Postfix, from userid 112) id 21E8B1E99A; Fri, 8 Jan 2021 10:43:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CB1E1E4F4 for ; Fri, 8 Jan 2021 10:43:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 226BE3854838; Fri, 8 Jan 2021 15:43:58 +0000 (GMT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 01F863854838 for ; Fri, 8 Jan 2021 15:43:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01F863854838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f48.google.com with SMTP id k10so8161770wmi.3 for ; Fri, 08 Jan 2021 07:43:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MhohZuzjcK6GynzBHcXeEwwFet/Hc9Z94Z1Qa7KvkqY=; b=M7pcpeWw7iV9ffsyNXtoC0X7TF4k6V4EhX0WzUUPYc1ZOK9SNV85Ce4uLo7p3JBdAH Ids4NwVjBuIKhs5bT9mB+V6raKOupfI7YzSVa1hwgoy3WyKVqdgwDV6+bGnFoMQ1iBRE uvcm4ktMS65IYFq2jVNciX1k8Klv01MoRKqU7jvY+FtuUCXjDGO3Nujtn8klBYc6YQIi G8kmjRkoHI057yProrDz0VwQmLJ7L6s+jmkwVBGeCSZnoefSbSqRWMfqxJFglx4PFFfs NdaGs7nbuweV4rCJWI/aiuhojFvBfaODNEmhf1p19UjB8Xyf8oUi928vY6DkHb3b4tKT Z2xQ== X-Gm-Message-State: AOAM530ADHznntvgl3sPfw2Wvemk9F2lhnrz7uQ8iE2YyDtfDZRxxQI3 25REkHzUSScTrOuAGwZCvD8= X-Google-Smtp-Source: ABdhPJyfcTgBRyraYXIb6dvHgXLV8xSB8xRIDMaonMyrRL9vO1nePWrgTrStY9n59jVoCsxkkJwtWw== X-Received: by 2002:a1c:2e88:: with SMTP id u130mr3568981wmu.83.1610120633133; Fri, 08 Jan 2021 07:43:53 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id c6sm14507697wrh.7.2021.01.08.07.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 07:43:51 -0800 (PST) Subject: Re: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace,full}.c From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-3-simon.marchi@polymtl.ca> Message-ID: Date: Fri, 8 Jan 2021 15:43:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108041734.3873826-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08/01/21 04:17, Simon Marchi wrote: > From: Simon Marchi > > The previous patch made the commit_resume implementations in the record > targets unnecessary, as the remote target's commit_resume implementation > won't commit-resume threads for which it didn't see a resume. This > patch removes them. > > gdb/ChangeLog: > > * record-btrace.c (class record_btrace_target): > (record_btrace_target::commit_resume): > * record-full.c (class record_full_target): > (record_full_target::commit_resume): Incomplete entry. Otherwise LGTM. I like how these two patches result in clearer code. Nice.