From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87038 invoked by alias); 23 Nov 2018 16:39:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87018 invoked by uid 89); 23 Nov 2018 16:39:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2960 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Nov 2018 16:39:13 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A023288304; Fri, 23 Nov 2018 16:39:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 445E55C635; Fri, 23 Nov 2018 16:39:09 +0000 (UTC) Subject: Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c To: Rainer Orth , Sergio Durigan Junior References: <96729b3f-3568-1d41-4bb8-fbe4d037da93@redhat.com> <87sgzr6g7x.fsf@redhat.com> <87mupz6fyr.fsf@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 23 Nov 2018 16:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-11/txt/msg00388.txt.bz2 -- Thanks, Pedro Alves On 11/23/2018 02:16 PM, Rainer Orth wrote: > Hi Sergio, > >> On Friday, November 23 2018, I wrote: >> >>> On Friday, November 23 2018, Pedro Alves wrote: >>> >>>> On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote: >>>>> Undefined first referenced >>>>> symbol in file >>>>> is_exited(ptid_t) procfs.o >>>>> ld: fatal: symbol referencing errors >>>>> collect2: error: ld returned 1 exit status >>>>> gmake[2]: *** [Makefile:1912: gdb] Error 1 >>>>> gmake[2]: Leaving directory >>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb' >>>>> gmake[1]: *** [Makefile:8792: all-gdb] Error 2 >>>>> gmake[1]: Leaving directory >>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build' >>>>> gmake: *** [Makefile:849: all] Error 2 >>>>> ============================ >>>> >>>> Whoops, sorry about that. I assume this works, but I haven't tried it. >>> >>> I took the liberty of running try builds with your patch on the Solaris >>> builders: >>> >>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410 >>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408 >>> >>> Unfortunately the build still fails with: >>> >>> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’: >>> ../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected ‘)’ before ‘{’ token >>> { >>> ^ >>> ../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expression before ‘}’ token >>> } >>> ^ >>> >>> BTW, it's possible to run try builds on specific builders by using the >>> "-b" option with "buildbot try". E.g.: >>> >>> buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64 >> Thanks. >> And the actual commit failed with another reason: >> >> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio >> >> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’: >> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope >> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >> ^~~~~~~~~ >> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’ >> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >> ^~~~~~~~~ >> inf_exited > > this is weird: I still see a declaration in gdbthread.h (and also > is_running and is_stopped), which should go as well. That's because I meanwhile pushed this: https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html So before that we got a link error, and now we get a compile error, which is expected. > > With just the typo above fixed, a local build on amd64-pc-solaris2.11 > has just finished; make check running... Great, thanks. Pedro Alves