From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bdhCCjZJIGoMZzIAWB0awg (envelope-from ) for ; Wed, 03 Jun 2026 11:33:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1780500790; bh=QarXQrE5SrwEDgO6Y68IUi+UHJKeIlZbZhgMK17tAX0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Cq/rsSZi21oYLFIvsFQR2H19h/ZSV/YK/euOwDkKEJOuHXpFBj/M3eNSq6rmaYVb0 vWJGS1KYrJicQPyuG2OGhwm/Q4NzoQ4vsCBcSA+9NAcjQtyEuxYM0J1w/55VMrA5ky L+Cy0gJDNJ7oWeUXf4d6XIX6lESthUkw03mS//aI= Received: by simark.ca (Postfix, from userid 112) id 16BA31E062; Wed, 03 Jun 2026 11:33:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Ca7TqIzM; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 046D21E062 for ; Wed, 03 Jun 2026 11:33:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B46774BA23D4 for ; Wed, 3 Jun 2026 15:33:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B46774BA23D4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Ca7TqIzM Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CF2A74BA2E1F for ; Wed, 3 Jun 2026 15:32:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF2A74BA2E1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF2A74BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780500745; cv=none; b=pHfY3c3GIsA2kJsNUMKActvd2OuXOqMMCwqgD6xc4N6xNyZf+mPKh2wfO8WX0M5lPmQ5+rER7ODmi959WkRBkv+XkTcHdjHmJNeLPnh1GUdjo1gvXTjx17BP6SIh8DazIDT+UqlI0IN4Lwo7m9lEQAMACQpczTgLQR8W8KCDP64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780500745; c=relaxed/simple; bh=QarXQrE5SrwEDgO6Y68IUi+UHJKeIlZbZhgMK17tAX0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XoxR73ZiIwe7JMboE3wORTFP6GqiwWFMABVvaFLyRiIzInpmQzKQZDheaIt+z14G+2U5VqIhumYpYBVacZ0nOxJNctwiY7BSYL+SGPCw8iqE8iOJCs84YEtaQtaVOFy7l7Htv5xshqoB3ha3ZDuQhf6/ruF8sa1+kkCdqmUsEnE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Ca7TqIzM DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF2A74BA2E1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1780500744; bh=QarXQrE5SrwEDgO6Y68IUi+UHJKeIlZbZhgMK17tAX0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Ca7TqIzMOb/x1PuOwu5TROFjf4WzVsAFC/4O6SkMzChVuSbBqFTzq6scHnrVr/w3z 11hQofCxUw1/ofyXGjk6lm0r3qgusnYoiBhcfAqk3ZjKNyOgIR4WMeDIhqCD734YkT 8XyNKJ7c3s0YzBKfy4P/cjSXVZd+ohOH+L99bsZo= Received: by simark.ca (Postfix) id 6A8331E062; Wed, 03 Jun 2026 11:32:24 -0400 (EDT) Message-ID: Date: Wed, 3 Jun 2026 11:32:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PP?] [PATCH] gdb: z80: Guard against missing symtab in skip_prologue To: Ronald Hecht , gdb-patches@sourceware.org References: <289d2478-6150-4499-a367-426ab9c88a40@gmx.de> Content-Language: fr From: Simon Marchi In-Reply-To: <289d2478-6150-4499-a367-426ab9c88a40@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/3/26 8:11 AM, Ronald Hecht wrote: > |Hi, this is the patch from PR tdep/34198. It fixes an internal > segmentation fault in z80_skip_prologue when setting "break main" on > some Z80 binaries. "break *main" works, which points at the > prologue/SAL path. Regression-tested manually with the reproducer from > the PR. Thanks, Ronald > https://sourceware.org/bugzilla/show_bug.cgi?id=34198 | > diff --git a/gdb/z80-tdep.c b/gdb/z80-tdep.c > index f7e207d02ec3..f2e9b09e3b91 100644 > --- a/gdb/z80-tdep.c > +++ b/gdb/z80-tdep.c > @@ -495,12 +495,17 @@ z80_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) > if (prologue_end != 0) > { > struct symtab_and_line prologue_sal = find_sal_for_pc (func_addr, 0); > - struct compunit_symtab *compunit = prologue_sal.symtab->compunit (); > - const char *debug_format = compunit->debugformat (); > - > - if (debug_format != NULL && > - !strncasecmp ("dwarf", debug_format, strlen("dwarf"))) > - return std::max (pc, prologue_end); > + if (prologue_sal.symtab != nullptr) > + { > + struct compunit_symtab *compunit = prologue_sal.symtab->compunit (); > + if (compunit != nullptr) symtab->compunit() can't return nullptr, so I wouldn't add this check (that method should be modified to return a reference, to make it clear). The patch looks good otherwise. Would you be ok with me pushing your patch with that change? Simon