From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25785 invoked by alias); 5 Dec 2017 16:32:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25776 invoked by uid 89); 5 Dec 2017 16:32:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 16:32:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vB5GWdA0003929 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 5 Dec 2017 11:32:44 -0500 Received: by simark.ca (Postfix, from userid 112) id CD4E21E585; Tue, 5 Dec 2017 11:32:39 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 4D6401E4C4; Tue, 5 Dec 2017 11:32:19 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Dec 2017 16:32:00 -0000 From: Simon Marchi To: Yao Qi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Replace gdb_static_assert with static_assert In-Reply-To: <86shcpp280.fsf@gmail.com> References: <1512422710-26693-1-git-send-email-simon.marchi@ericsson.com> <86shcpp280.fsf@gmail.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Dec 2017 16:32:39 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00109.txt.bz2 On 2017-12-05 11:29, Yao Qi wrote: > Simon Marchi writes: > >> gdb/ChangeLog: >> >> * common/gdb_assert.h: Remove. > > * common/gdb_assert.h (gdb_static_assert): Remove. > > because you don't remove this file. Woops, thanks. >> -/* A static assertion. This will cause a compile-time error if EXPR, >> - which must be a compile-time constant, is false. */ >> - >> -#define gdb_static_assert(expr) \ >> - extern int never_defined_just_used_for_checking[(expr) ? 1 : -1] > > Did you consider define gdb_static_assert as static_assert ((expr), > "")? > You don't have to change anywhere else. Additionally, one day we move > to c++17, we can replace gdb_static_assert with static_assert globally. That's a good idea, I'll do that. Thanks, Simon