From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31523 invoked by alias); 13 Jun 2017 11:08:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31495 invoked by uid 89); 13 Jun 2017 11:08:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 11:08:51 +0000 Received: by simark.ca (Postfix, from userid 33) id 891871E5A4; Tue, 13 Jun 2017 07:08:54 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 13 Jun 2017 11:08:00 -0000 From: Simon Marchi Cc: Simon Marchi , Yao Qi , Eli Zaretskii , gdb-patches@sourceware.org In-Reply-To: <689b4906-c752-d002-83d3-f03692a161d6@redhat.com> References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <83tw3n5jyk.fsf@gnu.org> <86tw3labb0.fsf@gmail.com> <83a85d5l4n.fsf@gnu.org> <93eb64489ac9d53665a144ddf5a966d5@polymtl.ca> <83wp8h40lo.fsf@gnu.org> <8660g0dzau.fsf@gmail.com> <689b4906-c752-d002-83d3-f03692a161d6@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00368.txt.bz2 On 2017-06-13 13:06, Pedro Alves wrote: > On 06/13/2017 11:23 AM, Simon Marchi wrote: > >> I have a concrete example that is currently in the pipeline. I hit >> this warning/error: >> >> /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:209:7: error: >> variable 'i' is incremented both in the loop header and in the loop >> body [-Werror,-Wfor-loop-analysis] >> i++; >> ^ >> /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:199:32: note: >> incremented here >> ALL_DEBUG_ADDRESS_REGISTERS (i) >> ^ >> >> which would require changing this code: >> >> ALL_DEBUG_ADDRESS_REGISTERS (i) >> { >> ... >> i++; >> } >> >> to either the expansion of the macro: >> >> for (int i = DR_FIRSTADDR; i <= DR_LASTADDR; i += 2) >> { >> ... >> } > > This, IMO. I think it's just that one place? It's the only instance of that particular problem, yes. >> or to a new macro that would take into account the increment: >> >> ITER_DEBUG_ADDRESS_REGISTERS (i, i += 2) // other users would use >> i++ >> { >> ... >> } >> > > That'd obfuscate too much for no real benefit, IMO. Agreed. Simon