From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EIzNHUo4V2HZBQAAWB0awg (envelope-from ) for ; Fri, 01 Oct 2021 12:33:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 76FA21EDF0; Fri, 1 Oct 2021 12:33:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 20C861E79C for ; Fri, 1 Oct 2021 12:33:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 333933857C62 for ; Fri, 1 Oct 2021 16:33:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 333933857C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633105993; bh=hWgM08pYHGnb0unfD3nsMT5AaI16tDyZ7k3fF+CBQ4E=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CBhAtUnAykhhFd8od5fsFnr2sQreVfrIoiww8+Mkw5gPfxm8oPVlUPrYzbw6CWGJP ESpRMYf1lYPdlHNfgRwK8oiZumx4Eim1D9oP67sBWwFU9vL85K0aqve+CCbUY7sfJP RyHYzhIfftQnyqn1GskPrbFLtYP37GOvTGrXupUs= Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id A242E3858406 for ; Fri, 1 Oct 2021 16:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A242E3858406 Received: by mail-vs1-xe34.google.com with SMTP id l19so12017116vst.7 for ; Fri, 01 Oct 2021 09:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hWgM08pYHGnb0unfD3nsMT5AaI16tDyZ7k3fF+CBQ4E=; b=iuwayZqBGQwbUYJ9oXznKIM1j4HzUsG6k6l/eha/P8WaT59cQlswfTRYnf57nAhx51 tlX1caOx2QxBjYvguvjsHtdIsLSLn/X+k8P18Df9msJcrq6LGFyrKc6HtIz+gBP/gD4v hX1/iRuGDb1Am5arpy7gusGy38bIaAi6jk79g5HgkxeS9pPGElUulvujmM2J4EJtwpiK SJbPaXPwp3btVmui4PXCIA3vaMUaxIgjfU885Iz3to+6qb3zBzwfyLRu2SHmL4uDGXOS 28zMnjMgVywJ3aGRXWXGpqwB+OOO0q2yobSTJF0BtIX29oFIggH/YHdqYQdOruyZEsem lMLA== X-Gm-Message-State: AOAM532O0szf6jjc+t8XXX3SZkM06m0lhO0CWkj9HIvqX5Kf/rQGDR1i hL6cwg5RVs+abAGf5KmLZ5yG/zw69A1P0A== X-Google-Smtp-Source: ABdhPJwSigTNThVqJulwcoUOR+0mpOuI7SjlGm1pJU4ePwF/HOJVYZ9DEI6Njqx/InbMD1CxXEk2RA== X-Received: by 2002:a67:b303:: with SMTP id a3mr5218954vsm.49.1633105971119; Fri, 01 Oct 2021 09:32:51 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:3c03:11ed:b1d3:f37e:d87b? ([2804:7f0:4841:3c03:11ed:b1d3:f37e:d87b]) by smtp.gmail.com with ESMTPSA id y78sm3389532vky.41.2021.10.01.09.32.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 09:32:50 -0700 (PDT) Subject: Re: [PATCH] Fix build failure for 32-bit targets To: Simon Marchi , gdb-patches@sourceware.org References: <20211001115002.1681134-1-luis.machado@linaro.org> <46f0c972-d009-d066-bc4f-689660124b63@linaro.org> Message-ID: Date: Fri, 1 Oct 2021 13:32:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/1/21 1:08 PM, Simon Marchi wrote: > On 2021-10-01 11:53 a.m., Luis Machado via Gdb-patches wrote: >> On 10/1/21 12:25 PM, Mike Frysinger wrote: >>> On 01 Oct 2021 08:50, Luis Machado via Gdb-patches wrote: >>>> When building master GDB, I ran into the following: >>>> >>>> binutils-gdb/gdb/bt-utils.c: In function ‘int libbacktrace_print(void*, uintptr_t, const char*, int, const char*)’: >>>> binutils-gdb/gdb/bt-utils.c:93:44: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uintptr_t {aka unsigned int}’ [-Werror=format=] >>>> snprintf (buf, sizeof (buf), "0x%lx ", pc); >>>> >>>> Fix this by using phex and %s as opposed to 0x%lx. >>> >>> wouldn't PRIxPTR fix it and be simpler ? >>> -mike >>> >> >> I'm happy either way, but GDB uses phex/phex_nz/pulongest much more often. >> >> grep "phex" gdb -R | wc -l >> 143 >> >> grep "PRIx" gdb -R | wc -l >> 25 > > That's probably because GDB (for historical reasons I suppose) uses > these LONGEST/ULONGEST types, so we can't use standard things like > PRIx64 directly. Although we could also define, say, PRIxLONGEST and > PRIxULONGEST and use them in format strings. > > But here, since we want to print a uintptr_t, I would also go for > PRIxPTR, it's standard after all: I pushed it with this format. Thanks!