From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1DWFBjFm1mpo6TMAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 14:49:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TimpDCNB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 059271E050; Mon, 19 Oct 2026 14:49:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D5261E04E for ; Mon, 19 Oct 2026 14:49:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 095654BA23D5 for ; Mon, 19 Oct 2026 18:49:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 095654BA23D5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TimpDCNB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2BBC84BA2E1E for ; Mon, 19 Oct 2026 18:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BBC84BA2E1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BBC84BA2E1E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792435734; cv=none; b=FZgyZYQPGpckof1hxfOabjIEjLBoLJNz1V8b8iKRtSx4RRRXsoxT5swHOoCE/PCRw1ppNY3o+O05y9THapouZD7yJ5PkxOsS1m4emetdEcVr4g7xNbAhXvc/KyHJG/7BkzMuO6p9qUi+uUsqNVma9Zf/1x1IxqtBasGOod73QTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792435734; c=relaxed/simple; bh=XkYDylMFLwfd76lJxKCHgPX4d0yOqcev7QCT7t7i6Js=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=g6KIjSMK4A4aGCcATWdUMtLZK06ZwDXgD5ppuYVbraMeKiG7EIaIJxvm4VAzY3s5TjjLdOETAizzrC0bjTOkObZ5e9g7hGJVjoNlPTay4sjsaEHmGAL2/BxnNegPgKCEQQdR1BGZZdZPbQ/PkuXB9S2bR9fL9x+ENJnj3Tbda2s= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TimpDCNB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BBC84BA2E1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792435733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aR4XjG+EW3Hqor2aeUHP4oRDGWcNoDO3SdcctqsM7xI=; b=TimpDCNB+hxzBSAJa+0CHvszpFJ8WDkHVCNkD33oU+mHXaJzAmuRD/y37273kRGExAUK8F qSJ7K/jiZLv/nRk0lx4gjy3elT1le2nd1s9+8jRLT5+YClRS4YHGCbQyOx9HQZhVuXbqxJ Mix3cOj0oNGBtIRt3BA3GerAwgBEF5Y= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-A44MVk_WP4CnJbOdRbvLwg-1; Mon, 19 Oct 2026 18:48:51 +0000 X-MC-Unique: A44MVk_WP4CnJbOdRbvLwg-1 X-Mimecast-MFC-AGG-ID: A44MVk_WP4CnJbOdRbvLwg_1792435731 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-98bcae867a1so126211241.1 for ; Mon, 19 Oct 2026 11:48:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792435731; x=1793040531; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aR4XjG+EW3Hqor2aeUHP4oRDGWcNoDO3SdcctqsM7xI=; b=kQrad5IcrDkZomz7UDLeXwbyv/oec1oEwjOU/NJ+XcUJgHVFPh48LJDzhaHi0m4z7o UWNS1iRxg8BtZTfmEZLNdHMZtWcIZ/JIGtz4zvBhmM5RJA7g9g4BMb+ImmoScYkXYqaN oTDWpkXOoPxBb1P9q/sGIaJ1sWKS57sswlsnAV7WaGo0pa/kECaCau+06gtTBT/oKbMi kOZ1CysaPMdvfioxH6zNKmLmtA1krzKQzP9wjnO2ENdCTN05ad4bQBqRIKy0PvJotvc4 Ml0AT44eFc4oNI5T9cf7NYbB5gotSrpxd30tcMuxP4T6vlFM67HUGQWkYqDF2AnPeGHz NHVw== X-Forwarded-Encrypted: i=1; AKwUvBz9uNo0KJqT8r7kr9dZ9ixIVjYrbAPpyLJE8c5C9t3KRl41+XVyxAleXFgcutDEbxJFTDahLKoeDQXa6w==@sourceware.org X-Gm-Message-State: AFq9FYJY30Fh9qucWus3FsIKtRjk9N0pSsXJGm4YT8kIv5WqHcYiGIe2 Bf3ezPXzyC0zFzzUUaRL0sLRUOYwYOUAqBQTz4L4667zU0YNoUHHOUrGbqOTqmd6e4ur/+qqKXz HX/GNookYDVezF19yP4bi74ROJ2vYkoepYiys7GLpZomQVe3abj+9Uf1FIIDgO6E= X-Gm-Gg: AYBFou3qaiszILjd8gsCib+MIoNUTD/TkcyqxgCu4xyQLYyrvT/8sZyULoTjmr6xxGv vGd/mPAqdg0t7TPNuwesOND1fCJkRh9CQJy3lVLrTt9wiqzY6sp/QTgK7ryx/7jPvvqDPMdynY9 Q7UPPwvL8lEmcsX9UHjy2DOZjPyg6Pn5pxfOu2q/ozwpUawqyGIROJsrIWrhK/zRHPg1u6vn5A3 4ZEjQhzel1LrXLTI9ARWFq8spZScHDekRFgvNTFMxJ7vnQHsWuhkEoZWszZVmCv3R1Tx4wciwXm BaWaqVC43d+GMjmZExnyy74Hs2UXMLluM5coa9FYzF3PbvZtsztjfR1D+4488y+G/IWUt4CeGQk PQt1LynToFwHnU5Epg3IGJQHMXxmpGhI9P2tPmUcQ1syP31tb X-Received: by 2002:a05:6102:15a6:b0:7c3:a6f0:99cb with SMTP id ada2fe7eead31-7cc36acf83dmr1968162137.33.1792435731106; Mon, 19 Oct 2026 11:48:51 -0700 (PDT) X-Received: by 2002:a05:6102:15a6:b0:7c3:a6f0:99cb with SMTP id ada2fe7eead31-7cc36acf83dmr1968155137.33.1792435730486; Mon, 19 Oct 2026 11:48:50 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:22e8:4ed1:527a:55c0? ([2804:14d:8084:993e:22e8:4ed1:527a:55c0]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-990bb334183sm911064241.5.2026.10.19.11.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 11:48:49 -0700 (PDT) Message-ID: Date: Mon, 19 Oct 2026 15:48:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/record-full: fix stop status when inferior isn't resumed To: Andrew Burgess , gdb-patches@sourceware.org References: <20261009143916.47983-1-guinevere@redhat.com> <87ld7t93wb.fsf@redhat.com> From: Guinevere Larsen In-Reply-To: <87ld7t93wb.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -1SxYxw_OlBeESZdZBxEHcrFs0y_Gv4PhS3Fc31oHUw_1792435731 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/19/26 11:11 AM, Andrew Burgess wrote: > Guinevere Larsen writes: > >> The wait function for the record-full target has a check for whether >> or not the inferior should be resumed. However, when we correctly >> identified that it shouldn't be resumed, we incorrectly set the exit >> status as "ignore", as though the inferior had resumed and had an >> uninteresting stop. >> >> This would cause a problem when - for example - GDB has to wait for >> all threads to actually be stopped, because we do that by waiting >> until all threads have a wait status of "no_resumed", and the "ignore" >> status would make us iterate over them and wait more. >> >> This commit fixes that by setting the status correctly to >> not_resumed. The commit does not include a test because almost nothing >> works with multi-threaded programs, and my upcoming series will >> exercise this code path plenty of times, when testing it makes more >> sense. > Thanks for updating the commit message. One tiny nit... > >> @@ -1187,8 +1187,8 @@ record_full_wait_1 (struct target_ops *ops, >> { >> gdb_assert ((options & TARGET_WNOHANG) != 0); >> >> - /* No interesting event. */ >> - status->set_ignore (); >> + /* No thread was reusmed at all. */ > Typo: reusmed -> resumed > > With that fixed: > > Approved-By: Andrew Burgess Fixed the typo! thank you for the review, I've pushed the patch. > Thanks, > Andrew -- Cheers, Guinevere Larsen it/its she/her (deprecated)