From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135708-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5436 invoked by alias); 8 Dec 2016 15:35:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3536 invoked by uid 89); 8 Dec 2016 15:35:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sweet, 1,71, H*M:4c23
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Dec 2016 15:35:27 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1cF0jE-0005bl-OR from Luis_Gustavo@mentor.com ; Thu, 08 Dec 2016 07:35:24 -0800
Received: from [172.30.6.208] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 8 Dec 2016 07:35:21 -0800
Subject: Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver.
References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-6-git-send-email-michael.sturm@intel.com>
To: Michael Sturm <michael.sturm@intel.com>, <mark.kettenis@xs4all.nl>,	<palves@redhat.com>, <eliz@gnu.org>
CC: <gdb-patches@sourceware.org>
Reply-To: Luis Machado <lgustavo@codesourcery.com>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <f7063877-4eb8-4c23-347d-42ec025b5f53@codesourcery.com>
Date: Thu, 08 Dec 2016 15:35:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1481021894-29471-6-git-send-email-michael.sturm@intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2016-12/txt/msg00210.txt.bz2

On 12/06/2016 04:58 AM, Michael Sturm wrote:
> diff --git a/gdb/testsuite/gdb.arch/i386-pkru.exp b/gdb/testsuite/gdb.arch/i386-pkru.exp
> new file mode 100644
> index 0000000..bb31c19
> --- /dev/null
> +++ b/gdb/testsuite/gdb.arch/i386-pkru.exp
> @@ -0,0 +1,71 @@
> +# Copyright 2015-2016 Free Software Foundation, Inc.
> +#
> +# Contributed by Intel Corp. <michael.sturm@intel.com>
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +standard_testfile
> +
> +if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
> +    unsupported "skipping x86 PKEYS tests."
> +    return
> +}
> +
> +set comp_flags "-I${srcdir}/../nat/"
> +
> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
> +     [list debug additional_flags=${comp_flags}]] } {
> +    untested "failed to compiler x86 PKEYS test.
> +    return -1
> +}

typo "failed to compileR". And i think "failed to compile" is short and 
sweet.

Otherwise i have no further comments on the series.