Re: [PATCHv3 1/7] gdb: improve line number lookup around inline functions

Andrew Burgess
2025-12-17T14:33:32Z

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> So my proposal is that the backward scan of the line table looking for
> Andrew> an is-stmt entry should not be performed when NOTCURRENT is true. In
> Andrew> the case above this means we will report the entry at index 9, which
> Andrew> is for line 10, which is correct.
>
> Thanks for the explanation. It all made sense to me.
>
> Andrew> + if ![runto foo] {
>
> We're bracing if conditions these days.
>
> Otherwise this looks good to me.
>
> Approved-By: Tom Tromey <tom@tromey.com>

I fixed the TCL bracing issue and pushed just this patch for now. I'm
taking a deeper look at some of the questions you raised on the later
patches.

Thanks,
Andrew