From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id F20DC3857C4D
 for <gdb-patches@sourceware.org>; Wed, 19 Aug 2020 03:39:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F20DC3857C4D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 98BC21E009;
 Tue, 18 Aug 2020 23:39:57 -0400 (EDT)
Subject: Re: [RFC PATCH] gdb: add linux_nat_debug_printf macro
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20200702193034.22279-1-simon.marchi@efficios.com>
 <87y2nopsjz.fsf@tromey.com> <3728b768-05d6-c6de-c28e-d059b71360db@simark.ca>
From: Simon Marchi <simark@simark.ca>
Message-ID: <f6d43d4a-4f2d-71ad-0fff-e7c2e9de6917@simark.ca>
Date: Tue, 18 Aug 2020 23:39:57 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <3728b768-05d6-c6de-c28e-d059b71360db@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2020 03:39:58 -0000

On 2020-08-18 10:56 p.m., Simon Marchi wrote:
> I remember I tried it and didn't like it much.  Printing longer identifiers didn't
> help readability.  And usually we have enough context to know what the debug
> statement is about, especially with the [linux-nat] prefix.

Although when dealing with lambdas (which includes SCOPE_EXIT), it can be quite unhelpful:

  [infrun] operator(): ...

With __PRETTY_FUNCTION__ it's a bit better:

  [infrun] stop_all_threads()::<lambda()>: ...

For that reason, we should maybe consider using __PRETTY_FUNCTION__.

Simon