From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VBTcHBizVGrNQAUAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 05:42:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IGv8UH6W; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eiOAiDaH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2Wabn3en; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M+YSFngK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4FE1E1E098; Mon, 13 Jul 2026 05:42:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 73A1A1E04F for ; Mon, 13 Jul 2026 05:42:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2DC04BA2E2F for ; Mon, 13 Jul 2026 09:42:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2DC04BA2E2F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IGv8UH6W; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eiOAiDaH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2Wabn3en; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M+YSFngK Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 55C374BA2E08 for ; Mon, 13 Jul 2026 09:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55C374BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55C374BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783935741; cv=none; b=SAu8tp+9/ZV/WEB0nKDjW3TtVpsm+ULm/asKHApIWFiispc/36M8zn9z8BocKbSX4yvtIZjCk7nYP4yjcBrpdNciQLaqs9kPlrTqhi7Zx7BveDC0LeM8WUC9IQvSR1WZoFNkPWLHpemBnPdmBObDFLHsGyxhzpbFckqIJBEFQX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783935741; c=relaxed/simple; bh=cK1fOpAQNmK0BI/VlT0P0LkkQUC7GTWxfVYafpqwIXA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QGexk1qAs/8kJUhdpwK4l8DfRCLu2cVUH/+XTeCBhVRNeGNf6sSDMgUzX+eQeNThxOLg8WA8LNqiw1Fz15okooTO+5KO84ozjaqP0raEZ9vbyM03AvsRWA+rsXgioh/SFwOdVYWcpJoy8TmiZgsyTst8PzmeV4r7wOKwdRoJFvs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IGv8UH6W; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eiOAiDaH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2Wabn3en; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M+YSFngK DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55C374BA2E08 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEE4575F7C; Mon, 13 Jul 2026 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783935740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/Ox/JJ2lrAlZoS4mf6N+qt1BxrZyTjqHePGap8S71o=; b=IGv8UH6WF2QM6M2endP6FUFjiNK21Q9YEVfP8shZ3ByF6mh90cbEthVxQHRZpnoMY/hbIk slS0z/hwh3HTklumAurfS+Z+6hFRL3yUQLE6EwSN16pgUFqVRubN+GGAFmwWbq5eK5S4/D I79KmZQnecB4oa1plt0f8ooDRE58Cpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783935740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/Ox/JJ2lrAlZoS4mf6N+qt1BxrZyTjqHePGap8S71o=; b=eiOAiDaHf1/pz2MWzpZaC7acumE2eaHDJUGwjg9rxOLXRccFuG0ewz3SFW7UbMiDKaeid2 TlnfWkfCjVqO/+DQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2Wabn3en; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=M+YSFngK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783935739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/Ox/JJ2lrAlZoS4mf6N+qt1BxrZyTjqHePGap8S71o=; b=2Wabn3ennkDqfx09Exs48UKvlnNjkDCpV8fe+CyxNKDey4W30yWTKyHjk786uG7GVWBfcu 1V8G0jsXwNNNThIw5KyB3trWxwE0py4MRLpL9vPF1TVoGU1kD4GIlMM4VDSLmsfPavCzV4 VWNIVE6L9fL955uTOmya8WxVCNQg6dg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783935739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/Ox/JJ2lrAlZoS4mf6N+qt1BxrZyTjqHePGap8S71o=; b=M+YSFngKZO78WVsxaW3QCkL8iPkd71WktoFGk3r2/fu/+ZOtSXVOPPQ5h4cvfUiZPLGBxT +vZpX6moDriNuhDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D736C779AE; Mon, 13 Jul 2026 09:42:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aboRM/uyVGpvBgAAD6G6ig (envelope-from ); Mon, 13 Jul 2026 09:42:19 +0000 Message-ID: Date: Mon, 13 Jul 2026 11:42:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] : add 'tomli' dependency for codespell pre-commit hook To: Stephan Rohr , gdb-patches@sourceware.org References: <20260630082043.84858-1-stephan.rohr@intel.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260630082043.84858-1-stephan.rohr@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,intel.com:email,suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: EEE4575F7C X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/30/26 10:20 AM, Stephan Rohr wrote: > From: "Rohr, Stephan" > > The codespell pre-commit hook imports the 'tomllib' module to parse > 'pyproject.toml'. 'tomllib' is not available for Python versions 3.10 > and older. Add a dependency on 'tomli' so the hook also works on these > Python versions. > Hi, this LGTM. Approved-By: Tom de Vries FWIW, I had some trouble reproducing this. I tried to reproduce this in a python virtual environment (3.10) on a system with system python 3.14. As it turns out, pre-commit creates a python 3.14 environment, so tomli is found. After setting language_version to 3.10 in the yaml file, I managed to reproduce it, and indeed your patch fixes it. Thanks, - Tom > --- > .pre-commit-config.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml > index 9910bbb82f2..1c6b018d7ac 100644 > --- a/.pre-commit-config.yaml > +++ b/.pre-commit-config.yaml > @@ -79,10 +79,13 @@ repos: > - id: codespell > files: '^(gdb|gdbserver|gdbsupport)/' > args: [--toml, gdb/pyproject.toml] > + # 'tomllib' library is not available on Python < 3.11. > + additional_dependencies: ['tomli'] > - id: codespell > name: codespell-log > entry: gdb/contrib/codespell-log.sh > args: [--toml, gdb/pyproject.toml] > + additional_dependencies: ['tomli'] > verbose: true > stages: [commit-msg] >