From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA48C3857C47 for ; Fri, 21 Aug 2020 16:16:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA48C3857C47 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A91551E594; Fri, 21 Aug 2020 12:16:11 -0400 (EDT) Subject: Re: [PATCH v6 1/4] arc: Add ARCv2 XML target along with refactoring To: Shahab Vahedi , gdb-patches@sourceware.org Cc: Shahab Vahedi , Tom Tromey , Eli Zaretskii , Anton Kolesov , Francois Bedard References: <20200326125206.13120-1-shahab.vahedi@gmail.com> <20200805110934.6225-1-shahab.vahedi@gmail.com> <20200805110934.6225-2-shahab.vahedi@gmail.com> From: Simon Marchi Message-ID: Date: Fri, 21 Aug 2020 12:16:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200805110934.6225-2-shahab.vahedi@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 16:16:13 -0000 Hi Shahab, The only thing code-wise that changed between v5 and v6 is looking for obsolete features names? If so, that LGTM (I didn't re-read the whole patch, just checked that and it looks reasonable) with these nits fixed: > -static const char *const aux_minimal_register_names[] = { > - "pc", "status32", > +/* Obsolete feature names for backward compatibility. */ > +static const char *ARC_CORE_V1_OBSOLETE_FEATURE_NAME > + = "org.gnu.gdb.arc.core.arcompact"; > +static const char *ARC_CORE_V2_OBSOLETE_FEATURE_NAME > + = "org.gnu.gdb.arc.core.v2"; > +static const char *ARC_CORE_V2_REDUCED_OBSOLETE_FEATURE_NAME > + = "org.gnu.gdb.arc.core-reduced.v2"; > +static const char *ARC_AUX_OBSOLETE_FEATURE_NAME > + = "org.gnu.gdb.arc.aux-minimal"; Should probably be two spaces for indentation here. > +/* Look for obsolete core feature names in TDESC_DATA. */ > + > +static const struct tdesc_feature * > +find_obsolete_core_names (const struct target_desc *tdesc) The parameter name doesn't match the doc, TDESC_DATA -> TDESC. > +{ > + const struct tdesc_feature *feat = nullptr; > + > + feat = tdesc_find_feature (tdesc, ARC_CORE_V1_OBSOLETE_FEATURE_NAME); > + > + if (feat == nullptr) > + feat = tdesc_find_feature (tdesc, ARC_CORE_V2_OBSOLETE_FEATURE_NAME); > + > + if (feat == nullptr) > + feat = tdesc_find_feature > + (tdesc, ARC_CORE_V2_REDUCED_OBSOLETE_FEATURE_NAME); > + > + return feat; > +} > + > +/* Look for obsolete aux feature names in TDESC_DATA. */ > + > +static const struct tdesc_feature * > +find_obsolete_aux_names (const struct target_desc *tdesc) Same here. Simon