From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id A2ED33861832 for ; Tue, 14 Jul 2020 12:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2ED33861832 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x331.google.com with SMTP id 22so5301931wmg.1 for ; Tue, 14 Jul 2020 05:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SMmVth8uGKYRHZuH2XVIs+QBauPDQryIhkTfVFZ6EMs=; b=gilgScqjBLTRu/I7wxWBOQp6L6AbUYpy4koVmpR3Kb1ZKusL/f/Mo4Uxjo4+7WDX4W NHwsNhG0i9A8+5uB61X+sW+4jdDxklmuckgAFDy06t71je+D1O3MZn0j4hdzPUxhff8g bvV82lHnf5rePLCkfk4U9MRQUbTf+knmivXqektqT1EaZEa0Z7RipjqCxmRD6yVvgSkc xyrNGgri5AioHgZ6crWGDqySze1UI/gjvrvb9VqQc1DE79bzPIXPvGesLEtra/49rnDM 1q0nJ90witiBYLN9s5H925ifffrnuWuJu9SyXgZrYr6XR+AHN1LLC/tRSEkQ606YUj9I qROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SMmVth8uGKYRHZuH2XVIs+QBauPDQryIhkTfVFZ6EMs=; b=nQXC7iYR1B//o7A8rxzo4Y1YPxGurHK/rlkbe4o91L993iKmWbcfg12bUQKhzRozGb yT+c0W/DlSEFVs4mRqITKPvdnUaX1IG8tjqcs8qvY3JEWBHIAyKVkp8/0ScGQZLlf6I3 j7343OaX6ydzF+VokEKGyCkNXb8e9V1f2/vdRLeCsZQbdSLceHiFYYfQb1bckYltV3Q+ g9jiTx/MW2f2eWop26Yg+y2QyV9dqktVyanDdP8Z3XmRCIK+BNSvt19HhSRrYZjlYgyA Nmidqm2kfsTH6mCuiUveKo2+tkrGBSl6nuBx9oXm8cyR4NJR29Yoa1oljBIg9VbDNqd/ LZeg== X-Gm-Message-State: AOAM532Y+M+zF+UCumRs3GVKNgrn0CsWdyljM/yQSoTve6X9PjXkeJ4F jMM9/TlrwQdUsQ79A8IeyN8hdQNmqpA= X-Google-Smtp-Source: ABdhPJwkMd3U89VLyprI5JCpZzAeUX/5PPhclwJ5gAsoTsdypnfvFqTPWQvEhqGvdoa/3UKIKUJXew== X-Received: by 2002:a1c:dd86:: with SMTP id u128mr4186891wmg.123.1594729634275; Tue, 14 Jul 2020 05:27:14 -0700 (PDT) Received: from localhost (host86-128-12-23.range86-128.btcentralplus.com. [86.128.12.23]) by smtp.gmail.com with ESMTPSA id t16sm30028129wru.9.2020.07.14.05.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 05:27:13 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PUSHED 2/2] gdb: Improve formatting of 'show endian' messages Date: Tue, 14 Jul 2020 13:27:08 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 12:27:17 -0000 This commit changes the output of 'show endian'. Here is a session before this commit: (gdb) show endian The target endianness is set automatically (currently little endian) (gdb) set endian big The target is assumed to be big endian (gdb) show endian The target is assumed to be big endian (gdb) After this commit the session now looks like this: (gdb) show endian The target endianness is set automatically (currently little endian). (gdb) set endian big The target is set to big endian. (gdb) show endian The target is set to big endian. (gdb) The changes are: 1. Each line ends with '.', and 2. After setting the endianness GDB is now a little more assertive; 'target is set to' not 'target is assumed to be', the user did just tell us after all! --- gdb/arch-utils.c | 8 ++--- .../gdb.base/all-architectures.exp.tcl | 4 +-- gdb/testsuite/gdb.base/endian.exp | 34 +++++++++---------- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index f89260a32b7..13ba50abe61 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -317,17 +317,17 @@ show_endian (struct ui_file *file, int from_tty, struct cmd_list_element *c, if (target_byte_order_user == BFD_ENDIAN_UNKNOWN) if (gdbarch_byte_order (get_current_arch ()) == BFD_ENDIAN_BIG) fprintf_unfiltered (file, _("The target endianness is set automatically " - "(currently big endian)\n")); + "(currently big endian).\n")); else fprintf_unfiltered (file, _("The target endianness is set automatically " - "(currently little endian)\n")); + "(currently little endian).\n")); else if (target_byte_order_user == BFD_ENDIAN_BIG) fprintf_unfiltered (file, - _("The target is assumed to be big endian\n")); + _("The target is set to big endian.\n")); else fprintf_unfiltered (file, - _("The target is assumed to be little endian\n")); + _("The target is set to little endian.\n")); } static void diff --git a/gdb/testsuite/gdb.base/all-architectures.exp.tcl b/gdb/testsuite/gdb.base/all-architectures.exp.tcl index 4c59728b8c0..34afa434b1c 100644 --- a/gdb/testsuite/gdb.base/all-architectures.exp.tcl +++ b/gdb/testsuite/gdb.base/all-architectures.exp.tcl @@ -225,7 +225,7 @@ with_test_prefix "tests" { continue } elseif {$endian == "auto"} { gdb_test_multiple "set endian $endian" $test { - -re "^set endian $endian\r\n(${osabi_warning})?The target endianness is set automatically \\(currently .* endian\\)\r\n$gdb_prompt $" { + -re "^set endian $endian\r\n(${osabi_warning})?The target endianness is set automatically \\(currently .* endian\\)\\.\r\n$gdb_prompt $" { internal_pass $test } } @@ -235,7 +235,7 @@ with_test_prefix "tests" { internal_pass $test continue } - -re "^set endian $endian\r\n(${osabi_warning})?The target is assumed to be $endian endian\r\n$gdb_prompt $" { + -re "^set endian $endian\r\n(${osabi_warning})?The target is set to $endian endian\\.\r\n$gdb_prompt $" { internal_pass $test } } diff --git a/gdb/testsuite/gdb.base/endian.exp b/gdb/testsuite/gdb.base/endian.exp index 611b0ff5fbc..3058e6294aa 100644 --- a/gdb/testsuite/gdb.base/endian.exp +++ b/gdb/testsuite/gdb.base/endian.exp @@ -18,26 +18,26 @@ standard_testfile set en_auto "The target endianness is set automatically" -set en_set "The target is assumed to be" +set en_set "The target is set to" clean_restart # First check that the automatic endianness is updated # with the `set endian' command. gdb_test "set endian auto" \ - "$en_auto \\\(currently \(\?:big\|little\) endian\\\)" \ + "$en_auto \\\(currently \(\?:big\|little\) endian\\\)\\." \ "default target endianness" -gdb_test "set endian big" "$en_set big endian" \ +gdb_test "set endian big" "$en_set big endian\\." \ "set target endianness" -gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)" \ +gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)\\." \ "auto target endianness" -gdb_test "set endian little" "$en_set little endian" \ +gdb_test "set endian little" "$en_set little endian\\." \ "set target endianness little" -gdb_test "set endian auto" "$en_auto \\\(currently little endian\\\)" \ +gdb_test "set endian auto" "$en_auto \\\(currently little endian\\\)\\." \ "auto target endianness little" -gdb_test "set endian big" "$en_set big endian" \ +gdb_test "set endian big" "$en_set big endian\\." \ "set target endianness big" -gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)" \ +gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)\\." \ "auto target endianness big" if { [build_executable ${testfile}.exp $testfile] } { @@ -49,7 +49,7 @@ if { [gdb_file_cmd $binfile] } { } set test "get target endianness" if { [gdb_test_multiple "show endian" "$test" { - -re "$en_auto \\\(currently \(big\|little\) endian\\\).*$gdb_prompt" { + -re "$en_auto \\\(currently \(big\|little\) endian\\\)\\..*$gdb_prompt" { set endian $expect_out(1,string) pass "$test" } @@ -64,31 +64,31 @@ if { [gdb_test_multiple "show endian" "$test" { if { [gdb_unload] } { gdb_suppress_entire_file "$pf_prefix cannot unselect executable" } -gdb_test "set endian big" "$en_set big endian" \ +gdb_test "set endian big" "$en_set big endian\\." \ "override target endianness big" -gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)" \ +gdb_test "set endian auto" "$en_auto \\\(currently big endian\\\)\\." \ "override auto target endianness big" if { [gdb_file_cmd $binfile] } { gdb_suppress_entire_file "$pf_prefix cannot select executable" } -gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)" \ +gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)\\." \ "previously big default executable endianness" if { [gdb_unload] } { gdb_suppress_entire_file "$pf_prefix cannot unselect executable" } -gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)" \ +gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)\\." \ "previously big default no executable endianness" -gdb_test "set endian little" "$en_set little endian" \ +gdb_test "set endian little" "$en_set little endian\\." \ "override target endianness little" -gdb_test "set endian auto" "$en_auto \\\(currently little endian\\\)" \ +gdb_test "set endian auto" "$en_auto \\\(currently little endian\\\)\\." \ "override auto target endianness little" if { [gdb_file_cmd $binfile] } { gdb_suppress_entire_file "$pf_prefix cannot select executable" } -gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)" \ +gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)\\." \ "previously little default executable endianness" if { [gdb_unload] } { gdb_suppress_entire_file "$pf_prefix cannot unselect executable" } -gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)" \ +gdb_test "show endian" "$en_auto \\\(currently $endian endian\\\)\\." \ "previously little default no executable endianness" -- 2.25.4