From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id C771F38930DB
 for <gdb-patches@sourceware.org>; Wed, 22 Jul 2020 13:15:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C771F38930DB
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 10BA31E794;
 Wed, 22 Jul 2020 09:15:29 -0400 (EDT)
Subject: Re: [PATCH 1/3] gdb/breakpoint: do not update the condition string if
 parsing the condition fails
From: Simon Marchi <simark@simark.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
 gdb-patches@sourceware.org
References: <cover.1593438119.git.tankut.baris.aktemur@intel.com>
 <a84581d9c13ee6753ad1535fb7cfecbd3a961287.1593438119.git.tankut.baris.aktemur@intel.com>
 <6460667d-3906-fd69-e0af-92c79e408fd4@simark.ca>
Message-ID: <f62e1e6e-c2ba-5c9c-1d4e-89fc04b3f3eb@simark.ca>
Date: Wed, 22 Jul 2020 09:15:25 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6460667d-3906-fd69-e0af-92c79e408fd4@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 13:15:30 -0000

On 2020-07-22 9:12 a.m., Simon Marchi wrote:
> Here, could you also test that when a valid condition exists and we try to change
> it for a bad one, the previous condition is still there after the failed attempt
> to change it?
> 
> Simon
> 

Ah sorry, I read patches in a very linear way, so I did not realize this was added
in the next patch.

Simon