From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137161-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 108126 invoked by alias); 20 Feb 2017 11:44:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 108102 invoked by uid 89); 20 Feb 2017 11:44:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Feb 2017 11:43:59 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 93C974621C;	Mon, 20 Feb 2017 11:43:59 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1KBhvp5009241;	Mon, 20 Feb 2017 06:43:58 -0500
Subject: Re: [PATCH 8/8] DWARF-5: DW_FORM_data16
To: Jan Kratochvil <jan.kratochvil@redhat.com>
References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <148693102336.9024.6339944981062939536.stgit@host1.jankratochvil.net> <3bfb48f9-168a-26ae-678b-92b059583c4e@redhat.com> <20170219212652.GE1291@host1.jankratochvil.net>
Cc: gdb-patches@sourceware.org, Victor Leschuk <vleschuk@accesssoftek.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <f6188952-5ac3-5f9a-edd0-06e3af84cba6@redhat.com>
Date: Mon, 20 Feb 2017 11:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170219212652.GE1291@host1.jankratochvil.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-02/txt/msg00538.txt.bz2

On 02/19/2017 09:26 PM, Jan Kratochvil wrote:
> On Fri, 17 Feb 2017 13:09:42 +0100, Pedro Alves wrote:
>> On 02/12/2017 08:23 PM, Jan Kratochvil wrote:
>>
>>> @@ -20250,6 +20261,10 @@ dump_die_shallow (struct ui_file *f, int indent, struct die_info *die)
>>>  	  fprintf_unfiltered (f, "expression: size %s",
>>>  			      pulongest (DW_BLOCK (&die->attrs[i])->size));
>>>  	  break;
>>> +	case DW_FORM_data16:
>>> +	  /* FIXME: Print the contents.  */
>>> +	  fprintf_unfiltered (f, "constant of 16 bytes");
>>
>> Should we fix that FIXME?
> 
> I think even the code above "expression: size %s" should print the contents
> which it does not and it has no FIXME there.
> 
> So I have just removed the FIXME.

OK.

Thanks,
Pedro Alves