From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 8175A389365C
 for <gdb-patches@sourceware.org>; Thu, 30 Apr 2020 18:28:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8175A389365C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 03D021F068;
 Thu, 30 Apr 2020 14:28:26 -0400 (EDT)
Subject: Re: [PATCH] Add support for NetBSD thread events (create, exit)
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
References: <trinity-a9d47dff-0aff-4cc6-b8bc-19887120bba8-1588255183159@3c-app-mailcom-bs10>
From: Simon Marchi <simark@simark.ca>
Message-ID: <f6032636-a016-f300-3759-66d56e69a341@simark.ca>
Date: Thu, 30 Apr 2020 14:28:25 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <trinity-a9d47dff-0aff-4cc6-b8bc-19887120bba8-1588255183159@3c-app-mailcom-bs10>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 18:28:28 -0000

On 2020-04-30 9:59 a.m., Kamil Rytarowski wrote:
> Hello,
> 
> Please review.
> 
> commit 5446f5e7983ad9383e3bc0469327c94baa5e0587 (HEAD -> netbsd-3)
> Author: Kamil Rytarowski <n54@gmx.com>
> Date:   Thu Apr 30 16:13:33 2020 +0200
> 
>     Add support for NetBSD thread events (create, exit)
> 
>     Report LWP CREATE and LWP EXIT events and setup this on post_attach()
>     and post_startup_inferior().
> 
>     Stop reinitializing the list of recognized threads in update_thread_list().
> 
>     Handle LWP CREATE and EXIT events in nbsd_nat_target::wait().
> 
>     gdb/ChangeLog:
> 
>             * nbsd-nat.c (nbsd_enable_proc_events)
>             (nbsd_nat_target::post_startup_inferior): Add.
>             (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
>             (nbsd_nat_target::update_thread_list): Rewrite.
>             (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
>             "PTRACE_LWP_CREATE".
>             * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
> 

Check the tabs/spaces and alignment in:

	    printf_unfiltered (_("[%s exited]\n"),
                           target_pid_to_str (wptid).c_str ());

Otherwise, this LGTM, thanks.

Simon