From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kZycJnFPfGeoeQUAWB0awg (envelope-from ) for ; Mon, 06 Jan 2025 16:47:29 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=dm0+ssbD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8F6AA1E0BB; Mon, 6 Jan 2025 16:47:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 724A11E05C for ; Mon, 6 Jan 2025 16:47:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16CFF3858CDA for ; Mon, 6 Jan 2025 21:47:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16CFF3858CDA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=dm0+ssbD Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170110005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::5]) by sourceware.org (Postfix) with ESMTPS id 3A9023858D21 for ; Mon, 6 Jan 2025 21:46:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A9023858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A9023858D21 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736200012; cv=pass; b=uvdLK7ZC/aeMr/6jGuDsk7D4bXPkmnAv+irlgOxwLGthct0fgKadMHZmA8zvBgZ81fTbwXm/7pdELBsCuWy+jGnVl8p+ZoMA1dpQBN+m9ckzwl9zKoI7gku6OUKITGXATz1EWYDbROISZWWEhUM3RaRrLw+JQFR7xx6a/joP/jk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736200012; c=relaxed/simple; bh=HFTSsX8zncwlabgoToXdZlU3/D/+BTQdqNrIiQwcx5o=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=tsbZelrh/e1maMjGk/f0ioYSYdPkwWAAgAZbqfh1rXYSN2fBiE9eER/ByiM8CfINXISlQYkwKoR3KK1F1DxQRR669puTONkIHF7k0IIYsQcGLmN8/lY6KTR5kKXQI6LsyL/mKYXLLqZBbeFoCHlVLVnU1jMVRgDjzSMydSXV6ng= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A9023858D21 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gJh0MzZEBv83pTSlfxxq84kHH4xNSZZjEowS7+tC2jPXyd/46jSLLumuOI84FNya8JhDxMQIWyx5CISPvD3XmgNOpFy2I3gB8KumHSaQpuVURBwrLHGile4sCsJq3cmT5ynJIV2j6T8YjokZQSR8UYBv3J85VDNmY94rW04yRuq8kk5fjGySz5fA+2RfYIzPnJDH81iCNX90WpLGVs/wavW/PNUmDxsDotpoAiB1iMm9S30KSaLgViyU159iQDARrmtewMhBX/ip+X/r5S5n09J6MYCMkfSf9drX1Jg0/7J44QBWCFJVB+stVxUVGA0zhqrzQDlQi3V4Z/TFNQtyCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d260aIoWWiFGMvdfBjifxM4aDstCltaW82Uu9aBwQSY=; b=jOkaMHLBrpguep0ABrAqT23Ed3uH+DhN//eAHWi9cQ/zNTSaz/87Jb69wpk7EoqWVxIv3bQmInJSCWubtf1n6y1+St05UvIbNmJBIUWDFYrI6t/iNXjyU+QsCmQbkqUnmtFF+8l6S1k4ZSrvyTkiAMw+cGUt0r+Ta9ZTQuYgOSoNoLFKTmtmFB1E3kOLS4bNBfZbHUd7+9BFFNTwQ5xsDVYDb/8Mc4lTt6+Qnuifg6fydnhOwAZBu0ZHpbHob93pbDy3OUrnkf5x0XFvnfhUT3fuLV6AweSVdAS6O8W24R+ujvz/KUsvsepK3m1Sf/A8LYTCvb3wToJgNYVMLpZyiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d260aIoWWiFGMvdfBjifxM4aDstCltaW82Uu9aBwQSY=; b=dm0+ssbDCVEyKyKdcUSicZoWEBwIGkq2d/DYg7V5C8AiBJkkRzOCxEVvNj0Gn1JwSZ5gRW2Dn1P78GsNlsqT0Bj0Zetv4EpD8nAluVRQQpg3M0cJzTF2RNZy+5dStQqXgdk4zI/jDufVcq7G/t1n8XxcW+9b2u77FDetX4KOK5zU5klLbqfwOq56iibw9gosMWLGgQaAH35B0fEq5CUuCW4BhbwWho1Qy4KAakeev/W33HnRlVELqW3yoKMoomGZgOQbuVBFCyFpzFb3uGV2mRFx2zhH9i1mg9u5sCBs/SkTL200v1oFqXbXSTsbko1u5lfYxmXMPeD+RATt4Q6SBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::517) by YQBPR0101MB5282.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:45::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.18; Mon, 6 Jan 2025 21:46:48 +0000 Received: from YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM ([fe80::3acd:97b8:e393:6ae7]) by YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM ([fe80::3acd:97b8:e393:6ae7%6]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 21:46:48 +0000 Message-ID: Date: Mon, 6 Jan 2025 16:46:47 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] gdbserver: use inheritance to define tracepoint contexts To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20241230-upstream-gdbserver-regcache-v2-0-020a9514fcf0@intel.com> <20241230-upstream-gdbserver-regcache-v2-2-020a9514fcf0@intel.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20241230-upstream-gdbserver-regcache-v2-2-020a9514fcf0@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0110.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::10) To YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::517) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PPF2C4930805:EE_|YQBPR0101MB5282:EE_ X-MS-Office365-Filtering-Correlation-Id: 90ad1835-fa4a-4b07-3ff5-08dd2e9b9f58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cFBCYzlpbDZJYVBkRHBUT2MrVGY0ZllRSmVuOWtLaFV4OHk5SmkvZDZKcmFo?= =?utf-8?B?bitRbW4vNEtVQkJGOWVUS21pUXpUYVdORWI5YkdidlU5elhXRWlneU1SZUJw?= =?utf-8?B?UlZQUHFJWUJYMmdFWXcxbDc0Qk5iM2oyRmhLd1RJdnlEdHBaTUNCeG1QM1RZ?= =?utf-8?B?K0p2ZHZ0bHZEVDdUZW9kUEN3eXdBeEdLNk1DbGJ4aElWZ1I2UWVTZlhlRHd1?= =?utf-8?B?RGZ5WElpVTkxR1ZxUnRjYVlaOUpFN3VUeHh5OTQ3T3daRFVsaGlzQ2swZzRJ?= =?utf-8?B?N3UxTDdOYzZmaGJHYi9DYnkvWUZJNnlNSWIrTXpieTd2dE1GcjdFMGRaRTVz?= =?utf-8?B?anBEcTNVQ2dKUTM5ckQ3QTRyVGN0cHBjL0p1Sjdzb2ZYSk1oRWRCWi90cHZJ?= =?utf-8?B?Zmp3bDFrL3A0dG1VYTJJSE9DaXM4cGhsY1UxNnBwclNKWUhRVXNIalgwbW1Y?= =?utf-8?B?WWF6blE4TTlRZGx0MjhFaXM2Z1AzNVBCUEZudEN4RWRSRlJHZ1hzQWdpZlNy?= =?utf-8?B?eG81TCt5ZmtQK1d0M2lvOXV0WjVOeUoyTElaTTRjbElYNFFGUWlKKzFMdHhF?= =?utf-8?B?ZnJoQjFwNlRBTThaVzJNSHZ3VXp0bzBXYm14ekNxNzZDYjVWeEwrcTVJdm1K?= =?utf-8?B?eUIzTDl6WUlVVnZONHpxc241c3JrbjdjYjlBNVdGOWIvcFdXMkVLd1dhNHdi?= =?utf-8?B?dUxSNGRTRE42b0tQbEhLZjdha1V3NGxIMGtzSm9NTkE0alRqN2w0YjgzMTd5?= =?utf-8?B?YnhxcDVWNXhkS0xlQjNJQnFRSGRQY2NOdlRLaENxSHpTRnVSdTdYL016Wm5y?= =?utf-8?B?azJTaVpVUjdIWWtGb3NPVG1EM0xFOHVyVUN6UXFINm11Q0Z4SEdnSFJyV1Uy?= =?utf-8?B?bU0wZTJneVhUUEVHVUhYbnRHMWdJaWQyZ0orZm5zamwyZFpMUzlXc09xR1NT?= =?utf-8?B?T2UyTzZJMktqK3hrRGs5K0xGWUd2Y3FaemdrVnZKWVk1RFdDT1pCbktSN1Iw?= =?utf-8?B?dE9QQmRydy9jMzRpMGw5SndudTY2OG11R0NGR0s1QURsL0VSOGJkWXJtc052?= =?utf-8?B?TTJmd3pBeUxzdUVCSDdDcldiRVRyeDBVak9rdkFKTDBVN1dnUHp5RjR0R2Jn?= =?utf-8?B?MDFqWUZ2RFRHQWpOZE9UVVZTcVdta01CWHRjRVU1MG80NG9KQXRrQWhCK1dP?= =?utf-8?B?aTNFblhBZkVBOWxxaXNyZHpLL0tJTjJDeElqS2V0TE1TcUlscldxajQvVFBQ?= =?utf-8?B?UDVTQ1ZFbG9uNVpBZ1FmaUtjTTUwcy9yNnB6NkJ1ckJ4dHlWbmVkekVrcG01?= =?utf-8?B?cC8wZzc4MUJ3UWx1YkVEelZyTWlCbDRDSEpGL0s4TkV4UXFPZjM1ckkramFU?= =?utf-8?B?NG5TTW9xcjJjdXhhdXNpNFJ4NzZuV1IzRHdqNEFvajMvVTN4N096aVpTeHZM?= =?utf-8?B?T3IreFEzNURHMldEcUlEckJkcnBDTHp5V0dSbnFnaXlOcW8zUm93cDMrTVBG?= =?utf-8?B?bFpxZHRFNWR2RllUTDhEbUZHYXdtQUcramtRLzZESUFEZ3BTL2dsYkEyR0s1?= =?utf-8?B?ZUtvOHRkRGVOd09EcVhsYW1kaUlkc3hwNU9Dd1dTanl3VDVjUFlhUlVZUTVJ?= =?utf-8?B?M0RoR0F3YXdOeTVjclJ4NGdBY2I2YTNDbEljQ2pPM01sd1k3dFJjaVdkVzhs?= =?utf-8?B?Vk9iTmNJM1Myd3FoS2pVd0g1b0lZczkrR0lvanZwcmdDNHMrYjhYeTgvb1lp?= =?utf-8?B?TWRFMWNKTG1OVUhhRDZuTEQwS28zU1Nkcy9VUWdRRGd1amh2QmFZRS9rS014?= =?utf-8?B?cVNmNmdwUFNJZ3RnZEIrZGVIeGQ2blA2VUIwN3RWemgwOWdhMURVR2h1eU5L?= =?utf-8?Q?r4jfmDUH9C9Bv?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck1NNUZJRHVzTzNhSkgvYUI0U09wbUFOV05vNUEwZlk4SkNhV0Q2VmxZOWhh?= =?utf-8?B?ejdCU2Qrd1RoYkozWVlwMkd2dURiVitGWHlnU0s3YVhWcldJODRYcXE2dk5G?= =?utf-8?B?Q2hod1B0TmRaYW5KTjdEckJ5TytpSklQR1ZySEw0UlA3dW1SWmQyY3RsNjQw?= =?utf-8?B?cmdJRUxlaG45NGppQ1l0ZGdYdDJmS0ROd0pHT3FzZnNmN1ZpM1JjVlpEZzl5?= =?utf-8?B?U2xycEIvR2gxcEJtQmRFL2gvNDdydFNSNUlrWUdnOXRZeS9NYXIrODF5VURY?= =?utf-8?B?cWxpY0tFODRpWlZGQkRmZ0c1ak9jTWphdWN4cW1FaXZGclAvYXZIL0NQSUQz?= =?utf-8?B?VjZ0a0ZEV1NIV0pPcEI2WFlGamRGNE5WRVNiRXIwYUFlNjcrQjhGeGxEWWhU?= =?utf-8?B?QVZJNVJUZFN4a2FNbkwwQkhBMkxWVzBiSkZIcGVrVTBWM2lzOXluRU1hbXNC?= =?utf-8?B?VENtM3VwbXVBOEUrcTBXMW1zWUxZTDE4Y0tPdVVvUVpwcTlNeHBENkNVSzY1?= =?utf-8?B?ckxUUXVwOEpqd2hzVkV3aWZZYzlFOU9iSmJZUktIMlBFLzB4VW1Bd1RpUmtv?= =?utf-8?B?bHdndmhLMUtNbndGUkRiVVJmcVBZbGpPQnIrVzE3WkxWeVYvZ3hNQ2xwMXJM?= =?utf-8?B?WVVPSGRONFh6N3Q4ME01Z1h1Y2NwYjlINjh6K1A0ZzRPOHRGWU5HNm9rSUVZ?= =?utf-8?B?dFFxbDBra1NXM2h5aHhuNEw0bEE0ekYrYzF1TGJGTUYxUUJtNjEwZ1prckI4?= =?utf-8?B?OTA2TVBkSDV3R1h2alE3ZnM4UERDR3pHWUFjUjY4UUFGU2ZKN1k2WGdDYWlQ?= =?utf-8?B?UDJHMnMyVjkrbndWaVVzM2tYOGRvbWkvVkZBYVhEdjQ2dTNjcEtQbmVEODFu?= =?utf-8?B?aFhDc05VTEUzNHdLV2l5b3cvUVJId20vdkVjcHpxNWswQUFqNlppSlAwQUVo?= =?utf-8?B?cUQxMWUxU3pldnJJdkgwK0w1Y2RhRU5UQ25iRFkveG5CcWxjQUF0N2RjQ085?= =?utf-8?B?blArMVhBQkMxQTY4YmVQdjVTQXRnbUpoSjVQak4xSm9mSUI5NEFmZzJ5RWZK?= =?utf-8?B?a0F4TGREWFNHaE1BdGs4RTZjZllOa2hnL3l4Q20xWHJHMXNtbjVnTWNlNWlV?= =?utf-8?B?ZWZRa3NYWVVpbVJ6Nyt1UmZXeDBqYnhpWXdzUkRKU1BudzMxS2FsSXdzUExn?= =?utf-8?B?QTFjSGZvMU8wb2J6K3BvQjlIQ1YwQURLN0JpaTFHUUsrbzB1bzRqNnE3VzJT?= =?utf-8?B?Zzh5YW5CbTZLQlo4YmtZY0xzNHpPY2YrNVdVTHU3Nkd0TjYwWk5NbFg5WFZx?= =?utf-8?B?dExqYWxVY1UvRWtBOHU1SU9uTG04WlJnVWM4RmdZUjczeVBXalg4QmNkbXJz?= =?utf-8?B?cnNUVnppV2R4SGpWVFU5YUlzaGVya0hwd0N2d3MrR1hNZngweDd0QjRoSFRw?= =?utf-8?B?a2hyU2R3K2Z0K3Y2bGY1aVRMTG5JeE45Y285b2o0NGNnRG1PakllZjZwYW0z?= =?utf-8?B?eDdsV1pRaFFIZ1IzdVkyMm1hVDREaURxNFdKTlFRNDZlZUcva1JqK2lCQ0pl?= =?utf-8?B?SUpTWm5zalhjdHg2VTdEeE5PYWZoMWNyWTgwNWx4cTZsQXVuL2pITXpDeTlL?= =?utf-8?B?QlpCSHpselpHcHl6WVlkR0w5Z1VvUkRST01rOEg1bEk0YmVxRHRmY254K1Vi?= =?utf-8?B?SjJlaGw5UHJlL2hSc085NTBOOWJvNUhBUU9lNFNORlZzcDlPeENndVNKVGF4?= =?utf-8?B?WVZRMXBnOWovcUd3WUNzTEROdllSdzNaekpPWkR3dlZUMVBxQWVud2xYUzZa?= =?utf-8?B?c0dEUXJ3eXNoNWtWQ1NZTlJlTStqYVRwUDlydjRIOEw5ckRLQlNQY0pBQjR3?= =?utf-8?B?M0N3U3k5RmxBTGdKZlVudEUvYlZvZFZVN2x0dUxPZkNIMjYwYTQ1bnlHeHVZ?= =?utf-8?B?VUNPdWs4M3pmZjdBOWJsZkIyb3FQR1hkK0xzelZWQkNWTmlaM0UxcEJDOTRI?= =?utf-8?B?VW05RFh5MWxIK3VQREQyM0E5ak15SitnOEtNWTJHUDJ1ZlhlMmxUYXc4bkVo?= =?utf-8?B?QkY0aXVZcTJ5VEN0bTNoSDgxZmY5N0VRRHA5bmYyZkNHUWR2YTc1Njd5T1p4?= =?utf-8?Q?+/8Qlw6nhwjdc+n1bHVQbcNag?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ad1835-fa4a-4b07-3ff5-08dd2e9b9f58 X-MS-Exchange-CrossTenant-AuthSource: YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 21:46:48.5917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FtAxoyND5BNBB5+bK0ojiQyzxjyQY3gXE30NQBOa27l8dz8ijyNuhcA0gX1iRYKLyyZEehOh+S9NI5LRxaxaIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB5282 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-12-30 05:49, Tankut Baris Aktemur wrote: > Use inheritance in the definition of tracepoint contexts. This is a > refactoring that aims to improve the code. No behavior should be > altered. > --- > gdbserver/tracepoint.cc | 107 ++++++++++++++++++++++-------------------------- > 1 file changed, 48 insertions(+), 59 deletions(-) > > diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc > index 81104b02c8321fcb4cb247a6166be10ba04aea8c..fc0586a5c5ace6edc1fc72d24511c6f36e97f759 100644 > --- a/gdbserver/tracepoint.cc > +++ b/gdbserver/tracepoint.cc > @@ -1274,7 +1274,7 @@ static char *tracing_stop_note; > > /* Functions local to this file. */ > > -/* Base "class" for tracepoint type specific data to be passed down to > +/* Base class for tracepoint type specific data to be passed down to > collect_data_at_tracepoint. */ > struct tracepoint_hit_ctx > { > @@ -1285,23 +1285,13 @@ struct tracepoint_hit_ctx > > /* Fast/jump tracepoint specific data to be passed down to > collect_data_at_tracepoint. */ > -struct fast_tracepoint_ctx > +struct fast_tracepoint_ctx : public tracepoint_hit_ctx > { > - struct tracepoint_hit_ctx base; > - > - struct regcache regcache; > - int regcache_initted; > - unsigned char *regspace; > - > - unsigned char *regs; > - struct tracepoint *tpoint; > -}; > - > -/* Static tracepoint specific data to be passed down to > - collect_data_at_tracepoint. */ > -struct static_tracepoint_ctx > -{ > - struct tracepoint_hit_ctx base; > + fast_tracepoint_ctx (unsigned char *_regs) > + : regcache_initted (0), regs (_regs) - explicit - It's fine to name the parameter `regs` too - Initialize `regcache_initted` inline - I think that `tracepoint_hit_ctx` should have a constructor that takes the type, instead of each variant initializing the `type` member > + { > + type = fast_tracepoint; > + } > > /* The regcache corresponding to the registers state at the time of > the tracepoint hit. Initialized lazily, from REGS. */ > @@ -1314,25 +1304,41 @@ struct static_tracepoint_ctx > unsigned char *regspace; > > /* The register buffer as passed on by lttng/ust. */ > - struct registers *regs; Something seems wrong, this field just disappears in the refactor. It is only used if HAVE_UST is defined, which never happens nowadays because it used a version of lttng-ust that has been deprecated for a loooong time (the 0.x series). So everything in HAVE_UST just bitrots. It might be possible to update all this code to use lttng-ust 2.x (1.x never existed), but I don't think it's going to happen unless somebody specifically asks for it. I would suggest starting with removing support for UST from gdbserver and rebasing you series, it will end up making this patch simpler. If we ever want to resurrect support for UST support and port to 2.x, we can get the code from the git history. > + unsigned char *regs; > + > + /* The GDB tracepoint matching the probed marker that was "hit". */ > + struct tracepoint *tpoint; > +}; > + > +/* Static tracepoint specific data to be passed down to > + collect_data_at_tracepoint. */ > +struct static_tracepoint_ctx : public fast_tracepoint_ctx I will have to dig deeper, but I'm not sure it conceptually makes sense for static_tracepoint_ctx to inherit fast_tracepoint_ctx. Are static tracepoints always based on fast tracepoints? (I have to stop here for now.) Simon