From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17051 invoked by alias); 14 Dec 2017 19:41:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17037 invoked by uid 89); 14 Dec 2017 19:41:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_STOCKGEN,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 19:41:34 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 269E5883A0; Thu, 14 Dec 2017 19:41:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 595AD5D97A; Thu, 14 Dec 2017 19:41:31 +0000 (UTC) Subject: Re: [RFC] regresssion(internal-error) printing subprogram argument To: Joel Brobecker References: <20171213103655.msbaxfrykc36f4a7@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 14 Dec 2017 19:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00354.txt.bz2 On 12/14/2017 07:02 PM, Pedro Alves wrote: > @@ -2271,7 +2272,8 @@ maintenance_check_psymtabs (const char *ignore, int from_tty) > length = ps->n_global_syms; > while (length--) > { > - sym = block_lookup_symbol (b, SYMBOL_LINKAGE_NAME (*psym), > + sym = block_lookup_symbol (b, SYMBOL_SEARCH_NAME (*psym), > + symbol_name_match_type::LITERAL, > SYMBOL_DOMAIN (*psym)); > if (!sym) > { Reading back the patch on the list, I realized that this must be fixing "maint check-psymtabs" for Ada. And indeed, without my patch, I get here: $ gdb ./testsuite/outputs/gdb.ada/var_arr_typedef/var_arr_typedef (gdb) start ... (gdb) maint check-psymtabs Global symbol `adaS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab Global symbol `interfacesS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab Global symbol `packB' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab Global symbol `packS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab Global symbol `systemS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab Global symbol `var_arr_typedefB' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab (gdb) After: (gdb) start ... (gdb) maint check-psymtabs (gdb Looks like we only test that command for C, currently... Thanks, Pedro Alves