From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82774 invoked by alias); 18 Jul 2018 02:51:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82609 invoked by uid 89); 18 Jul 2018 02:51:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=reserved X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 02:51:01 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 513C31E059; Tue, 17 Jul 2018 22:51:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531882260; bh=DaxwV5jr2sn7j5k3cCk+hSel2aOupQeFOZ+MiCXlC2M=; h=Subject:To:References:From:Date:In-Reply-To:From; b=vIrNmdvfKP/JdJrPqrnF7JIyMPwxrVBB2W9ZbzlfbbdHW/H67Z8DlZYVcgKI7A+ko FML2EIP6u7lNhl1GF6cv0XbPdSN4l/VNRcUCTUCqArDRQRrEsno7DaHW1UW/EKCshH Y+jATtVV6JikniVaGczCpBz7o6HzJgRT9Oza9g5U= Subject: Re: [RFA 05/15] Simplify calls to init_psymbol_list To: Tom Tromey , gdb-patches@sourceware.org References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-6-tom@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 18 Jul 2018 02:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180510222357.27332-6-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00538.txt.bz2 On 2018-05-10 06:23 PM, Tom Tromey wrote: > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index 4fd47bf92b..c1c8cba800 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -1725,14 +1725,14 @@ add_psymbol_to_list (const char *name, int namelength, int copy_name, > append_psymbol_to_list (list, psym, objfile); > } > > -/* Initialize storage for partial symbols. */ > +/* See psympriv.h. */ > > void > init_psymbol_list (struct objfile *objfile, int total_symbols) > { > - /* Free any previously allocated psymbol lists. */ > - objfile->global_psymbols.clear (); > - objfile->static_psymbols.clear (); > + if (objfile->global_psymbols.capacity () == 0 > + && objfile->static_psymbols.capacity () == 0) > + return; Hmm, isn't the condition backwards? If the capacity is zero, we want to reserve some space. But maybe we can skip the check completely... if we have already reserved the same space previously, calling reserve again does nothing (is harmless). Would LGTM with the condition fixed (assuming I am not the one being confused) or removed. Simon