From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30092 invoked by alias); 9 Jan 2018 17:22:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30025 invoked by uid 89); 9 Jan 2018 17:22:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jan 2018 17:22:44 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8392C5F165; Tue, 9 Jan 2018 17:22:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D54586E533; Tue, 9 Jan 2018 17:22:42 +0000 (UTC) Subject: Re: Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) (Re: [PATCH 3/3] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670) To: Joel Brobecker References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-4-git-send-email-brobecker@adacore.com> <20180108035724.gac5u77znunzhho3@adacore.com> <20180109094625.7udsip4v23i4d5no@adacore.com> <7b5f4115-42b6-289a-3d6f-4d4b66637a4a@redhat.com> <619dda09-5c48-447e-ead9-c9d6a5ac9743@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 09 Jan 2018 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <619dda09-5c48-447e-ead9-c9d6a5ac9743@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00188.txt.bz2 On 01/09/2018 04:45 PM, Pedro Alves wrote: > On 01/09/2018 02:59 PM, Pedro Alves wrote: >> On 01/09/2018 09:46 AM, Joel Brobecker wrote: > >>> What surprises me is that, before your patch, we were finding >>> no symbol at all. So we were failing the lookup both with minimal >>> symbols, and within the partial/full symtab. >> >> Indeed, good point. I don't know what I did not think of that. > > ... > >>> Does this make some kind of sense to you? >> >> Yes it does. I played with this a bit, and am testing a patch. >> Stay tuned. > > How about this? I pushed this to the users/palves/literal-matching branch too, btw, for easier testing, along with a follow up patch to rename language_get_symbol_name_matcher -> get_symbol_name_matcher, since the function is no longer a straight "language method". WDYT? Thanks, Pedro Alves