From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BC0D83894C24 for ; Thu, 17 Sep 2020 19:16:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BC0D83894C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5973B1E50D; Thu, 17 Sep 2020 15:16:02 -0400 (EDT) Subject: Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases To: Pedro Alves , gdb-patches@sourceware.org References: <20200917180038.29226-1-pedro@palves.net> <20200917180038.29226-2-pedro@palves.net> From: Simon Marchi Message-ID: Date: Thu, 17 Sep 2020 15:16:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917180038.29226-2-pedro@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 19:16:04 -0000 On 2020-09-17 2:00 p.m., Pedro Alves wrote: > gdb.multi/multi-target.exp sets up a debug environment with multiple > gdbservers, multiple native processes, and multiple cores, which has > proved useful for exercising a number of multi-target scenarios. > > But, as we add more tests to gdb.base/multi-target.exp, it is growing > a bit too large (making a bit cumbersome to debug) and too slow to run > (if you have glibc debug info). > > This commit thus splits the multi-target.exp into several testcases, > one per use case. The common setup code is moved to a new > multi-target.exp.tcl file that is included by all the resulting > multi-target testcases. Nice, that makes the test cases much more readable too. > diff --git a/gdb/testsuite/gdb.multi/mtarg-ping-pong-next.exp b/gdb/testsuite/gdb.multi/mtarg-ping-pong-next.exp > new file mode 100644 > index 00000000000..551e383b6d1 > --- /dev/null > +++ b/gdb/testsuite/gdb.multi/mtarg-ping-pong-next.exp > @@ -0,0 +1,85 @@ > +# Copyright 2017-2020 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test "next" bouncing between two breakpoints in two threads running > +# in different targets. > + > +source $srcdir/$subdir/multi-target.exp.tcl > + > +if {![mtarg_prepare]} { > + return > +} > + > +proc test_ping_pong_next {} { > + global srcfile > + > + if {![setup "off"]} { > + untested "setup failed" > + return > + } > + > + # block/unblock inferiors 1 and 2 according to INF1 and INF2. > + proc block {inf1 inf2} { > + gdb_test "thread apply 1.1 p wait_for_gdb = $inf1" " = $inf1" > + gdb_test "thread apply 2.1 p wait_for_gdb = $inf2" " = $inf2" > + } > + > + # We're use inferiors 1 and 2. Make sure they're really connected I just spotted this typo: "use" -> "using". Simon