From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29209 invoked by alias); 17 Nov 2017 19:43:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29197 invoked by uid 89); 17 Nov 2017 19:42:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 19:42:58 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EF477EA9A; Fri, 17 Nov 2017 19:42:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E024811A4E3; Fri, 17 Nov 2017 19:42:56 +0000 (UTC) Subject: Re: [RFA v2 0/3] Handle dereferencing Rust trait objects To: Tom Tromey , gdb-patches@sourceware.org References: <20171117192547.3515-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 17 Nov 2017 19:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171117192547.3515-1-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00373.txt.bz2 On 11/17/2017 07:25 PM, Tom Tromey wrote: > This is version 2 of the patch for inspecting Rust trait objects. > > I think this version addresses the comments from the earlier version: > > * Use a std::vector rather than unordered_map -- note that a temporary > set was needed to avoid temporarily making a gigantic vector in the > libxul case. > > * Change a reinterpret_cast to a static_cast. > > * Use readelf to check the test's debuginfo before proceeding. > > I've also tacked on a couple of patches that we discussed; one to > change the "subclass" information for struct symbol to use an enum, > and one to change template_symbol to use derivation. > > Tested on x86-64 Fedora 25. LGTM. Thanks, Pedro Alves