Re: [PATCH] Carry the gnulib getcwd backport as a patch

Tom Tromey
2018-09-18T21:39:00Z

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> Instead, I suggest we carry that backport as a patch applied by the
Simon> update-gnulib.sh script after running the import tool. It will make it
Simon> clear what backport or local modification we have and should make
Simon> running update-gnulib.sh give a reproducible result.

This seems like a good idea to me.

Simon> +# Apply our local patches.
Simon> +apply_patches ()

This should probably be "apply_patch" since it just applies a single patch.

Also there is a comment near the top of update-gnulib.sh:

# This script will also make a number of other verifications:
# . The gnulib version (it should match $GNULIB_COMMIT_SHA1).
# . The correct versions of the auto-tools that are used to
# regenerate the various scripts and Makefiles are on the PATH.

I think an addition here about updating the patches would be good.

Tom