Re: [PATCH] Carry the gnulib getcwd backport as a patch

John Baldwin
2018-09-18T21:33:16Z

On 9/18/18 2:21 PM, Simon Marchi wrote:
> Commit
>
> e2fc52e7457 ("Fix PR gdb/23558: Use system's 'getcwd' when cross-compiling GDB")
>
> backported some changes from a future gnulib version to our import.
> However, this means that every time someone wants to change our gnulib
> import (e.g. add a module), they must make sure not to include that
> backported change. It also means that someone running the
> update-gnulib.sh script without changes will get some diffs and wonder
> why.
>
> Instead, I suggest we carry that backport as a patch applied by the
> update-gnulib.sh script after running the import tool. It will make it
> clear what backport or local modification we have and should make
> running update-gnulib.sh give a reproducible result.
>
> There is a hunk in the configure file in this patch, this is because the
> commit that backported the getcwd bits didn't include the re-generated
> configure.

This looks good to me. I've verified it generates ok for me on a FreeBSD host
as well.

--
John Baldwin

Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â