From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2OUWO4aVBWBYHgAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 09:04:54 -0500 Received: by simark.ca (Postfix, from userid 112) id E37E51EF80; Mon, 18 Jan 2021 09:04:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 36C671E945 for ; Mon, 18 Jan 2021 09:04:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7A62384A033; Mon, 18 Jan 2021 14:04:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7A62384A033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610978693; bh=plhx7zzisSYJSLUU5owZ1VtJuc4QGmKg/2b8d+rD6Jc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Lu5TThP8CJ0xWS6WvmrDsvwldq0IWVpFA4Wz0SNPCsznK61TiLHYBGjU7+LAaZKIh owDcRsOKmPfKeLKpoQVDNqMTXPLd7YY6eqJM0O7gS+XOBuks1hzN1wwVs6YdzWzk5+ +X+FfacKLj3W2EXvaSprIv3gfHsN7SQFajFv83Qc= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 86655384A033 for ; Mon, 18 Jan 2021 14:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86655384A033 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10IE4hUt003170 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jan 2021 09:04:48 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10IE4hUt003170 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3B6E71E945; Mon, 18 Jan 2021 09:04:43 -0500 (EST) Subject: Re: [PATCH] sim: common: modernize gennltvals.sh To: Mike Frysinger , gdb-patches@sourceware.org References: <20210117101044.32143-1-vapier@gentoo.org> Message-ID: Date: Mon, 18 Jan 2021 09:04:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210117101044.32143-1-vapier@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 18 Jan 2021 14:04:43 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-17 5:10 a.m., Mike Frysinger via Gdb-patches wrote: > It's not 1996 anymore, so stop writing shell code like it is, and > rewrite it with modern POSIX shell standards. This makes it much > more user friendly. > > Then regenerate the file with latest newlib sources to verify. > > * Makefile.in (headers): Change args to gennltvals.sh. > * gennltvals.sh: Rewrite from scratch. > * gentvals.sh: Delete. > * nltvals.def: Regen. I suggest running shellcheck on the file an fixing what it complains about. Simon