From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47901 invoked by alias); 11 Sep 2018 16:39:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47884 invoked by uid 89); 11 Sep 2018 16:39:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=covers X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 16:39:39 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D9FF818A6AC; Tue, 11 Sep 2018 16:39:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1AFCB2142F21; Tue, 11 Sep 2018 16:39:36 +0000 (UTC) Subject: Re: PR23425, unresolved symbol diagnostic To: Tom Tromey , Alan Modra References: <20180907195832.5423-1-hjl.tools@gmail.com> <20180911021757.GE3174@bubble.grove.modra.org> <20180911151714.GH3174@bubble.grove.modra.org> <87worsqavc.fsf@tromey.com> Cc: binutils@sourceware.org, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 11 Sep 2018 16:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87worsqavc.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00342.txt.bz2 On 09/11/2018 05:04 PM, Tom Tromey wrote: >>>>>> "Alan" == Alan Modra writes: > > Alan> I think this should be OK for all the gdb uses of > Alan> bfd_simple_get_relocated_section_contents or similar code in > Alan> compile-object-load.c, but I won't commit this immediately to give gdb > Alan> folk time to comment. > > There should be gdb test cases covering the relocation cases. Yeah, you can debug an unrelocated .o file directly, like "file foo.o". The canonical testcase for that, I think is gdb.base/relocate.exp. > > For the compile feature you'll need to make sure your gcc is > compile-capable and that the needed library and plugin are installed. > > However, I believe relocation isn't only used for the compile feature. > There's this in dwarf2read.c: > > /* When debugging .o files, we may need to apply relocations; see > http://sourceware.org/ml/gdb-patches/2002-04/msg00136.html . > We never compress sections in .o files, so we only need to > try this when the section is not compressed. */ > retbuf = symfile_relocate_debug_section (objfile, sectp, buf); > > I don't know if there is a test case for this or not -- I'd hope so. gdb.base/relocate.exp likely covers this. Thanks, Pedro Alves