From: Luis Machado <lgustavo@codesourcery.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make environ.exp run on all platforms (and create info-program.exp)
Date: Thu, 13 Apr 2017 14:35:00 -0000 [thread overview]
Message-ID: <f4e1c86b-e6fb-0bf9-fc34-d609fbd17442@codesourcery.com> (raw)
In-Reply-To: <20170331172901.23402-1-sergiodj@redhat.com>
On 03/31/2017 12:29 PM, Sergio Durigan Junior wrote:
> This has been on my TODO list for a while. There's a really old bug
> about this (PR testsuite/8595), and there was no reason for
> environ.exp to be specific for hppa* targets. So this patch removes
> this constraint, modernizes the testcase, and cleans up some things.
> Most of the tests remained, and some were rewritten (especially the
> one that checks if "show environment" works, which is something kind
> of hard to do).
>
> As a bonus, I'm adding a separated info-program.exp file containing
> all the tests related to "info program" that were present on
> environ.exp.
>
> Tested locally, everything still passes.
I haven't gone through the entire patch, but i have a question. Was this
exercised for bare-metal?
If not, please make sure this test works correctly on bare-metal targets
before assuming it does just because it passes on Linux-hosted tests.
Otherwise we may have spurious failures due to tests that are not
supposed to be executed in a bare-metal environment.
If you don't have access to bare-metal testing, i could give this a try
(it may take a couple days though) and report back.
Thanks,
Luis
next prev parent reply other threads:[~2017-04-13 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:29 Sergio Durigan Junior
2017-04-12 23:30 ` Sergio Durigan Junior
2017-04-13 14:35 ` Luis Machado [this message]
2017-04-13 18:26 ` Sergio Durigan Junior
2017-04-13 18:29 ` Luis Machado
2017-04-13 18:34 ` Sergio Durigan Junior
2017-04-20 19:54 ` Luis Machado
2017-04-25 20:47 ` [PATCH v2] " Sergio Durigan Junior
2017-04-26 18:43 ` Luis Machado
2017-04-26 19:42 ` Sergio Durigan Junior
2017-04-26 22:28 ` [PATCH v3] " Sergio Durigan Junior
2017-04-27 14:53 ` Pedro Alves
2017-04-27 19:06 ` Sergio Durigan Junior
2017-04-27 22:37 ` Pedro Alves
2017-04-29 0:32 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e1c86b-e6fb-0bf9-fc34-d609fbd17442@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox