From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108961 invoked by alias); 27 Feb 2019 20:41:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108935 invoked by uid 89); 27 Feb 2019 20:41:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=LCD, lcd, spent X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Feb 2019 20:41:26 +0000 Received: by mail-wm1-f67.google.com with SMTP id a62so7223072wmh.4 for ; Wed, 27 Feb 2019 12:41:25 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id e193sm5318898wmg.18.2019.02.27.12.41.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 12:41:23 -0800 (PST) Subject: Re: [PATCH v2 0/2] MI: Add new command -complete To: Tom Tromey , Jan Vrany References: <87imynm3ia.fsf@tromey.com> <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <87pnrmnolt.fsf@tromey.com> <6de282dee73cb44ae2016cb31254aa35c04e9816.camel@fit.cvut.cz> <87mumie3e2.fsf@tromey.com> Cc: gdb-patches@sourceware.org, "gdb@sourceware.org" From: Pedro Alves Message-ID: Date: Wed, 27 Feb 2019 20:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87mumie3e2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00539.txt.bz2 I'm totally not against this new command at all, but I have to say that I'd be much more thrilled if someone just spent the time to make separate CLI/MI channels work on Windows too. The channel doesn't _have_ to be a PTY. On 02/26/2019 07:49 PM, Tom Tromey wrote: >>>>>> "Jan" == Jan Vrany writes: > > Jan> Are there any other GDB/MI users to comment on this? What would you > Jan> prefer? > > Given the lack of response, I think you should just say which you > prefer. If you think it would be better the "other" way, go for it. > Or if you'd rather the patches you already have, let me know. Jan, please consider the wildmatching case. E.g., when debugging GDB itself: (gdb) b push_bac Display all 102 possibilities? (y or n) debug_names::offset_vec_tmpl::push_back_reorder(unsigned long) debug_names::offset_vec_tmpl::push_back_reorder(unsigned long) std::__cxx11::basic_string, std::allocator >::push_back(char) ... The frontend needs to complete "b push_bac" -> "b push_back", and present the matches. But the least common denominator is not at the start of the matches strings. How will a frontend compute the LCD from the matches list alone? Please mind the "2018" copyright year in the testcase. Thanks, Pedro Alves