From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add git sha information to the gdb version string
Date: Fri, 27 Mar 2020 11:48:28 -0400 [thread overview]
Message-ID: <f4ae54e4-6922-7e83-41ae-3ea491960b4e@simark.ca> (raw)
In-Reply-To: <20200327152834.GC587@embecosm.com>
On 2020-03-27 11:28 a.m., Andrew Burgess wrote:
> * Simon Marchi <simark@simark.ca> [2020-03-27 09:56:35 -0400]:
>
>> On 2020-03-27 8:27 a.m., Andrew Burgess wrote:
>>> +
>>> + # Use the remote url pattern from the remote-repository file to
>>> + # find the local name for the remote git repository.
>>> + remote_name=$( (cd "$srcdir" && git remote -v) \
>>> + | grep "${remote_repo_pattern}" | grep \(fetch\) \
>>> + | awk -F '\t' '{print $1}')
>>
>> I just tried it locally, this is what I get:
>>
>> GNU gdb (GDB) 10.0.50.20200327-git (c13ff238f921--0)
>>
>> I identifier the problem to the fact that I have two remotes that match the given
>> URL:
>>
>> $ git remote -v | grep 'sourceware.org/git/binutils-gdb.git'
>> origin git://sourceware.org/git/binutils-gdb.git (fetch)
>> origin git://sourceware.org/git/binutils-gdb.git (push)
>> upstream ssh://sourceware.org/git/binutils-gdb.git (fetch)
>> upstream ssh://sourceware.org/git/binutils-gdb.git (push)
>
> OK. I hadn't considered that. But challenge accepted :)
>
> The new version should handle multiple remotes and identify the most
> up to date and use that one.
>
> If try the version below and do 'git remote rename origin zzzzz', then
> we should still find and use the zzzzz remote. I've done a bit of
> basic testing but more exposure would be great.
>
> Thanks,
> Andrew
It works here, if you think this is worth the extra complexity, I am fine with it.
Simon
next prev parent reply other threads:[~2020-03-27 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 11:48 [RFC] " Andrew Burgess
2020-03-26 14:55 ` Simon Marchi
2020-03-27 11:45 ` Andrew Burgess
2020-03-27 12:27 ` [PATCH 0/2] Adding git sha information to the " Andrew Burgess
2020-03-27 12:27 ` [PATCH 1/2] gdbsupport: Resolve shellcheck issues in create-version.sh script Andrew Burgess
2020-03-27 13:11 ` Simon Marchi
2020-03-27 13:57 ` Andrew Burgess
2020-03-27 12:27 ` [PATCH 2/2] Add git sha information to the gdb version string Andrew Burgess
2020-03-27 13:56 ` Simon Marchi
2020-03-27 15:28 ` Andrew Burgess
2020-03-27 15:42 ` Andreas Schwab
2020-03-27 16:18 ` Andrew Burgess
2020-03-27 15:48 ` Simon Marchi [this message]
2020-04-10 0:01 ` Joel Brobecker
2020-04-10 0:10 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ae54e4-6922-7e83-41ae-3ea491960b4e@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox