On 10.1.2017 10:29, Yao Qi wrote:

> On 17-01-09 22:18:22, Ivo Raisr wrote:
>
>> ChangeLog entry:
>> 2017-01-09  Ivo Raisr  <ivo.raisr@oracle.com>
>>
>> 	Split real and pseudo registers.
>> 	* sparc-tdep.h: Separate real and pseudo registers.
> We describe the changes in the ChangeLog, so the change can be described
> like this:

All fixed. Please see attached new ChangeLog entry and a new patch.

Kind regards,

I.

>> --- a/gdb/sparc-tdep.c	2016-02-09 19:19:39.000000000 +0000
>> +++ gdb-7.11/gdb/sparc-tdep.c	2017-01-09 13:11:30.421265402 +0000
>>
>> +static const char *sparc_core_register_names[] = { SPARC_CORE_REGISTERS };
>> +static const char *sparc32_fpu_register_names[] = { SPARC32_FPU_REGISTERS };
>> +static const char *sparc32_cp0_register_names[] = { SPARC32_CP0_REGISTERS };
> They are not used in this patch at all.  Should be moved to patch #2.

Fixed.

>
>>   
>>   /* Total number of registers.  */
>> @@ -327,17 +330,26 @@ static const char *sparc32_pseudo_regist
>>   #define SPARC32_NUM_PSEUDO_REGS ARRAY_SIZE (sparc32_pseudo_register_names)
>>   
>>   /* Return the name of register REGNUM.  */
>> +static const char *
>> +sparc32_pseudo_register_name (struct gdbarch *gdbarch, int regnum)
> Don't insert the new function between sparc32_register_name and its
> comments.  We also need comments to sparc32_pseudo_register_name.

Fixed.

>>   /* Return the GDB type object for the "standard" data type of data in
>>      register REGNUM.  */
>> +static struct type *
>> +sparc32_pseudo_register_type (struct gdbarch *gdbarch, int regnum)
> Likewise, don't insert sparc32_pseudo_register_type between
> sparc32_register_type and its type.

Fixed.

>
>> --- a/gdb/sparc64-tdep.c	2016-02-09 19:19:39.000000000 +0000
>> +++ gdb-7.11/gdb/sparc64-tdep.c	2017-01-09 13:11:51.858903807 +0000
>>
>> +static const char *sparc64_fpu_register_names[] = { SPARC64_FPU_REGISTERS };
>> +static const char *sparc64_cp0_register_names[] = { SPARC64_CP0_REGISTERS };
> They are not used, should be moved to patch #2.

Fixed.

>
>> @@ -273,28 +274,57 @@ static const char *sparc64_pseudo_regist
>>   #define SPARC64_NUM_PSEUDO_REGS ARRAY_SIZE (sparc64_pseudo_register_names)
>>   
>>   /* Return the name of register REGNUM.  */
>> +static const char *
>> +sparc64_pseudo_register_name (struct gdbarch *gdbarch, int regnum)
> sparc64_pseudo_register_name is added between sparc64_register_name and
> its comments.

Fixed.