From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5844 invoked by alias); 21 Feb 2018 14:49:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5834 invoked by uid 89); 21 Feb 2018 14:49:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 14:49:57 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w1LEnp7d024693 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 21 Feb 2018 09:49:55 -0500 Received: by simark.ca (Postfix, from userid 112) id 054D81E76C; Wed, 21 Feb 2018 09:49:51 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id BB8901E059; Wed, 21 Feb 2018 09:49:49 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 21 Feb 2018 14:49:00 -0000 From: Simon Marchi To: Yao Qi Cc: GDB Patches Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c In-Reply-To: References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Feb 2018 14:49:51 +0000 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00293.txt.bz2 On 2018-02-21 08:58, Yao Qi wrote: > On Wed, Feb 21, 2018 at 12:57 PM, Simon Marchi > wrote: >>> >>> register_dump::dump accesses 'struct regcache_desc', which is >>> declared in >>> regcache.c, so that register_dump::dump can't be moved to >>> regcache-dump.c. >> >> >> Is there any reason we can't move struct regcache_descr to regcache.h? > > The reason I didn't move is that I want to keep regcache_descr opaque. > To be clear, I don't mind moving regcache_descr to regcache.h and move > all regcache dump stuff into regcache-dump.{c,h}. I think it would make a more logical split, but I'll let you decide :)