From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130669 invoked by alias); 18 Jan 2018 16:13:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130654 invoked by uid 89); 18 Jan 2018 16:13:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1570 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 16:12:58 +0000 Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 10.8E.14322.787C06A5; Thu, 18 Jan 2018 17:12:56 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.90) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 18 Jan 2018 17:12:55 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.62.3] (192.75.88.130) by DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.9; Thu, 18 Jan 2018 16:12:53 +0000 Subject: Re: [PATCH 06/15] regcache::cooked_write test To: Yao Qi , References: <1512125286-29788-1-git-send-email-yao.qi@linaro.org> <1512125286-29788-7-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: Date: Thu, 18 Jan 2018 16:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512125286-29788-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR08CA0068.namprd08.prod.outlook.com (2603:10b6:404:b9::30) To DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19dae80e-863f-463a-6285-08d55e8e54b4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);SRVR:DB4PR07MB316; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;3:65ZhxkRcyyp5t8MVGAPcu+vvop8IhJlQY0DfL//lp8TXTssORH9MgtTLw94z27dLrSlS+rdaCtMgm7iv1DBstZTYEelN5AgWt4gPljuawBp+9kJp6w4UkKdronbvtcKLANdVIQy1gThipMK3B4IFQTrJq7Xg1Mu/CNdiVlzMvXuIHg9cMr8dSgSiVJ6AX7qhWetm47SE4mRLXee8/KAYYXy64+dVv/sReXES8SlXUUNKuy8jh5WggF0fA8O3D61H;25:FOf0NOiEEmto+9B6uluEId3nL/Wf2ffCAZSmeKR4K+uhhX4A/O3RTPHCRchmR9WXS3YJlp15VTmlVE3uPOkv4uX+93H8uvxMvOS7McdaIz0i0s5GU/cV5XqUJwjmPRv0T87pVmOSPObrB7P7X1/t8dOXlJRlW1EKdNIp2kidKO4y4zelXK3V4e2Z2xSbfgOHziBZR3kMEirn8zX2RHJB2bozSG16YUJsqmBQinU0DTlxEIYsXz5HrZ4j0DMD3S2ec9gKOHFFodwsJthK7vYrL6HlQoJwyfHl27nd9qpXkhCLoMOzhR6/5XNmO/wJ/S0VjI+tPlwJeF9Xf3Cycxhbog==;31:wGDl/K1cp7hUEEjfu7V/uJt6gNVdekDV0ZBuCuhNzjot+gvgbfVLtbcnX2l/GcA82X7S88TPaXXUnZKHIPIbZO1ZWcqH5HZygmepz0WWKVE2U4G2bBJ8SgdkLTEA7cB2KXadjOjYfb30WZoj9mzjMo9uJHSu//ghV/7QJf6B3HjQefv7chTy72tYKLZy/M477MgoP2OYxeuenqz9NtlfHKi9tjJMfo2E+8I6yOaL6W4= X-MS-TrafficTypeDiagnostic: DB4PR07MB316: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;20:nECagSymguaqw69dwt80jHVxO3xPxVBvftoGCFmlhuD9akfe/ee2arV7msGqdByfOphyI89xMpiXFgiHMnhKG1pM2R0MLwISuTqTqnW8oEUuU19mVrP+q1VsBTlLXzhz0NX/DTUAnRo/ehVq4faHvgerebUa0pFBQdINOaVomzSXHqXI7sXxdVZ1h1KQKWOW7qHgAXRLQjfR0jMLDjalDGPO3KJj7ThfufM4wN1BeP2pnAIjdYh3HwC/4/XoOfEfSlryk14VpzChXFhG6L7nRQABp4N1EA3H1OhQ6nGvpd6e0h9d5mKI25RJnL0FN4QoJmfoRk9TGkVoWPDVz8Exjy+9HO5dHk3zsNrgXYbPKmV4la7SN6dmIpKyX2CSvMN9lMlvvL1dWMCp0qOtTMYSVdESY7sjq8SdFQZYKpcO9hjrXghQt5Atqcv+gkeb8Y8HS4ZolTgTnR6ERlUVzmQQFACxN4Ban4cLF1fxXmH9fkCENrXK6IQfea4EDoS6phyM;4:Ls698DaLzFcHLxTdV7w23aWSSeZ4KMOabuvRUdjiVAxinjDhs9G3FzXrHDZY3HHvX9zODlM2pU6cA7trOdVm/3QjlDaJkugvpeBBotf5oI+zlhPXlBUvba6qs03Q/ExjWvyLOyvMDw75E/+l6TqIBmgIw/FEZPHy2WCHc4fRUlKdM+5FQWqLfVOn5g85NvGIfzlrhKZvcR5+fUGsOVq9sBGkybWOAzVbcvmERIpZ3pj8IJGec11QJUmepLUPxp0SiDYRukY8ueJMEkhprlmEtQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(2400064)(944501161)(93006095)(93001095)(10201501046)(3002001)(6041268)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011);SRVR:DB4PR07MB316;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB4PR07MB316; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(396003)(376002)(39860400002)(346002)(39380400002)(189003)(377424004)(199004)(65806001)(66066001)(65956001)(47776003)(68736007)(106356001)(2906002)(6246003)(8936002)(64126003)(39060400002)(81156014)(316002)(8676002)(81166006)(97736004)(6486002)(50466002)(16576012)(76176011)(16526018)(31686004)(229853002)(86362001)(26005)(105586002)(31696002)(4001150100001)(25786009)(6666003)(58126008)(53936002)(2950100002)(65826007)(23676004)(2486003)(52146003)(230700001)(52116002)(5660300001)(6116002)(3846002)(7736002)(36756003)(49976009)(59450400001)(305945005)(53546011)(83506002)(386003)(478600001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB316;H:[142.133.62.3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTY7MjM6dTgxZnFaWTkvVmIvRUlYajZmamROR2dpVG5r?= =?utf-8?B?RVdGYlRLeGFkVEYvMlRid09lQkFpbmh4RElmM2lHWHpLbXA0RFBJd21GeHVa?= =?utf-8?B?Ni9HYmY5UWhxUlFMZW5qSEFIam1NS2YvOHhvcTNSeGw3REdPMzJNYkhGeEF5?= =?utf-8?B?aW9OcW84akVyYkh4NzlFRjUzRW5wL1p3NmMwKys4Wis4T3dpa0Vtc0pUMmxR?= =?utf-8?B?NitOajZHdjlmcWUvVnJsT3FJT1duL21DWDQzbzBNQ0xFcUM3MmloaklhWnJB?= =?utf-8?B?clNxQW9mQXh4Y2Y0YnpwM25FMXl6MVN2VVFsY3dYV1F1azR2NWZnS2hpdHl0?= =?utf-8?B?dUpqWDNGbWJkeWM2UzNoT2xFNkE2VS9HNGtMb2RmbEFCbEFEdWQ1YkNZaWJm?= =?utf-8?B?TTEzSkhONlA2VGppRGVRdEl2WHlJYUV3eTVIa3JCSnhzNnBwbDRFZW45b1dT?= =?utf-8?B?YjJhNzRxSFdHQmxySnZjK1VwVFQvZjZ3a21sbStPS3MzYTlFZWhxQ25DWmpp?= =?utf-8?B?Rlh4OE8wVEw3ZmtEZU82NUFnOTlmcWFWL3pDSkEwa1FWUmxIS3pmYUlaSDVw?= =?utf-8?B?VWFMTFpJZ1IvYitVNlRLTHNvYlp3WGpkS251NDlKOStRZFJjdGpva2ZIaC90?= =?utf-8?B?ZFpBVlkwWnUrMUFLaTN1NHJ1S1V6YmprZ1djbDMzaTltdkNadmM0b0svekxm?= =?utf-8?B?TTZVQWt6OWNNL3k2V3dBa0tCdzA5Q1lHY2IwNkp5WXlqdWo1bFJvM3hldjJY?= =?utf-8?B?ZEM5REl0V3VaUVVCa1o4NFZjUVp1SllQSHk1UDV0bzB2Q3pYVzd6SldMRklT?= =?utf-8?B?V1RZU2F2czVwSithRnZBVGg4RW5MK0g4c1plTVhKZWlySXJMaVErMVpyOFVi?= =?utf-8?B?aXpSZGhGZFBkNnBxQVNWNmV4ejdyOXNTaHlVZnF2R1F0K2pjaXVXRitoTGRr?= =?utf-8?B?bXo1NitTZEExK1djb0VscUdEWXBlVGpUeTd4TE1FN2pvNUdsa0szT2JsVjhB?= =?utf-8?B?eWRiVWxCTFlKU3dnREF1WXd1cWo0SWx0OWhtU0F5Y2hsMHVORlBScThZa2Zn?= =?utf-8?B?a2hOTHg1YW9rWVdHNXg2ajN2ejQzS1FGMjJkU3VrYlhGTEkzUU96bkJRZmJ4?= =?utf-8?B?MjErWUVZYlZYdCtCSXoycnZDYzI5cDNnN3hTMnRVV29nc1BRcjRIZHB4dGRz?= =?utf-8?B?OGQyZ3lJM3VSTktyamRhbUxlZWp3UmQvczJHbk9sQm1ueEo2WkR3QkZiemxy?= =?utf-8?B?TGhtZUVHN2RZWHhXQ2Z4WHI2SmYxZnE3YVg3RVdMKzNtbWUxYmk0Y1BPY2NQ?= =?utf-8?B?eGxtd1dwOEV3dTVnNmRMeUZOeTNaYUNlclN4NU1QMGZTcmwrd0xzZ3JlV1Mr?= =?utf-8?B?T1FoaTlqN2ZOaWpDbkp4WURkcDNHSHJSME9tcjhMWThLSkRGY29pTmprTndH?= =?utf-8?B?L1ZhZW1NWVdScjJvY2xza000elhTOHZscDUzZnpkVVJtZkFTTVRWZG9DNjhq?= =?utf-8?B?SVBuKzR0akpSUC9WazFhd3MxUTNHTnhGNUVtK0lYajFWdWlobDdIMkNNU1cy?= =?utf-8?B?T3NPRWNscHplb2tJalRtMENsTjRjZGNCY3ltYzVmR2kzSUd1VWFjZEVzWVVK?= =?utf-8?B?YUVpV0owL2ZLOWp1bC9uNUx5YUVXYU5mUG90K1RmU3l0aE4rTHNlb09SVDI3?= =?utf-8?B?TTVYbXJXMks1RGgwNEZHS213ckF6d3MzSzYrdGkxSUgrVCs0dlBlcmVLUU9x?= =?utf-8?B?VUFtTFdiVnczSWFFaUxnMlZzR2FYbit4V3JUZ2VJWUtBdEtjNmQzV2pHV1Fa?= =?utf-8?B?WTJ4dVBRQ2g5R1g5c3pnbmVyNFF0Yy9sRGxvOEp2ZDB6UU5QSlIrL2NLemVu?= =?utf-8?B?TTh3Q2syazhJallBQk8yN1lvR2JKSCtXN3FGcnJMYUVvdzRHLysyMS9xalNM?= =?utf-8?Q?WZTb2qqwAOYi0d7GuFJd1CySQSAg8=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;6:imPcpH0ekVYyHV+IJ9JVCtUf1zhN9sE5A8Nl5IAfXRu7Gj7fVtV82xz2qW5OEtlR74YXo1uP3i2xGhgpu26zCFxXk9XVgKicYZ2r9rB4Kc6Amn/yyiUQIJLYdAUcrh2O4xZSY07yG6pKbER02KSqljLPhTHvHVXA5IbebGu5eUcGBx5rjyOZafv/MQYhZ+6hocFcGcz73dd2A9/+2sSZNJfbumTU4QFtZpOxm2669raQsE1PnButwYe+AG5Mjt+mmAeJ0188yHRoDA40p294rf6eGWp+1jUNnJDiM444pl7Ft3qnYcikTOFnkm5g9R9jAADA/6o3AxRoFyE6cpgge31xsW8EQULQkrkMHbW6TXY=;5:5vFfAhrC7dbWjwcfHE3izzHrSMjhUb4D2a4URHSieB1tKZcTF9fx0YfbdJOV8ZFtjNCsv2rFpRladJJBEeRk47gOxj8wNlz1NbOflyk/cDNF7q26miZOGPBbucuRevT7gALVwMynrvQ/Jq55Tasr3ELQUxew9+Hij1PTK0sk9C8=;24:TNGdXADB25RkqwRG+rYnU4671OUOvFaMWMPOXaIw7D4lVmm2xgCceDAgLP+ulmKXV/8pGzlo/4ZwnLh+Gge1lhuD3zR4RGbvaw/vEunARAU=;7:P7TqXWNCUlmlO/mJ3k+ezUJGJaZtCLGi536D9Qov8Bz3GIYILXvHs3nOzcP/eDa+0TVi6Ga84DLkHrymLUXCFjPGTTyk+SdDf7xgeapWZwLzCXm7jtFqX9z0l59xtJqblAwjDqtJwKcW5pSGOwqaQ6cUZuE3/MuqccSqwYihkAKBBxj7Vh4Kb62j1diDzXf0u1SybWmnvjweY/J0ZwRyyiQ+zNWSsc/ViwsLm/7pksFa1iCR8gW+UOl20MupHhIL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 16:12:53.7111 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19dae80e-863f-463a-6285-08d55e8e54b4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB316 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00374.txt.bz2 On 2017-12-01 05:47 AM, Yao Qi wrote: > Since my following patches will change how each gdbarch read and write > pseudo registers, it's better to write a unit test to > regcache::cooked_write, to make sure my following changes don't cause > any regressions. See the comments on cooked_write_test. Hi Yao, I looked at patches up to this one (the preparatory patches), and they look good to me. However, I wasn't able to properly apply patch 3 "Remove mt port", probably a git/email issue. I think you can start pushing them when you feel like it, it will ligthen the patch series a little bit, and they are good patches on their own. I noted one nit below: > gdb: > > 2017-11-27 Yao Qi > > * regcache.c (cooked_write_test): New function. > (_initialize_regcache): Register the test. > --- > gdb/regcache.c | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 124 insertions(+) > > diff --git a/gdb/regcache.c b/gdb/regcache.c > index a7a4683..4577913 100644 > --- a/gdb/regcache.c > +++ b/gdb/regcache.c > @@ -1609,6 +1609,7 @@ maintenance_print_remote_registers (const char *args, int from_tty) > #include "selftest.h" > #include "selftest-arch.h" > #include "gdbthread.h" > +#include "target-float.h" > > namespace selftests { > > @@ -1926,6 +1927,127 @@ cooked_read_test (struct gdbarch *gdbarch) > } > } > > +/* Test regcache::cooked_write by writing some expected contents to > + registers, and checking that contents red from registers and the red -> read Simon