From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56535 invoked by alias); 9 Aug 2018 17:38:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56525 invoked by uid 89); 9 Aug 2018 17:38:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:complet X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 17:38:42 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0225402332F; Thu, 9 Aug 2018 17:38:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E9BF21568A1; Thu, 9 Aug 2018 17:38:39 +0000 (UTC) Subject: Re: [PATCH 1/7] Change completion_tracker to use char type To: Tom Tromey , gdb-patches@sourceware.org References: <20180808232016.12777-1-tom@tromey.com> <20180808232016.12777-2-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 09 Aug 2018 17:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180808232016.12777-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00223.txt.bz2 On 08/09/2018 12:20 AM, Tom Tromey wrote: > This changes completion_tracker to use the char type for the quote > char. This avoids some narrowing warnings at the places where > quote_char() is called. See comment about use of int vs char here: https://sourceware.org/ml/gdb-patches/2017-07/msg00228.html Look for "Why int". Thanks, Pedro Alves