From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103680 invoked by alias); 25 Oct 2016 13:22:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103665 invoked by uid 89); 25 Oct 2016 13:22:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:U*uweigand, traveling, sk:uweigan, U*uweigand X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 13:22:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9CB28C057FA0; Tue, 25 Oct 2016 13:22:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9PDMbLu017656; Tue, 25 Oct 2016 09:22:38 -0400 Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual To: Tom Tromey , Ulrich Weigand References: <20161024122802.AE37B11C284@oc8523832656.ibm.com> <87y41damyl.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 25 Oct 2016 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87y41damyl.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-10/txt/msg00698.txt.bz2 On 10/24/2016 02:36 PM, Tom Tromey wrote: >>>>>> "Ulrich" == Ulrich Weigand writes: > > Ulrich> This seems to have broken my SPU daily build (running on RHEL 5 with a > Ulrich> GCC 4.1 system compiler): Any chance you could install the newer GCC from DTS on that machine? Otherwise, if/when we go C++11, that builder will stop working. > Ulrich> gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has > Ulrich> virtual functions but non-virtual destructor > > Ulrich> Is this a C++ version issue? > > I don't know. Adding a "virtual" to the destructor is safe though. I > would do it but I'm traveling this week. Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall at some point. With GCC 7 / trunk: $ make WERROR_CFLAGS="-Wnon-virtual-dtor" dwarf2expr.o ... In file included from .../src/gdb/dwarf2expr.c:28:0: .../src/gdb/dwarf2expr.h:68:8: warning: ‘struct dwarf_expr_context’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] struct dwarf_expr_context ^~~~~~~~~~~~~~~~~~ I'll add the "virtual" in a bit. Thanks, Pedro Alves