From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kGtACl+WvGGADAAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 08:53:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 2685A1F0CE; Fri, 17 Dec 2021 08:53:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B99D1EDEE for ; Fri, 17 Dec 2021 08:53:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 331333858410 for ; Fri, 17 Dec 2021 13:53:34 +0000 (GMT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 855A23858D28 for ; Fri, 17 Dec 2021 13:53:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 855A23858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id y196so1651006wmc.3 for ; Fri, 17 Dec 2021 05:53:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Ol1vLMfNnJY0i2uArT8wkjOmUkKY6xFeI9dNz58TolQ=; b=Qr+xFetT9dFXb9GBE6ay0z+BfgdSi3iZ78dgC1YUCWkr2k1TURe4pjCz3DSfsOOj0d 87mY3enwsZXxaM40N2B5ARlyd+3wMIZoWiRWisF0aEelhHAxFFp0chHGC4Z/0gvc7tF8 /TIQSeV/uptEWkjnO3QG1MNAGwD134lKscrUUWf2EhnnFFWJTo1dJtbLlOBl/MqGRn7q y1r2YXcf32/Hlvy3/qHeko+4EMif2gikj3vkgCySYSGCnHZyP/JSQmSsswgrKu+L19LY 5opyZOLKVWnN4kk0uobtQKBKoDSqZDOZ77ZgEIqSAWEh4AAmP25SBfRrphhADQe4cU+d 5haw== X-Gm-Message-State: AOAM531tv38O/rXIt0+XI9hm0RMxzp0x5OCeZd7n5weRwgQyp1ux7gPv qBiyj3mAY9DV9R8kQYrhgK4= X-Google-Smtp-Source: ABdhPJzGFitc1d4TH8RxeeofNvR/KFqnSOB6AzJSNzK38Q7o1rEkWecDa0EaICuHN2fGY4HzbmR6hQ== X-Received: by 2002:a1c:c908:: with SMTP id f8mr2796523wmb.193.1639749202638; Fri, 17 Dec 2021 05:53:22 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id u23sm7116177wmc.7.2021.12.17.05.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 05:53:21 -0800 (PST) Message-ID: Date: Fri, 17 Dec 2021 13:53:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 10/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-language.exp Content-Language: en-US To: Lancelot SIX References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-11-lsix@lancelotsix.com> <4a9abcaf-c1e5-99a2-5c52-54a260769d08@palves.net> <20211216235943.e7bofy6q7yja4wgf@Plymouth> From: Pedro Alves In-Reply-To: <20211216235943.e7bofy6q7yja4wgf@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-16 23:59, Lancelot SIX wrote: > On Fri, Dec 10, 2021 at 09:56:51PM +0000, Pedro Alves wrote: >> On 2021-11-26 23:00, Lancelot SIX via Gdb-patches wrote: >>> When running the testsuite, I have: >>> >>> Running .../gdb/testsuite/gdb.mi/mi-language.exp ... >>> DUPLICATE: gdb.mi/mi-language.exp: set lang ada >>> >>> Fix the erroneous test name. >>> >>> Tested on x86_64-linux. >>> --- >>> gdb/testsuite/gdb.mi/mi-language.exp | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gdb/testsuite/gdb.mi/mi-language.exp b/gdb/testsuite/gdb.mi/mi-language.exp >>> index d1e4503b6f9..a4e946e3789 100644 >>> --- a/gdb/testsuite/gdb.mi/mi-language.exp >>> +++ b/gdb/testsuite/gdb.mi/mi-language.exp >>> @@ -45,7 +45,7 @@ mi_gdb_test "-data-evaluate-expression --language c \"sizeof (void*)\"" \ >>> # Double-check that the current language has not changed. >>> mi_gdb_test "show lang ada" \ >>> ".*The current source language is \\\\\"ada\\\\\".*" \ >>> - "set lang ada" >>> + "show lang ada" >>> >> >> FYI, you can also just remove the last argument, as it defaults to the command string. >> Less duplication that way. > > Done. > > Thanks for the review. This is OK. Thanks, Pedro Alves