From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98892 invoked by alias); 18 Jul 2018 14:32:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98871 invoked by uid 89); 18 Jul 2018 14:32:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=20928 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 14:32:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1531924320; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V0eHH6iv9zhtkgjLTCwMR2rXuzcc8RLQVtr+9X+55iA=; b=C+0O7V260XnCx8XNqX9H1EsMVKGDgbJAR3tMh5EJ0CfqkyJUaORihgHiue83NZtk qADnN46IYKxw4u0GPf4F4dk9ETEnPHuQatg0vPJSc7qRNW+lG+XiyF08j8a+c9Lb PIr/NzMZFy2gukOKdu0nR7BcfYQB1RLSa3zNPE6NQII=; Received: from ESESBMB505.ericsson.se (Unknown_Domain [153.88.183.118]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id B3.80.22015.06F4F4B5; Wed, 18 Jul 2018 16:32:00 +0200 (CEST) Received: from ESESBMR502.ericsson.se (153.88.183.134) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 18 Jul 2018 16:32:00 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESBMR502.ericsson.se (153.88.183.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 18 Jul 2018 16:31:59 +0200 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 18 Jul 2018 16:31:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq5R6lkSX+XDRoLzpcyDblPHDDU1gzTLJEZTEjHEz8A=; b=NWSklYpmQ7O+1DCDlINF1fu6rsxjVsirzfiN84nFHdFdY6NPzX5Deot/+8pJjq0qzWTtKsmgL8c9zCDP0h22b0ozwclgT8IYSE5up+YLS5Km3VqVWA4p8YVTcRLA6xYRExmBdO7wVGZ8okXdVE8NJHQSRgUUvl4TBsWbNyvEcCM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by DM6PR15MB2394.namprd15.prod.outlook.com (2603:10b6:5:8d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Wed, 18 Jul 2018 14:31:56 +0000 Subject: Re: [RFA 13/15] Add psymtab_storage::allocate_dependencies To: Tom Tromey , References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-14-tom@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 18 Jul 2018 14:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180510222357.27332-14-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00554.txt.bz2 On 2018-05-10 06:23 PM, Tom Tromey wrote: > diff --git a/gdb/dbxread.c b/gdb/dbxread.c > index c3741fda8a..e1aed48ff7 100644 > --- a/gdb/dbxread.c > +++ b/gdb/dbxread.c > @@ -2092,13 +2092,8 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst, > > pst->number_of_dependencies = number_dependencies; > if (number_dependencies) > - { > - pst->dependencies = XOBNEWVEC (&objfile->objfile_obstack, > - struct partial_symtab *, > - number_dependencies); > - memcpy (pst->dependencies, dependency_list, > - number_dependencies * sizeof (struct partial_symtab *)); > - } > + pst->dependencies > + = objfile->partial_symtabs->allocate_dependencies (number_dependencies); There is a memcpy that disappears here, probably not intended? Same in xcoffread. Otherwise, LGTM. Simon