From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 49LTLqQt4mk6jR4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 08:55:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UN/FoxTq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD6A21E0C3; Fri, 17 Apr 2026 08:55:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E38861E0B1 for ; Fri, 17 Apr 2026 08:54:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 537574CCCA22 for ; Fri, 17 Apr 2026 12:54:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 537574CCCA22 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UN/FoxTq Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id AE5AF4CCCA0E for ; Fri, 17 Apr 2026 12:54:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE5AF4CCCA0E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE5AF4CCCA0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776430470; cv=none; b=o9L5oya7T/Nr+HTMmk/flRbisnf9dERry6vUe3ZJReHfL8uyXbz9UIt8aGs9PvIU7hBBAmofOSwV/0Va4eOH7Edy/sP4EmOWZHJxr4nry4ZtyoictOFfrAprtbcDijdnAtvs/lr3U7GOC45wg38KTbJfOrou9tLyR/7p1sp5YDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776430470; c=relaxed/simple; bh=IM5cun3syyzUfPJHFrwK5RnOjBU7j37d7q96unzQNRY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=oLh38Y5upjvoCfcuVk998JpEF+NY6Uqoe26tZrNBKJ/Ngk/FSPHth3GXR5NgMtERyXSv8+RgNgAJ8hWTsteDfMjESEr8rIieLLbT99ssJoqeod8gAtCgIBkoXGE80iUDnuSDAu/N9uNW2cTxHw02D4FqZj6/RPDKUhtFIHoVY2Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE5AF4CCCA0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776430470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bxrgheuy7hXVQtpq3D40AJ09AqOHKAC6d4Ao0iCRHZ8=; b=UN/FoxTqv/+/MtC7ULTVQEd/Z8dtW44ilbyxo5KQLVysygL7lfsUr6EmtoaSBfMaXVv4/D h91JBqXO+33jWDxoeSPjMOO9t+3pxsCMi7zHyi2RKDtFrB4Go7m+u2kUPCKmVAlJMezko0 B5TxgFjV1Bipvt8vuRtD3PZiVfjhXsM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-L_2zhLxBPXOKQBEaDtyTQg-1; Fri, 17 Apr 2026 08:54:29 -0400 X-MC-Unique: L_2zhLxBPXOKQBEaDtyTQg-1 X-Mimecast-MFC-AGG-ID: L_2zhLxBPXOKQBEaDtyTQg_1776430468 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-56f6c1b294fso3818662e0c.0 for ; Fri, 17 Apr 2026 05:54:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430468; x=1777035268; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bxrgheuy7hXVQtpq3D40AJ09AqOHKAC6d4Ao0iCRHZ8=; b=WSuXmvqWCVVvwnmg/T7fymLwlaijdlLv8jXtGEoPl03/3CCCOANcThJJY/5WKHn7fX dgJtqP3vyakGbbGndSqFp9lHvGAkFee5ikETFgFF1WT5I4pCNdyCzfnjMgD5DcZ2YNIG lH+HcS6J14eh4xjwsaEujfriDwd9yIvKlyXAYfP3BppOfWnOPRSePyuGu7To8HTHGluE 5DAsM2OYusYDqewmBVceKU+SH2r6uFW7fXqP6KqcSrE6xkreK5a9zCS+ppHufiL6yuxT Gfd3ZCJy60BL9C8k/uSRgLGMahsbyshPwyJMjDnAjemFG3nyd5X554wZFahWcUt83BLI DVdw== X-Forwarded-Encrypted: i=1; AFNElJ/ASok2gim2USgP/gJ120DWY8zibKiszs61dZznaptHMZW5vSnAmQXy1jRuNDwkxxpH512uGc0fbz+AiQ==@sourceware.org X-Gm-Message-State: AOJu0YzcpYQBiXPQO8gQHsZ1JFhmHNseFsUpHLY9FeObAcH4Xo2jnWaN dr+M5GGtevy6PWgoNqLS3JhFdkLnJQP/J+/0zuI0xzNd6oyiiUWUkQc0IpK25VymfGZaG0nirMo BdegNZpYffHkcb6UUFvFSFLEhcHtFVvh9gimrx47ptEeGJW2k8yDfDCZCERbZN/RxW6DwdZM= X-Gm-Gg: AeBDievXnrayTCDNm0rXy2ntjfjXjLbdwpHt9S5o//FTpRNMGyqPtkquJ+KOOoaYmgO 2tNWiQ4gJ6vEI6fiYZejWAgOcCF8qayqN2V8dDqny8GaZBG+lXfmgLWiZzHfeZhbyHXucBN9qzI HzYImq0tK3aWt7VztASe/ujGGy6m0nJjHbZh5vol9KQjvVzSqn3aX4IuBivQp7gLveO//jL9Mb+ oj9YzaoL7t7sFc/BHIlqFp6Ies9wf0FJCv5ux8ULyz4oopyIzqwxo8jC2CEbKHdkaIf9ETSgs9e YL2Pc8mYCGe20jGw0uVO1rZ3NgRAeEjHRAtd/DmDQAbtH+kjzumV01N2mIngvZ/nB0EQutyGT9p /2+80nPHo6aQHPIX4iBEngtm8pJUCX3GX/dF5I2NBhg== X-Received: by 2002:a05:6122:2913:b0:56b:a7de:7129 with SMTP id 71dfb90a1353d-56fa6697f14mr604571e0c.7.1776430467878; Fri, 17 Apr 2026 05:54:27 -0700 (PDT) X-Received: by 2002:a05:6122:2913:b0:56b:a7de:7129 with SMTP id 71dfb90a1353d-56fa6697f14mr604564e0c.7.1776430467441; Fri, 17 Apr 2026 05:54:27 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56fa91ea606sm779609e0c.5.2026.04.17.05.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 05:54:26 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 09:54:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, testsuite: fix gdb.base/save-history.exp for native-extended-gdbserver To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260417103543.2135788-1-tankut.baris.aktemur@intel.com> From: Guinevere Larsen In-Reply-To: <20260417103543.2135788-1-tankut.baris.aktemur@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jVWK31Yns-lzOyO70-Cvv2PwJcjKppI73k30r57FHjE_1776430468 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 7:35 AM, Tankut Baris Aktemur wrote: > When executed with the native-extended-gdbserver board file, we get > > FAIL: gdb.base/save-history.exp: check history contents > > This is because the history file contains an extra line for the > command 'target extended-remote ...'. To keep the test > straightforward, skip it if using the extended-remote target. > --- > gdb/testsuite/gdb.base/save-history.exp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/save-history.exp b/gdb/testsuite/gdb.base/save-history.exp > index bb7a56b2a72..5ca47f3bc1f 100644 > --- a/gdb/testsuite/gdb.base/save-history.exp > +++ b/gdb/testsuite/gdb.base/save-history.exp > @@ -19,6 +19,13 @@ > > require {!is_remote host} > > +# A remote server adds extra setup commands in history. To keep the > +# test straighforward, skip extended-remote target. > +if {[target_info gdb_protocol] == "extended-remote"} { > + unsupported "test not aimed for extended-remote target" > + return > +} > + > gdb_start > > # Get something in history. I feel like the test would be equally straight forward to make the following change instead (comment omitted because I was lazy in local testing): --- a/gdb/testsuite/gdb.base/save-history.exp +++ b/gdb/testsuite/gdb.base/save-history.exp @@ -30,6 +30,9 @@ gdb_test_no_output "save history $filename" \  set expected "set height 0\n"  append expected "set width 0\n" +if {[target_info gdb_protocol] == "extended-remote"} { +    append expected "target extended-remote localhost:2345\n" +}  append expected "print 23\n"  append expected "save history $filename\n" -- Cheers, Guinevere Larsen It/she