Re: [PATCH 00/24] C++ification of struct so_list

Pedro Alves
2023-10-17T19:21:21Z

On 2023-10-10 21:39, Simon Marchi wrote:
> This series modernizes the struct so_list area by C++ifying it a little
> bit and replacing the manual linked list implementation with
> intrusive_list. It also contains a few other cleanups written along the
> way.

Very nicely split. Thanks. I sent a few comments, but nothing too serious.
The only thing on my end that requires some churn is the pointer vs reference
thing in the disposer. Otherwise, all LGTM.

Oh, I did notice that "struct so" ends up as an ungreppable/unsearchable
name, and wondered whether that is going to make our lives harder in practice.
Maybe we should consider renaming it to "shared_obj" or "shobj" or something easier
to grep. Or maybe it doesn't matter. But no real strong opinion, I think I'm OK
with "so" too.