Re: [PATCH 00/24] C++ification of struct so_list

Pedro Alves
2023-10-20T14:40:54Z

On 2023-10-17 20:53, Simon Marchi wrote:
> On 10/17/23 15:20, Pedro Alves wrote:
>> On 2023-10-10 21:39, Simon Marchi wrote:
>>> This series modernizes the struct so_list area by C++ifying it a little
>>> bit and replacing the manual linked list implementation with
>>> intrusive_list. It also contains a few other cleanups written along the
>>> way.
>>
>> Very nicely split. Thanks. I sent a few comments, but nothing too serious.
>> The only thing on my end that requires some churn is the pointer vs reference
>> thing in the disposer. Otherwise, all LGTM.
>
> I dropped the "use reference in disposer" patch.

Right, thanks. I somehow thought that that would have some cascading effect
in the following patches. That's what I meant by churn.