From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id A8S8JCGsimdSohIAWB0awg (envelope-from ) for ; Fri, 17 Jan 2025 14:14:41 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gUFKrKNR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 86F591E100; Fri, 17 Jan 2025 14:14:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F32401E05C for ; Fri, 17 Jan 2025 14:14:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84A15383F85D for ; Fri, 17 Jan 2025 19:14:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84A15383F85D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gUFKrKNR Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E0312383F851 for ; Fri, 17 Jan 2025 19:14:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0312383F851 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0312383F851 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737141247; cv=none; b=GLIhi3+Gqz4uwtbvsvC6yHs/MEKbAaduMaeexW9M1ljUZ6gN1dHxsWQmhZpJKzOEy2VRqClwXyymIjlqSVjOU00nG2JEUyf7Nd3GwhY2AfxYfHAi2qwYkaaYJGCHuRAr8HSshuzdVVRnY0h0plfgNr1ja2uzyEOqKLLXJxIA0JQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737141247; c=relaxed/simple; bh=VesHsUk02zLE+7JL5dFLDBtCKZn/RwU5GajIgYd8RhI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=o3ICjEXtY5hFHPtJbKs/Lu5BhjTb9ruKwQ+uNWDAc8PEsD1l8ngj5CofmYuSgcIMCKytogDhyeCI66GOuAJxRjJ4StIWO3HNX2cw2QHB+KAvXxReY/TRIb58kL66lnmPk2m2DdqzjZOG7B2zd/zwoMzPZ+Z1hb8pEqQJf4EMpKo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0312383F851 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737141246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRjTp7Hy4iJUol9AfTUYpnjqkNANPHaKNMjypScZi8g=; b=gUFKrKNRlafgh33dAx6uH+7cZb8aS/p/pTO+vy0S6BydPogmY9/An2jFBIeLHxsALkuImg ezGAA27orUcu56y+PZyHCvuGNP6ZJElCRy1i2IoyyD71pwqwtf+g+hfgjp0IPL8WrR5BiI +hEPqsDkcTdqE512bTTQB01FQ/oM+AE= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-8DeGz7ELOGOZ_rKY5WO8uQ-1; Fri, 17 Jan 2025 14:14:05 -0500 X-MC-Unique: 8DeGz7ELOGOZ_rKY5WO8uQ-1 X-Mimecast-MFC-AGG-ID: 8DeGz7ELOGOZ_rKY5WO8uQ Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-21648c8601cso44198255ad.2 for ; Fri, 17 Jan 2025 11:14:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737141244; x=1737746044; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CRjTp7Hy4iJUol9AfTUYpnjqkNANPHaKNMjypScZi8g=; b=Ec4UGlwTIvNVqeYOAvkbWkYBC8BkkKszNmJQbu0beL7MZ9u14ebhK7f1cwo3YSJvBK IJxxdukJ/0MI/GYQ3GObMwzmjG/XYCyn0cpzEg1/UAU33+PufBzMUwNT1BPQYtDsUss1 D/MNp+AC+PSudmu70tl2HCFh8UubR0L+Q9MCnMcEUJltkZBdd9vkXulzIs964lIgp0p2 jV45BPZE5OfmVhoQu8nr2T1Xu51Guw39/sYBSPgvsLPxryYjR8ySMCakjvWjip+D5kSi gspiiVPbv3u9m+ZdEwdqHK4JdKNTM30BcvY8676IFh3Ad73SqUZ9kWjRijvM5ub1FDsd 1jRw== X-Forwarded-Encrypted: i=1; AJvYcCXw3fFJaaHmM2bfu+S2y36p2liwXDxdWik5YkwxizyJQ1v0zIs3r8bHaR9Bb6YznOM9rb2vB5tDkSZnSA==@sourceware.org X-Gm-Message-State: AOJu0Ywx7g1YDsjiTHxBY5kI20JPEzMkd/0Ny1pCjJtP5s7kaTxj/NAy 7Ho/x26lUs+hov2UHGstWlsK4HE1WwaLkZmNmwbcEgLQ8PdzjHqan7w7EofpMsIT3ggisA2lBjz 9sjv0uOxQuPgIOyD1TjnnKO94kUEBCAMkDR2FCPSX0nepzRfkkFd+Y0yU+PUBauRfxcY= X-Gm-Gg: ASbGncum3pF913l0IOr60wvGBFjRsGWL3OAT99ITA5uXeHwe9W/g84zt5dFCH/VMknt LZX3hMQw3AoS0h+7GI+PBknbCniCas8GF1p5wj6T7eiyKx2vl37jPYE8welDJCfmgzZhr+74PfS RERsD1J6zXi5mbarhjJCAs6BiVzPj3k3Wg+AwlMYzYH0PRMvDjclJFRCH6aVUNL+o4iToWnis24 0QlKCZ5KdHjllrgcPVxwCCDPu1aLn9c16hBvjlrgaiNzCfE1mpNS9V8e1vgVYLt3CZH X-Received: by 2002:a17:903:41c3:b0:216:386e:dca with SMTP id d9443c01a7336-21c3554c994mr54646735ad.30.1737141243810; Fri, 17 Jan 2025 11:14:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZ55TSbLbWHfnp/oeybpL10au3+BL+MU2xGyDrasewq/04o5Yfrbym9H3NdQb8N+YlqwZfgg== X-Received: by 2002:a17:903:41c3:b0:216:386e:dca with SMTP id d9443c01a7336-21c3554c994mr54646405ad.30.1737141243483; Fri, 17 Jan 2025 11:14:03 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1002? ([2804:14d:8084:9a69::1002]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d3d9891sm19465065ad.192.2025.01.17.11.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 11:14:03 -0800 (PST) Message-ID: Date: Fri, 17 Jan 2025 16:14:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Simplify get_frame_unwind_table To: Tom Tromey , gdb-patches@sourceware.org References: <20250117190453.1405884-1-tromey@adacore.com> From: Guinevere Larsen In-Reply-To: <20250117190453.1405884-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3LURDZFw1US5FX04p46RCvOzfHzA_2Y19UL0Vaw0Jps_1737141244 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/17/25 4:04 PM, Tom Tromey wrote: > This simplifies get_frame_unwind_table, changing it to use the > registry 'emplace' method and to pass the initialization iterators to > the constructor. This fixes a build problem on x86 -- reported by the > auto-builder -- as a side effect. I've tested this on buildbot and it fix the build. I encourage you to push it! Tested-By: Guinevere Larsen -- Cheers, Guinevere Larsen She/Her/Hers > --- > gdb/frame-unwind.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c > index fab9b3c981a..33b23f91feb 100644 > --- a/gdb/frame-unwind.c > +++ b/gdb/frame-unwind.c > @@ -73,15 +73,10 @@ static std::vector & > get_frame_unwind_table (struct gdbarch *gdbarch) > { > std::vector *table = frame_unwind_data.get (gdbarch); > - if (table != nullptr) > - return *table; > - > - table = new std::vector; > - table->insert (table->begin (), standard_unwinders.begin (), > - standard_unwinders.end ()); > - > - frame_unwind_data.set (gdbarch, table); > - > + if (table == nullptr) > + table = frame_unwind_data.emplace (gdbarch, > + standard_unwinders.begin (), > + standard_unwinders.end ()); > return *table; > } >