From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S2omIzQpHmkEsBQAWB0awg (envelope-from ) for ; Wed, 19 Nov 2025 15:31:48 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=K3kIuonC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7ED541E048; Wed, 19 Nov 2025 15:31:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A2EDB1E048 for ; Wed, 19 Nov 2025 15:31:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 354473850850 for ; Wed, 19 Nov 2025 20:31:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 354473850850 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=K3kIuonC Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8B4E9385F039 for ; Wed, 19 Nov 2025 20:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B4E9385F039 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B4E9385F039 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763583719; cv=none; b=QHMkjqPle20/Ba/D1H0MB8BxTa+AsR6t67E6td3E3AjaVKFxPCIEyNv8Y6MStS8j0Kr4cC/7rY8DnYYIyoVPtVUvUn27/GEq9puy+eMkjhfKm1cbZvM5hlWRXEAcB4CYoDaIllLJsTKHeDO8uzvq0lqqGQtwCtQLwPAF/Y0QyBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763583719; c=relaxed/simple; bh=t1xkNGF2Q0u7WuCAbM6ikoZgjwxPjmw0vQrhZi19tpk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KxPB4K0KprapHNVTW1iMhFitMC7kzmcx7B8TWeXRcVvkdiVrVtJ0f3o3Fz8WXCa6ae1dqfMA6Nn0z9Su+gUlKye82yenRBV5EkvkQAvQznk2feQcdzrb4tCwr37xeC/2V892QKhZTRp0HQIyEW6qsEBS9jwkP403qPawX1oU8uE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B4E9385F039 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 5AJKLkh7135481 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Nov 2025 15:21:50 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 5AJKLkh7135481 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1763583711; bh=d3tIeYTqEQOrgIbQvwrmqdQ2DHzN/kZ2uilavBUxUT0=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=K3kIuonCzVxUZK+YlCHH+J+yH7yszi0GDA4jg47rg/o5RVjYG06b1K4odohEf9oka dMHj4666B7vUT6PA5kZqSQ9XovwQw6m0exSPwNwEBAAFLhzaHvTsW25SBiljx08zGX hWlCQ/FpXvpgVpQYlHh/mQJ+vgtG1GKnAK/Oc1dXUtT5+wfcNsJw/JfAmisxppXOXl 9va2+/DdL0GBlgGvHl/cufmrxAmIOXV0rRe/XJjRdmYDR2YpAT8Bm4N0SOHfSvdNk0 b+2dJ3MLPYLMqitDZYKOnUwcuFS+nAXFT7hlduxKivnU1E/OC7L2/Qc+Vhk8KOcCpY mXeMdm0hVTU1A== Received: by simark.ca (Postfix) id AF4331E048; Wed, 19 Nov 2025 15:21:45 -0500 (EST) Message-ID: Date: Wed, 19 Nov 2025 15:21:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] gdb/testsuite/dwarf: use single abbrev table in .dwo files To: Tom Tromey Cc: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20251107211041.520697-1-simon.marchi@efficios.com> <20251107211041.520697-2-simon.marchi@efficios.com> <87zf8jth4t.fsf@redhat.com> <3dcd5b63-8055-491b-a7d3-4548204134d4@polymtl.ca> <87ikf6qa7e.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87ikf6qa7e.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 19 Nov 2025 20:21:46 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-11-19 11:05, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> # Must be run on local host due to use of objcopy. >>> if {[is_remote host]} { >>> return -1 >>> } > > Simon> I don't understand why that wouldn't be possible if debugging on a > Simon> remote host. Here, we are building target objects, we have a toolchain > Simon> for the target, so we should have an objcopy for the target that we can > Simon> run. It should be possible, in theory. Am I missing something? > > Most likely just nobody ever wanted to try it. > > Simon> Since build_executable_and_dwo_files returns -1 if the host is remote, > Simon> causing the test to exit early an cleanly (although we could perhaps add > Simon> an untested call somewhere), do we really need the require at the top? > > No opinion on that but I do agree that build_executable_and_dwo_files is > missing some 'untested' invocations -- some "return -1" paths call it > and some do not. Ok, so I'll make a patch to add untested calls to these code paths. And I'll remove the gdb_remote_download call from the test: if someone wants to make build_executable_and_dwo_files work with remote hosts, they will have to modify all tests using build_executable_and_dwo_files anyway (or, build_executable_and_dwo_files will do the gdb_remote_download, in which case individual tests won't need to). Simon