From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kZPAOUNesWoDoC0AWB0awg (envelope-from ) for ; Mon, 21 Sep 2026 12:41:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E75F81E051; Mon, 21 Sep 2026 12:41:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 42B071E01F for ; Mon, 21 Sep 2026 12:41:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 755204BA23FB for ; Mon, 21 Sep 2026 16:41:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 755204BA23FB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010011.outbound.protection.outlook.com [52.101.69.11]) by sourceware.org (Postfix) with ESMTPS id 3F8B34BA23F3 for ; Mon, 21 Sep 2026 16:41:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F8B34BA23F3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F8B34BA23F3 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.69.11 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1790008860; cv=pass; b=hGLzVyzJeOumYtSumzRXDudc6MrD9hCeSWXTDZlGYC8DCtHnDScF21iEMC8xl6KeBsKVH6RICNv3195nkarYRd6E24+PruId1F4g9ZeHCoO5Qjo0FhGPmgMOtE58i7mzizZWkZTGVdxHDzyAl8EqTY6P45no+l28prybv77ibiQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1790008860; c=relaxed/simple; bh=iWBHSI1VSGJb2X08COWnw+aQgkS8kZUdlnfOJxlHQ6E=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:From:Subject:To: MIME-Version; b=aXVA8Q7eYiD6IRKqtZXXycKe8OEH2qutpPZSIVBNTagx0dK1CccfyGJCZs+yv++9yEpRWKdLb/O2iipjO3ji0u6FtBL+o1hyRE1aZGy6bnQ6mMyg5HjB5jpZxdDY88JuCeb5e3hMRLRIharo6fSasNgGdTXWV2vl/dwFo7hPbgs= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fAsCzI7t DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F8B34BA23F3 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=esE3vcx4xG980XDwJz4cGNzC5mEx5xYQB9HoZIcdwu4yZokQo5R/84S37osbvq1Uit1GgeQW3Kl99kDEA1gx05E/o+i6O3vpOIuDInoz61kOaovwINA4CBdx6yPF1nY4GER41aDKgMWMdCaVdXdscCTH5uNwu1QZm1XTL0l1DGudIMfRqioNtSypcFBFA5r8lYjSDYFBepNkDdTvrPpmTDWeRqcQNqwsUOchHQbAqT+b0TgthK7+I9GILNwu3kJPz9INs11dvqkBtO8zsGsKCFYfEMs9Gym/rrBNKXUh4wP/1vUZYVrNr/Pq8vAvTUqO9OBiksXo6B2wsoO9gXFdJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+iuNKgbH/R4YdDy5F3+nOLNkWEsohZDWT1YYHNGuyc=; b=HA72+xswhcQm8g+n1exJ4JPDLMPTgbLU8L/DaGDEKFRv4k0utw8xh0mBLwNhZwFFLR3RxQOduwW4x0WA34xZf4gAWXsJKAwq8QNi0J1L6uMfbM1SffmyoJglOy1OV/hJ5erJMzJGNCNCzivI1ydQHXaDhoNwV4V40eExUvPFVGJwhSCnogB1lr181V5hlaz2u3lIV4xanGdXbOt/cHAyso4KlgmKh/uqNtD9jn6mf3r8bwsWsVGzJ+mzdFKFxrzA3cu+2hy1CviWF/t/LqjfYrGWp4Knc/AbN37tMVSGXNxKSQV0eScAkqpS7MDazSdY3n71FuJHUBnZKMZMJFg9UA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=redhat.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+iuNKgbH/R4YdDy5F3+nOLNkWEsohZDWT1YYHNGuyc=; b=fAsCzI7tC0PiMXzynRWx3T115gA0wtKCm5Xk6TptdnJ2SyDQpwLxVg5CgptAkNaZUVxVz4G9wgMlXo/soeXtJ6aH6not/bDK8CoXqhh6F6AIcwPx0zpFfGTwQPcwsWqezJfPwIo8D2Ei+h5ogIoAO7rPc5q/eVxTMWlnafwZfpA= Received: from DU2PR04CA0182.eurprd04.prod.outlook.com (2603:10a6:10:28d::7) by AM8PR08MB6353.eurprd08.prod.outlook.com (2603:10a6:20b:361::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Mon, 21 Sep 2026 16:40:51 +0000 Received: from DB1PEPF000509E8.eurprd03.prod.outlook.com (2603:10a6:10:28d:cafe::a2) by DU2PR04CA0182.outlook.office365.com (2603:10a6:10:28d::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.16 via Frontend Transport; Mon, 21 Sep 2026 16:40:51 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF000509E8.mail.protection.outlook.com (10.167.242.58) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Mon, 21 Sep 2026 16:40:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RGdvv9uGbYYM5m+x2c2n6by2c95QXaH7zHrDzdV8MPbeNH4oKATPMqNlnVOcW/g8iV19ykg4ezfBdQZX1Bn2zU1IfVzfyUnavX3c9TOZEKH75V4anckx27dHmik8+Ey2CT0LdEQ34B2Yuk3VDO1b6AKPv4j/NlZqzNEFnukfyB/MAXjttaeaAATqjrO9qvxfh68fee598RfYT55tpNVu2vtMZkD8I18d3ftuU0CMPEiLXju0C626czO8amZRCQVm0FRT5j86Vl3IfGO+Ifo6pBgYBlN2jkvd7Y4coYywaX0rOAF7hb5KRP5MH/tzQ2J+O8x1NZvVzFvMzn4KFIgUFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+iuNKgbH/R4YdDy5F3+nOLNkWEsohZDWT1YYHNGuyc=; b=rfd/wcMNECdEjR8d+/VtEEAqZrAItPpXgPjGVgd08IOKeo8v1gL4zOBFRaJgYb282jwv3iJRzAkR2czqidYMD2Hv0SyiSrHvqHFGRHePmHSxn2mrRxJw6Bo0gwFgsPwXNycEB0kBT/1zlIuBLWBzQzhocHau/2beWPMOUNWTpa/p3WS7bGh1mUxt2/fSEhokLYGjakI7y88I5e8EC/9hyYcSBxDYlho6cgOxIeIzNXW54EvXRIm8ep1pC6UZPvdpUa+C3EEyuNr0PMtj9lTJOvyFk+3FOOXkVEf6RWmDUYl6I76/f37SRFqZe2kHh8xr3KlXCwZhDGC7Yifo3gBv/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+iuNKgbH/R4YdDy5F3+nOLNkWEsohZDWT1YYHNGuyc=; b=fAsCzI7tC0PiMXzynRWx3T115gA0wtKCm5Xk6TptdnJ2SyDQpwLxVg5CgptAkNaZUVxVz4G9wgMlXo/soeXtJ6aH6not/bDK8CoXqhh6F6AIcwPx0zpFfGTwQPcwsWqezJfPwIo8D2Ei+h5ogIoAO7rPc5q/eVxTMWlnafwZfpA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by MMZPR08MB506501.eurprd08.prod.outlook.com (2603:10a6:190:3e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.13; Mon, 21 Sep 2026 16:40:18 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0451.012; Mon, 21 Sep 2026 16:40:18 +0000 Message-ID: Date: Mon, 21 Sep 2026 17:40:16 +0100 User-Agent: Mozilla Thunderbird From: Matthieu Longo Subject: Re: [PATCH v2 4/6] gdb/linux-tdep: migrate linux_info_proc to file_reader_t To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi , Thiago Jung Bauermann , Luis Machado , Luis Machado , Christina Joos , Kevin Buettner References: <20260825100912.514232-1-matthieu.longo@arm.com> <20260825100912.514232-5-matthieu.longo@arm.com> <87a4ppdq5a.fsf@redhat.com> Content-Language: en-US In-Reply-To: <87a4ppdq5a.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0108.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::10) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|MMZPR08MB506501:EE_|DB1PEPF000509E8:EE_|AM8PR08MB6353:EE_ X-MS-Office365-Filtering-Correlation-Id: ee954036-45ca-42b3-c371-08df17ff1874 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|366016|1800799024|23010399003|10067099003|56012099006|6133799003|3023799007|11063799006|22082099003|8126099003|18002099003|4143699003; X-Microsoft-Antispam-Message-Info-Original: A40+xvMtn8ouN3VIxfYrF66WkNjb8w2KKpI6E76TR2F2+x7QA9dm4LIPL0GRO463X7Y/rPvGVh7hQrf8Je1Lh6EdXEP36IllvJO/GvFZS5z1gA0dbBrT3rqRglSFP8NZ5jmkCcD1J4Twcwr7Ot7EG/WAzTRqywmtPD1oiY81dPw+NpjKfRRwI7W9tpWj3ZHPqHRUcWvlO+PFXxoCy3egSySVZGBrpl37n/sUll7YmunZqd6PZtmDed/8U2muvLANxWLQ8wUNeyWqdGcvVa0a2y/SmUuossv+UsL4TPhKG07SSufKLB+m4TdFwIFCIcaCRASiLYEJiURkF3PPZ4QV8pENy5qjS5ttBzHaGwE1+udq3ewKskwtrP1qjOS1M3KQjGHsNcZSgz1Ro5WDsYTMiVkHFEfgm4If5FQtWEwOogw9H28818FuVtt/uAE03iCPoc321ExpSI2HQUES3w/dgjOwX7kcb8/BNJ+1fVzmHEWNZpWGTjSMbmjnJI2wJlLLfUSpzYmpxHVFiJoVwc0mj5z1Jb9SeM50H2tA4hsjEED69uMIYmmSdlMluTm6jWEUAY9Dax+p++LshAepZoRijzo/r4Q4EbvAW4x0s+44aYKOAM7jMSC5kH/JXY2RwBW/fviQPgpcZCPsVdnrQA3IanW94LfyELtXMKarEHOeR0Y= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(10067099003)(56012099006)(6133799003)(3023799007)(11063799006)(22082099003)(8126099003)(18002099003)(4143699003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: ER2CLkQD8iXPB+UWhTRyFuawMAMP+jqHjffdx5j0XMLp0akThvYRscRw5DGXbXoG7GBOXWzSfBPpWdb94zpihtiYkee4tq03Cvf/T+8CqyKCAmzwdx8+XJ7vZwwSeEX4A6XgObs683y901BLPMbjjhop7fUCHx/NV6fIWmRUgCGvYCgp+sBOnSChyDNplCLGD5ScOyiTmbKCPpA6CcR7WqmC3O9Uj1MKcJpI/xHb2/pd6KfgF/PsAEKPkK35APBp0/zSegugotH6K4PygHo3Fa9PxDEdJpWYaloh8Z9Oy8I6FL456UYwdKamWbeL7OA/d6HlOUj6uiUqGdA3MXf3oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MMZPR08MB506501 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dfe12a0d-c8ab-4d54-3530-08df17ff04d7 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700016|1800799024|14060799003|23010399003|35042699022|4143699003|8126099003|6133799003|11063799006|56012099006|18002099003|22082099003|3023799007|10067099003; X-Microsoft-Antispam-Message-Info: GDkW4ik1UEV+nmTaEsCNRRdKvWUoxpXuFqXzEtBtkdnaEtgI04d6hBBtrmMKkyYS8W0ite4d8B2NfH4jQf8DGRE3V9PD6BhIPuo9zHiWT5wSr3PsapF9kU4elSn3XLIlpgLFwAt+uCz/sx84AlKoVDV/YFPzBC7kyLCjE/objagrnjIfaCSX7fX1KuVbXmBIe9oBLGIRGu/JsFqrRuH58QIUzA5/MqEZkHh41VJCdEYS9E5Pu4PdMOdWeH5WEwL2hVo+ad9TYMZDzmWrN02u9mbFiJMPuRdwlTiff75OyX8PYBJkL3LZzFDAkmWkBS+ya5LcxLbzO1IIS38xHqCQUle9/28tNptpwSNH8fxnDbRaVTYMUhJgx9LVAH8iopgn3G4O6mX6+uBJj3B4qeM7Za5qPM9wjhrkX87CeW2G+C9gRMLH42oeyB1+mv694A33CwGoqh4VUT45kAAdOadrxle5dP/emyqDTahwaOrLfa5fybsPmy9lCDO8YUlRBaD6ccxddwALNCKECLd0BalCL3kLhNYcA23BMQqqSC3jC/wuymgKMnplBdFomZneN2u1kIRGQ/Jwz3pVd3aUtnjejEkBHQj+QKXLTcPtzakY9HS2Tz79R+VoTCDn3lz4kuikBUiIa5agwjs5JKc5rfm+H37X+A4RJVpLnGAHPZgGmuImIaRBB6x5NreS+GmCiHBVdV5fFlOtlKrSg983Pfgz8w== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(14060799003)(23010399003)(35042699022)(4143699003)(8126099003)(6133799003)(11063799006)(56012099006)(18002099003)(22082099003)(3023799007)(10067099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wBadgzNI07A0p/lXBEiJGLbSmp5LTplz/WN7BAZ5NSg8I7mvw1ZQEWyMcaiAOBfNMovCKVrOsllA3cW18HueCWPc2YdF0Ry3Cd3hX0THE1pYMxIm7SP1hb7dmUuE2Xa+AZAYiT76Z13ZHgWjCu2vHPcI+mboOPE8Fgm629eNmVqrECSJEE86jcMMMifdSpT2g3oeFS3+nHXFQrg0ns5HwycUofciPb8C5rYnn3KWl+jXlN28xK79gfkdg6L46SyQEX52anuToud3aACpy2w3sOPHPK2vbemDJmwma3iQrCDy+JF780DajlQrN7j/WfZ34Q7bRT/H0Wh7N/MTi8a+Oraoh1sO/31PfL72/QC6TR5Xj+KgXvc/KSq2rZXDV3yswO3KZJU8NHTfo2oooNIj/YSwCoHVEf5U45gPVybiE2TBV+sqAph7Xw3QoDfmmD6+ X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 16:40:50.3222 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee954036-45ca-42b3-c371-08df17ff1874 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6353 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/09/2026 17:31, Andrew Burgess wrote: > Matthieu Longo writes: > >> The patch migrates the code of linux_info_proc to use file_reader_t to >> read the procfs files. >> The availability of array_views allows to also simplify the logic in >> several places, where null-terminating characters are replaced by spaces, >> or where the file content is iterated line by line. >> In the last case, a new helper function, extract_string_view_from_buffer, >> encapsulates the logic for such iterations where string are separated by >> tokens. >> >> Reviewed-By: Thiago Jung Bauermann >> --- >> gdb/linux-tdep.c | 135 +++++++++++++++++++++++++++++------------------ >> 1 file changed, 84 insertions(+), 51 deletions(-) >> >> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c >> index 84614bc91a0..e2c5b2d8815 100644 >> --- a/gdb/linux-tdep.c >> +++ b/gdb/linux-tdep.c >> @@ -866,6 +866,39 @@ dump_note_entry_p (filter_flags filterflags, const smaps_data &map) >> return true; >> } >> >> +/* Extract a string view from BUFFER starting at START and ending at the >> + first occurrence of SEPARATOR. >> + Return the extracted view together with an iterator to the beginning of >> + the next entry, skipping any successive separators. If no separator >> + is found, return the remainder of BUFFER starting at START. If there is >> + no following entry, the returned iterator is BUFFER.end (). */ >> + >> +static std::pair, gdb::array_view::iterator> >> +extract_string_view_from_buffer (gdb::array_view &buffer, > > The gdbsupport/array-view.h header says that gdb::array_view objects > should usually be passed by value. Is there a reason why this needs to > be passed by reference here? > No good reason. Fixed. > >> @@ -914,25 +947,23 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, >> >> if (cmdline_f) >> { >> - xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", ptid.lwp ()); >> - gdb_byte *buffer; >> - LONGEST len = target_fileio_read_alloc (nullptr, filename, &buffer); >> - >> - if (len > 0) >> + file_reader_t cmdline_freader >> + (string_printf ("/proc/%ld/cmdline", ptid.lwp ())); >> + if (cmdline_freader) >> { >> - gdb::unique_xmalloc_ptr cmdline ((char *) buffer); >> - ssize_t pos; >> - >> - for (pos = 0; pos < len - 1; pos++) >> - { >> - if (buffer[pos] == '\0') >> - buffer[pos] = ' '; >> - } >> - buffer[len - 1] = '\0'; >> - gdb_printf ("cmdline = '%s'\n", buffer); >> + /* /proc//cmdline stores the command-line arguments as a >> + sequence of NUL-separated strings. */ >> + gdb::array_view cmdline = cmdline_freader.cast_view (); >> + gdb_assert (cmdline[cmdline.size () - 1] == '\0'); > > We shouldn't assert on data from an outside source. This should be > either an error, or a warning if GDB is able to handle this and push > on. > Replaced assert by: if (cmdline[cmdline.size () - 1] != '\0') warning (_("malformed '%ps', missing null-terminating character"), styled_string (file_name_style.style (), path.c_str ())); with 'path' defined a bit before: std::string path = string_printf ("/proc/%ld/cmdline", ptid.lwp ()); >> @@ -997,12 +1025,16 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, >> current_uiout->table_header (0, ui_left, "objfile", "File"); >> current_uiout->table_body (); >> >> - char *saveptr; >> - for (const char *line = strtok_r (map.get (), "\n", &saveptr); >> - line != nullptr; >> - line = strtok_r (nullptr, "\n", &saveptr)) >> + auto content = map_freader.view (); >> + for (auto it = content.begin (); it != content.end ();) >> { >> - struct mapping m = read_mapping (line); >> + auto [line, next_line_begin] >> + = extract_string_view_from_buffer (content, it, '\n'); >> + it = next_line_begin; >> + >> + /* read_mapping() expects a null-terminated string. */ >> + *std::prev (it) = '\0'; > > If the buffer contains two consecutive '\n' characters then this will > overwrite the wrong one I think, e.g. "abc\n\ndef\n". IT will point at > the 'd', and this will overwrite the second '\n', not the first, which I > think is what you want. > I completely missed this issue. Thanks for noticing it. > Also, extract_string_view_from_buffer handles a missing final '\n', so > if the buffer is "abc\bdef" then IT will point to the character after > 'f', and the above will overwrite 'f'. > > Given that extract_string_view_from_buffer handles these cases, I think > this code should also handle them, or throw an error if we see data in a > form that you don't expect. > extract_string_view_from_buffer is not supposed to change the value inside the buffer. I adapted read_mapping and parse_smaps_data to use a gdb::array_view. This removes the need to set '\0' inside extract_string_view_from_buffer or before passing it to read_mapping. read_mapping unfortunately needs to keep its view writable because it needs to set '\0' for mapping.filename. To remove this need, a solution would consists in changing mapping.filename to a std::string_view but then, it would make the printing harder. So I preferred to keep it this way for now. Those changes were moved to different patches, to keep the migration patch more focused on the migration. > > Thanks, > Andrew Matthieu