From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110380 invoked by alias); 28 Nov 2018 10:32:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110359 invoked by uid 89); 28 Nov 2018 10:31:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50048.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Nov 2018 10:31:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MuDgfLftYSG+R55krqThJwZ6lBEOvjS6RnjOn8MqFYI=; b=eqjOjHAcZnQLnt7CFvzXFj1xe8yFvk51YV16Hd/I0tH5i3+nQWagthBhUZ8xFnJ6fRrUzgjAcTWrQH/HhMiGknYUkaf0XSAPu2CO3EIjesKX+5FI7tdd+jlcIirxRTHtxbgwQf88ogljCmNGzVB+EhV/IrOR3044nLQYEEUyVJA= Received: from VI1PR08MB3200.eurprd08.prod.outlook.com (52.133.15.152) by VI1SPR8PMB102.eurprd08.prod.outlook.com (10.163.248.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.19; Wed, 28 Nov 2018 10:31:53 +0000 Received: from VI1PR08MB3200.eurprd08.prod.outlook.com ([fe80::8439:6991:828e:7402]) by VI1PR08MB3200.eurprd08.prod.outlook.com ([fe80::8439:6991:828e:7402%5]) with mapi id 15.20.1361.019; Wed, 28 Nov 2018 10:31:53 +0000 From: Richard Bunt To: Pawel Wodkowski , "gdb-patches@sourceware.org" , "murbanski@pl.sii.eu" , "sbasierski@pl.sii.eu" CC: "tim.wiederhake@intel.com" , "dragos.carciumaru@intel.com" , Bernhard Heckel , nd Subject: Re: [PATCH v2 5/7] Fortran: Enable setting breakpoint on nested functions. Date: Wed, 28 Nov 2018 10:32:00 -0000 Message-ID: References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-5-git-send-email-pwodkowski@pl.sii.eu> In-Reply-To: <1542663530-140490-5-git-send-email-pwodkowski@pl.sii.eu> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Richard.Bunt@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <759D90D2C1F8A5499DF9842BC00050B9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00514.txt.bz2 SGkgUGF3ZWwsDQoNClRoYW5rcyBmb3IgdGhpcyBmaXgsIEkgaGF2ZSBhIGxv Y2FsIHBhdGNoIGZvciB0aGlzIHNvIEknZCBiZSBwbGVhc2VkIHRvIHNlZSBh biB1cHN0cmVhbSB2YXJpYW50Lg0KDQpOb3RlOiBJIGNhbm5vdCBhcHByb3Zl IEdEQiBwYXRjaGVzIGJ1dCBJIHRob3VnaHQgSSdkIGNvbnRyaWJ1dGUgYSBy ZXZpZXcgc2luY2UgSSB3YXMgaW4gdGhpcyBwYXJ0DQpvZiB0aGUgY29kZSBy ZWNlbnRseS4NCg0KT24gMTEvMTkvMTggOTozOCBQTSwgUGF3ZWwgV29ka293 c2tpIHdyb3RlOg0KPiArIyBUZXN0IGlmIHdlIGNhbiBzZXQgYSBicmVha3Bv aW50IGluIGEgbmVzdGVkIGZ1bmN0aW9uDQo+ICtnZGJfYnJlYWtwb2ludCAi c3ViX25lc3RlZF9vdXRlciINCj4gK2dkYl9jb250aW51ZV90b19icmVha3Bv aW50ICJzdWJfbmVzdGVkX291dGVyIiAiLipsb2NhbF9pbnQgPSAxOSINCj4g IA0KPiAgIyBUZXN0IGlmIHdlIGNhbiBhY2Nlc3MgbG9jYWwgYW5kDQo+ICAj IG5vbi1sb2NhbCB2YXJpYWJsZXMgZGVmaW5lZCBvbmUgbGV2ZWwgdXAuDQo+ IEBAIC00Myw2ICs0NiwxMCBAQCBnZGJfdGVzdCAicHJpbnQgbG9jYWxfaW50 IiAiPSAxOSIgInByaW50IGxvY2FsX2ludCBpbiBvdXRlciBmdW5jdGlvbiIN Cj4gIGdkYl90ZXN0ICJ1cCINCj4gIGdkYl90ZXN0ICJwcmludCBpbmRleCIg Ij0gNDIiICJwcmludCBpbmRleCBhdCBCUDEsIG9uZSBmcmFtZSB1cCINCj4g IA0KPiArIyBUZXN0IGlmIHdlIGNhbiBzZXQgYSBicmVha3BvaW50IGluIGEg bmVzdGVkIGZ1bmN0aW9uDQo+ICtnZGJfYnJlYWtwb2ludCAic3ViX25lc3Rl ZF9pbm5lciINCj4gK2dkYl9jb250aW51ZV90b19icmVha3BvaW50ICJzdWJf bmVzdGVkX2lubmVyIiAiLipsb2NhbF9pbnQgPSAxNyINCj4gKw0KPiAgIyBU ZXN0IGlmIHdlIGNhbiBhY2Nlc3MgbG9jYWwgYW5kDQo+ICAjIG5vbi1sb2Nh bCB2YXJpYWJsZXMgZGVmaW5lZCB0d28gbGV2ZWwgdXAuDQo+ICBnZGJfYnJl YWtwb2ludCBbZ2RiX2dldF9saW5lX251bWJlciAiISBCUF9pbm5lciJdDQo+ IA0KDQpUaGlzIHBhdGNoIHBhc3NlZCBteSBsb2NhbCB0ZXN0IGNhc2UgZm9y IHRoaXMgZml4LCBzbyBpdCBsb29rcyBnb29kIHRvIG1lLiBUaGUgb25seSB0 ZXN0IGNhc2UgdGhhdA0KSSBoYXZlIGxvY2FsbHkgdGhhdCBJIHRoaW5rIHdv dWxkIGJlIG9mIHZhbHVlIGhlcmUsIHdvdWxkIGJlIHRvIHRlc3QgdGhhdCBi cmVha3BvaW50cyBjYW4gYmUgc2V0IG9uIA0KbXVsdGlwbGUgZnVuY3Rpb25z IGluIHRoZSBzYW1lIGNvbnRhaW5zIGJsb2NrIChpLmUuIGJvdGggc3ViX25l c3RlZF9vdXRlciBhbmQgc3ViX25lc3RlZF9pbm5lciksDQpwcmlvciB0byBw cm9ncmFtIHN0YXJ0LiBJIGZvdW5kIHRoYXQgc3VjaCBhIHRlc3QgZ2l2ZXMg Y292ZXJhZ2UgdG8gdGhlIGNoYW5nZXMgaW4gDQphZGRfcGFydGlhbF9zdWJw cm9ncmFtIGFzIGl0IHRlc3RzIHRoZSBsb2dpYyBmb3Igc3VicHJvZ3JhbXMg d2hpY2ggYXJlIGxpbmtlZCBhcyBzaWJsaW5ncy4NCg0KV2hhdCBkbyB5b3Ug dGhpbms/DQoNCj4gICAgICAgICAgICAvKiBicm9iZWNrZXIvMjAwNy0xMi0y NjogTm9ybWFsbHksIG9ubHkgImV4dGVybmFsIiBESUVzIGFyZSBwYXJ0DQo+ ICAgICAgICAgICAgICAgb2YgdGhlIGdsb2JhbCBzY29wZS4gIEJ1dCBpbiBB ZGEsIHdlIHdhbnQgdG8gYmUgYWJsZSB0byBhY2Nlc3MNCj4gQEAgLTkyMDYs NiArOTIwOCw4IEBAIGFkZF9wYXJ0aWFsX3N1YnByb2dyYW0gKHN0cnVjdCBw YXJ0aWFsX2RpZV9pbmZvICpwZGksDQo+ICAJew0KPiAgCSAgaWYgKHBkaS0+ dGFnID09IERXX1RBR19lbnRyeV9wb2ludCkNCj4gIAkgICAgYWRkX3BhcnRp YWxfZW50cnlfcG9pbnQgKHBkaSwgbG93cGMsIGhpZ2hwYywgc2V0X2FkZHJt YXAsIGN1KTsNCj4gKwkgIGVsc2UgaWYgKHBkaS0+dGFnID09IERXX1RBR19z dWJwcm9ncmFtKQ0KPiArCSAgICBhZGRfcGFydGlhbF9zdWJwcm9ncmFtIChw ZGksIGxvd3BjLCBoaWdocGMsIHNldF9hZGRybWFwLCBjdSk7DQo+ICAJICBw ZGkgPSBwZGktPmRpZV9zaWJsaW5nOw0KPiAgCX0NCj4gICAgICB9DQoNCg0K TWFueSB0aGFua3MsDQoNClJpY2gNCg== >From gdb-patches-return-152564-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Nov 28 12:19:24 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 101829 invoked by alias); 28 Nov 2018 12:19:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 101719 invoked by uid 89); 28 Nov 2018 12:19:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Nov 2018 12:19:22 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CDE633001BE4; Wed, 28 Nov 2018 12:19:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E4F407A5D5; Wed, 28 Nov 2018 12:19:19 +0000 (UTC) Subject: Re: [PATCH v3 2/3] Add an optional "alias" attribute to syscall entries. To: John Baldwin , Eli Zaretskii References: <20181109200432.84491-1-jhb@FreeBSD.org> <20181109200432.84491-3-jhb@FreeBSD.org> <83efbuattx.fsf@gnu.org> <650590ef-3036-57a8-6cd5-abaa5654add3@FreeBSD.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <34fcc769-4533-31bf-d258-36c6110037e0@redhat.com> Date: Wed, 28 Nov 2018 12:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <650590ef-3036-57a8-6cd5-abaa5654add3@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00515.txt.bz2 Content-length: 1880 On 11/27/2018 09:53 PM, John Baldwin wrote: > +On some operating systems, a system call name may map to more than one > +system call number. For example, the FreeBSD kernel allocates new > +system call numbers when changing the ABI of an existing system call. > +The kernel also includes a compatibility system call using the old ABI > +and number. FreeBSD's system call XML file includes aliases for > +compatibility system calls that are used to catch all versions of a > +system call. For example, FreeBSD 12 introduced a new variant of the > +@code{kevent} system call. Both system calls are caught when catching > +the @code{kevent} system call: > + > +@smallexample > +(@value{GDBP}) catch syscall kevent > +Catchpoint 1 (syscalls 'freebsd11_kevent' [363] 'kevent' [560]) > +(@value{GDBP}) > +@end smallexample > + I'd suggest replacing "FreeBSD's system call XML file includes" with something else that isn't so implementor-speak. Users needn't be aware of the XML file. Maybe something along the lines of "GDB is aware of aliases for compatibility system calls that are used to catch ..." Or maybe remove the sentence altogether. Maybe simplify it a bit further, as users don't really need to be told that that's what FreeBSD does for all new syscalls, just that some syscalls are like that. I think. Thus, something like this is enough, IMHO: On some operating systems, a system call name may map to more than one system call number. For example, FreeBSD 12 introduced a new variant of the @code{kevent} system call, and included a compatibility system call using the old ABI and number. As convenience, both system calls are caught when catching the @code{kevent} system call by name: @smallexample (@value{GDBP}) catch syscall kevent Catchpoint 1 (syscalls 'freebsd11_kevent' [363] 'kevent' [560]) (@value{GDBP}) @end smallexample Thanks, Pedro Alves