From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SAXQLqjjGGqfvSUAWB0awg (envelope-from ) for ; Thu, 28 May 2026 20:54:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1780016040; bh=srsbzU42kiTFXtHGRslG4uCqhhdW4+7r8ZK/+OpW+S8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j1MOdxWPIQD7Xl+4FPJByfh0N2xhNqPTxyHmjUuGCNVEmQND7iHTb4eVnElbabj+L wjlD+IbUUI0bnxa0QBzdYoyvhNQY3cu4eprI3PwLUnNPwxaV/0Kx+2pywho4IdN2Ah o033B6a14liYt9vUBLVROZkSZ4/Ehp9ulaH/1cbU= Received: by simark.ca (Postfix, from userid 112) id AA03B1E024; Thu, 28 May 2026 20:54:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ukEY+Ncj; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8CB21E024 for ; Thu, 28 May 2026 20:53:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BB904BA2E35 for ; Fri, 29 May 2026 00:53:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BB904BA2E35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ukEY+Ncj Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B6B8D4BA2E1A for ; Fri, 29 May 2026 00:53:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6B8D4BA2E1A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6B8D4BA2E1A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780016007; cv=none; b=MMg6XulX6Fo0aTnP3+fRt+QwJiHjfpvvIE7KMsWIP07Ad8PNrYm07lsSbTP0FFUPaeI3n4DL/LPN1efXxqni9wqPX66o2q91Yz4KusWFIEzL1DsVVpJCH0tqDozOTyzhp9wAv3l81mLsWGIgqP79BK2Xh1V5PCvzSPFhRWvGwqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780016007; c=relaxed/simple; bh=srsbzU42kiTFXtHGRslG4uCqhhdW4+7r8ZK/+OpW+S8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WwoLCxW0RHZ2jRINqCWk6TN1Jn8cEkoedQiEUOCFnsUjoUoSpEhIcI8gcrYBviYdY2YBayml/jc1o627VC7wpwrUnDiqos5r461AZdL+8SIbvkpRHt8dmVhZLwCxEJqYFW8R3N0z2mB/+LsJ2S7vwI3v3pq2w5QUnTyK9Wk6Ygg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ukEY+Ncj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6B8D4BA2E1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1780016007; bh=srsbzU42kiTFXtHGRslG4uCqhhdW4+7r8ZK/+OpW+S8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ukEY+Ncjvhj42KLc7F4eei98RMdrUQFuR5j8LtZvuZpixPOEz9LmVE8YWh0W/ZQ2W U3FNOEVR1EYH8b0JeZ/las1EAO52O7PufR/aIKW+cwaakMIkCVxe5RjVrunXsR8Aa3 gNlh0okqL6VXPAffew1WG/BYbDH4qO0MKvH5TNho= Received: by simark.ca (Postfix) id 0C45C1E024; Thu, 28 May 2026 20:53:25 -0400 (EDT) Message-ID: Date: Thu, 28 May 2026 20:53:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] contrib: Make dg-extract-results.py tolerant of unparseable files To: Andrew Pinski , Tom Tromey Cc: Kevin Buettner , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org References: <20260514181502.2841511-2-kevinb@redhat.com> <87h5nr5pfs.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-05-28 19:38, Andrew Pinski wrote: > On Thu, May 28, 2026 at 12:21 PM Andrew Pinski > wrote: >> >> On Thu, May 28, 2026 at 12:03 PM Tom Tromey wrote: >>> >>>>>>>> "Kevin" == Kevin Buettner writes: >>> >>> Kevin> This commit fixes this GDB bug: >>> Kevin> https://sourceware.org/bugzilla/show_bug.cgi?id=34147 >>> >>> FWIW I think this should go in. >> >> This is on my list of patches to review this week. I hope to get to it >> today or tomorrow. >> >>> >>> It would be fine to land it in gdb and then merge it back. >>> I think we agreed that common files could be treated this way now. >>> >>> Kevin> +class ParseError (Exception): >>> >>> I guess gcc doesn't use 'black' for Python formatting. >> >> GCC coding style has a section on python formatting: >> https://gcc.gnu.org/codingconventions.html#python >> But I don't know much about python formatting to say much there. > > So looking into this further I see nobody has been following that either. > I don't know about the history here either. > Now I do think we (GCC and GDB) should standardized on a format. In > this case the folks who knew python the most in the GCC community I > don't see around any more. So picking up the same formatting as gdb > would make sense. And we can get the forge to do the checking there > for us. In GDB we use the most up to date black version: https://sourceware.org/gdb/wiki/Internals%20GDB-Python-Coding-Standards Thanks to this, there is no thinking or discussion about formatting, it is lovely. Simon