From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by sourceware.org (Postfix) with ESMTPS id A9B96384C004 for ; Thu, 17 Sep 2020 11:41:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9B96384C004 Received: by mail-qt1-x82b.google.com with SMTP id p65so1563582qtd.2 for ; Thu, 17 Sep 2020 04:41:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q8TlDHiJX9q0/3oaCDaMlt/L8MuOv99MLhB1a7wtz84=; b=hE1x2k2uWOlp0skfD00MXSxw9XHb6E6ZH7LqMj+q2wBJJYec9bO+hqIPoUjwwG+XVt PzL3aAUm9aw2OjlJ1MebD9lybiYutjfb8fleRy8SIb6fTL/0SJQniSpmFY/oCqSPBXdM kX2D6pc5qH0w8wEk04TTI/sdd4EGHuB/ktYkxZdcDklVVdTfRyMB6mcjAcjDmPgHuU5b AJOnjDDPEoRL6reuMmZtJ8NZ5pBRVZD+iROgQ6HmxwJcm8aeOS0IFrsV7oPdICmICGfD 4SFEHg+U15I5GNe4efUQ/SwHNZKe7yKmoMaMDpu2wKiqXjmkhxQC70BwYKsfWlrMwHW7 tAGg== X-Gm-Message-State: AOAM53264bikUrfCEIvFVMmuIN8u2B06xCAW1tNyo032XA7QR2389PeN 5YO4Pb2j1UmHzSv0h/c4GgzizoVp95nwJw== X-Google-Smtp-Source: ABdhPJxpRLqfY7leW5LVMV55zgEQo+5bRVB1QMgUeKbTlkS0f5HGPj9C6vYODIkTCP9EKeHyHf83Nw== X-Received: by 2002:ac8:6f24:: with SMTP id i4mr14567688qtv.329.1600342876041; Thu, 17 Sep 2020 04:41:16 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:9bb9:21e0:ece7:98fb:b205? ([2804:7f0:8283:9bb9:21e0:ece7:98fb:b205]) by smtp.gmail.com with ESMTPSA id m10sm20445301qti.46.2020.09.17.04.41.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 04:41:15 -0700 (PDT) Subject: Re: [pushed v2 3/4] Rewrite valid-expr.h's internals in terms of the detection idiom (C++17/N4502) To: Vaseeharan Vinayagamoorthy , Pedro Alves , "gdb-patches@sourceware.org" References: <20200914213112.19593-1-pedro@palves.net> <20200914213112.19593-4-pedro@palves.net> <63D23DB1-0CE4-44B5-A074-F64C2DE53109@arm.com> From: Luis Machado Message-ID: Date: Thu, 17 Sep 2020 08:41:12 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <63D23DB1-0CE4-44B5-A074-F64C2DE53109@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 11:41:18 -0000 On 9/17/20 7:57 AM, Vaseeharan Vinayagamoorthy wrote: > Relevant to this patch, I am seeing error: type/value mismatch from valid-expr.h:65:20 when building GDB with: > Build: aarch64-none-linux-gnu > Host: aarch64-none-linux-gnu > Target: aarch64-none-linux-gnu > > > In file included from binutils-gdb--gdb/gdb/unittests/offset-type-selftests.c:24:0: > /binutils-gdb--gdb/gdb/unittests/offset-type-selftests.c: In substitution of 'template class Op, class ... Args> using is_detected_exact = std::is_same::type> [with Expected = selftests::offset_type::off_A&; Op = selftests::offset_type::check_valid_expr75::archetype; Args = {selftests::offset_type::off_A, selftests::offset_type::off_B}]': > > /binutils-gdb--gdb/gdb/unittests/offset-type-selftests.c:75:1: required from here > /binutils-gdb--gdb/gdb/../gdbsupport/valid-expr.h:65:20: error: type/value mismatch at argument 2 in template parameter list for 'template class Op, class ... Args> using is_detected_exact = std::is_same::type>' > archetype, TYPES>::value == VALID, \ > ^ > /binutils-gdb--gdb/gdb/../gdbsupport/valid-expr.h:79:3: note: in expansion of macro 'CHECK_VALID_EXPR_INT' > CHECK_VALID_EXPR_INT (ESC_PARENS(typename T1, typename T2), \ > ^~~~~~~~~~~~~~~~~~~~ > /binutils-gdb--gdb/gdb/unittests/offset-type-selftests.c:42:3: note: in expansion of macro 'CHECK_VALID_EXPR_2' > CHECK_VALID_EXPR_2 (off_A, off_B, VALID, EXPR_TYPE, EXPR) > ^~~~~~~~~~~~~~~~~~ > > > > Regards, > Vasee I haven't seen this. It's been building fine so far. What type of system are you using? I'm on Ubuntu 18.04 with GCC 7.5.