From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u1DHLQEGgmh+OjsAWB0awg (envelope-from ) for ; Thu, 24 Jul 2025 06:08:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ude5vyOz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=poHhc97H; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ude5vyOz; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=poHhc97H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 991761E102; Thu, 24 Jul 2025 06:08:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A9B461E091 for ; Thu, 24 Jul 2025 06:08:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2E0F3858401 for ; Thu, 24 Jul 2025 10:07:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2E0F3858401 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ude5vyOz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=poHhc97H; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ude5vyOz; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=poHhc97H Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 1CFB83858D33 for ; Thu, 24 Jul 2025 10:07:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CFB83858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CFB83858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753351646; cv=none; b=QKqpdqiCEH6vtX7H2Qr4cC/Yuac600h1IY2cpMyufd+lhcySVcl366wOpITvsDorYSj/zHTDh/s+FvWS8VHXJbCVn2HcNPujI770YAz657PbJk5yQ7YVDKf/pvgYs0djyTXHlcqzYAs0a3qLxMp8qlHgGf+Es7RdtWctKKPsNtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753351646; c=relaxed/simple; bh=TJxASf2t3ABgIwpkmY9rvE7uBi1zwm1Nhg9N4q9Frzw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=fKMGdYovpYQTx8YLxbBdsOcsKlmAbnjr18qSugUcaEgRzMtkNsPUouFEfcPUUYojwPvKC6vLOC3NemSu6eVMEdKfj5wGzaB8PoDkXzy0eqvYHC0qdkN5crP2w+AICa5qdfAT90GdiZVnQ8oTaydcoKUgKY+wL0dRCJDdY32LBB4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CFB83858D33 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 107461F770; Thu, 24 Jul 2025 10:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753351645; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn0mjBDVtLQGtbB6e2FhRQTWd5JVYkQ66wtSR/a6Vd8=; b=ude5vyOzPd/vZZQdbERYM1c9Ktpz7O8uqFlNlNDxTxaFl+sSyWYKLCiuY9yZFgC8mMjGYZ rmSKSev1Mcgsr+5Xh49XMD2umrlJhwxDdFF8kgsJ0NGSIQOpE1QXgT8EB1yl/lkH8HBRHt fF21DnK3A8yQt6muiJv6XlyTUDNCeJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753351645; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn0mjBDVtLQGtbB6e2FhRQTWd5JVYkQ66wtSR/a6Vd8=; b=poHhc97HJ4LaCFWrJzWEEEUkNWSFrJ+DJFJOPId01w4cynQcI7KUDd8YbgeD3pyL3rE2Yo ONdHjTMqgzoOkxCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ude5vyOz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=poHhc97H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753351645; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn0mjBDVtLQGtbB6e2FhRQTWd5JVYkQ66wtSR/a6Vd8=; b=ude5vyOzPd/vZZQdbERYM1c9Ktpz7O8uqFlNlNDxTxaFl+sSyWYKLCiuY9yZFgC8mMjGYZ rmSKSev1Mcgsr+5Xh49XMD2umrlJhwxDdFF8kgsJ0NGSIQOpE1QXgT8EB1yl/lkH8HBRHt fF21DnK3A8yQt6muiJv6XlyTUDNCeJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753351645; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn0mjBDVtLQGtbB6e2FhRQTWd5JVYkQ66wtSR/a6Vd8=; b=poHhc97HJ4LaCFWrJzWEEEUkNWSFrJ+DJFJOPId01w4cynQcI7KUDd8YbgeD3pyL3rE2Yo ONdHjTMqgzoOkxCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E7C6B136DC; Thu, 24 Jul 2025 10:07:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7tasNtwFgmhrYAAAD6G6ig (envelope-from ); Thu, 24 Jul 2025 10:07:24 +0000 Message-ID: Date: Thu, 24 Jul 2025 12:07:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] [gdb/testsuite] Add Term::get_string_with_attrs in tuiterm To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250718130153.24989-1-tdevries@suse.de> <20250718130153.24989-8-tdevries@suse.de> <874iv2u53q.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <874iv2u53q.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 107461F770 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/23/25 20:36, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + # Return the text of screen line N. Lines are 0-based. Start at column > Tom> + # X. If C is given, stop before column C. Columns are also zero-based. > Tom> + # If ATTRS, annotate with attributes. > Tom> + proc get_string {n x c {attrs 0}} { > > The comment here (and the other ones later in the patch) make it sound > like C is optional, but it isn't. Thanks for the review. Fixed by using "non-empty" instead of "passed", and pushed. - Tom