From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125353 invoked by alias); 18 Jan 2018 15:35:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124789 invoked by uid 89); 18 Jan 2018 15:35:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1124 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 15:35:44 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w0IFZbUN029447 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jan 2018 10:35:42 -0500 Received: by simark.ca (Postfix, from userid 112) id E1C0C1E5B7; Thu, 18 Jan 2018 10:35:37 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 137081E074; Thu, 18 Jan 2018 10:35:36 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jan 2018 15:35:00 -0000 From: Simon Marchi To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile In-Reply-To: <1516265199-29059-1-git-send-email-yao.qi@linaro.org> References: <1516265199-29059-1-git-send-email-yao.qi@linaro.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 18 Jan 2018 15:35:38 +0000 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00370.txt.bz2 On 2018-01-18 03:46, Yao Qi wrote: > GCC for arm-linux has different names on different distros. It is > arm-linux-gnu-gcc on fedora. Debian/Ubuntu has > arm-linux-gnueabihf-gcc. > So when I run gdb.compile/ tests on arm-linux, I get, > > (gdb) compile code -- ; > Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$" > > This patch extend the regexp to match both arm-linux-gnu-gcc and > arm-linux-gnueabihf-gcc. > > gdb: > > 2018-01-17 Yao Qi > > * osabi.c (gdb_osabi_names): Extend the regexp for > arm-linux-gnueabihf. > --- > gdb/osabi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/osabi.c b/gdb/osabi.c > index 129164f..fd44deb 100644 > --- a/gdb/osabi.c > +++ b/gdb/osabi.c > @@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] = > { "SVR4", NULL }, > { "GNU/Hurd", NULL }, > { "Solaris", NULL }, > - { "GNU/Linux", "linux(-gnu)?" }, > + { "GNU/Linux", "linux(-gnu[^-]*)?" }, > { "FreeBSD", NULL }, > { "NetBSD", NULL }, > { "OpenBSD", NULL }, That seem reasonable to me. Simon