From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83058 invoked by alias); 30 Nov 2016 21:05:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83040 invoked by uid 89); 30 Nov 2016 21:05:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1744 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 21:05:20 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cCC46-0004qY-PD from Luis_Gustavo@mentor.com ; Wed, 30 Nov 2016 13:05:18 -0800 Received: from [172.30.5.15] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 30 Nov 2016 13:05:15 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com> <6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com> To: Pedro Alves , From: Luis Machado Message-ID: Date: Wed, 30 Nov 2016 21:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01023.txt.bz2 On 11/30/2016 02:47 PM, Pedro Alves wrote: > On 11/25/2016 08:54 PM, Luis Machado wrote: >> This fixes offender testcases that have test names starting with uppercase >> when using gdb_test_multiple in a multi-line construct. >> >> gdb/testsuite/ChangeLog >> 2016-11-25 Luis Machado >> >> Fix test names starting with uppercase throughout the files. >> >> * gdb/testsuite/gdb.cp/gdb2495.exp > > Drop "gdb/testsuite/", and LGTM, but ... > >> --- >> gdb/testsuite/gdb.cp/gdb2495.exp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp >> index dff5977..7e4dfa8 100644 >> --- a/gdb/testsuite/gdb.cp/gdb2495.exp >> +++ b/gdb/testsuite/gdb.cp/gdb2495.exp >> @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \ >> >> # Turn off this new behaviour. >> gdb_test_multiple "set unwind-on-terminating-exception off" \ >> - "Turn unwind-on-terminating-exception off" { >> + "turn unwind-on-terminating-exception off" { >> -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"} >> timeout {fail "(timeout) set unwind-on-terminating-exception off"} >> } > > ... I think this could just be: > > gdb_test "set unwind-on-terminating-exception off" "" > gdb_test_no_output then? It doesn't check for any output other than the prompt. > ? > > I'd end up fixing two extra things: > > - note the typo in the pass case: "unwiNN" > - odd "(timeout)" print position. timeout handling it not necessary > at all with gdb_test_multiple, even. I see more occurrences of expecting timeouts where they're not needed. I'll fix in a follow-on patch.