From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85852 invoked by alias); 10 Mar 2017 13:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84036 invoked by uid 89); 10 Mar 2017 13:33:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=BAYES_05,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=influences, cursor, UD:20170212.fc26.x86_64, sk:ncurses X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Mar 2017 13:33:41 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF274C0528CD for ; Fri, 10 Mar 2017 13:33:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2ADXerb005560; Fri, 10 Mar 2017 08:33:40 -0500 Subject: Re: [pushed] Fix PR tui/21216: TUI line breaks regression To: Jan Kratochvil References: <1488932352-10885-3-git-send-email-palves@redhat.com> <20170309230359.GA503@host1.jankratochvil.net> <20170310125946.GA508@host1.jankratochvil.net> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 10 Mar 2017 13:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170310125946.GA508@host1.jankratochvil.net> Content-Type: multipart/mixed; boundary="------------218D37B818F6EB628434423C" X-SW-Source: 2017-03/txt/msg00130.txt.bz2 This is a multi-part message in MIME format. --------------218D37B818F6EB628434423C Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-length: 3395 On 03/10/2017 12:59 PM, Jan Kratochvil wrote: > On Fri, 10 Mar 2017 00:03:59 +0100, Jan Kratochvil wrote: >> On Wed, 08 Mar 2017 01:19:12 +0100, Pedro Alves wrote: >>> +# Make sure filtering/pagination is enabled, but make the window high >>> +# enough that we don't paginate in practice. >>> +gdb_test_no_output "set pagination on" >>> +gdb_test_no_output "set height 2000" >> >> I get: >> FAIL: gdb.tui/tui-nl-filtered-output.exp: set pagination on (timeout) >> FAIL: gdb.tui/tui-nl-filtered-output.exp: set height 2000 (timeout) >> But I have no idea why. > > FAIL reproducibility requires: --with-system-readline > F-25: not reproducible > readline-6.3-8.fc24.x86_64 > ncurses-libs-6.0-6.20160709.fc25.x86_64 > F-26: not tested > Rawhide: reproducible > readline-7.0-5.fc26.x86_64 > ncurses-libs-6.0-8.20170212.fc26.x86_64 Curious, I've been poking at this, and had tested with both F23 and F25, with and without --with-system-readline without success. Hadn't tested F24. >From your log, up until the test does "set height 2000", looks like curses is issuing "cursor backward" (the 17D and 15D) commands: (gdb) set pagination onFAIL: gdb.tui/tui-nl-filtered-output.exp: set pagination on (timeout) (gdb) set height 2000FAIL: gdb.tui/tui-nl-filtered-output.exp: set height 2000 (timeout) I don't get those, and I guess you don't either when testing outside hammoc. Looks like the terminal environment under hammock is different somehow. Could it be the TERM env variable that influences this? By adding gdb_test "show environment" ".*" just before tui enable, I see that for me, TERM is always set to vt100, no matter what TERM is set to in the shell outside dejagnu. /me pokes some more. Hmm, the screen height makes a difference. That could be it. If I add a few more commands, then the TUI starts issuing escape sequences once the command line reaches the bottom. And if I run make check in a smaller terminal window, the pristine test starts failing for me too, due to unexpected escape sequences. See test patch below, and attached resulting gdb.log. Note that viewing the log with "less" on the terminal directly "hides" some of the escape sequences (they get interpreted directly). >From 8973caf1689f87632e479fa3d8101a1eab827d24 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 10 Mar 2017 12:37:27 +0000 Subject: [PATCH] env --- gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp index d1f56f2..fd33e70 100644 --- a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp +++ b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp @@ -37,6 +37,8 @@ if {[skip_tui_tests]} { return } +gdb_test "show environment" ".*" + # Enable the TUI. set test "tui enable" @@ -48,8 +50,13 @@ gdb_test_multiple "tui enable" $test { # Make sure filtering/pagination is enabled, but make the window high # enough that we don't paginate in practice. +gdb_test "show height" ".*" gdb_test_no_output "set pagination on" gdb_test_no_output "set height 2000" +gdb_test_no_output "set height 2000" +gdb_test_no_output "set height 2000" +gdb_test_no_output "set height 2000" +gdb_test_no_output "set height 2000" gdb_test \ {printf "hello\nworld\n"} \ -- 2.5.5 --------------218D37B818F6EB628434423C Content-Type: application/gzip; name="tui-gdb.log.gz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="tui-gdb.log.gz" Content-length: 5564 H4sICOGowlgAA3R1aS1nZGIubG9nAO07a3PbOJKfh1W6/QH+gsrOVcWTUBT1 sBx5OXOyRFtay5KWpPLY5IoFkZDEmK8hSEnOzf33bYAUSdlWRpPM1s5uRRXb DaDR3egHgG4hBqExihIfze9RSOwoQIGPriIH3eIIyTUkNzp1+NdG9ZrcFsY4 dtYEWYG/cJZJBC3Adijanp+ZZ00xtETX8ZOtuPQTQfjuO0VR0NKeoxiYUAQt QdCtFbETl6BggdY4cjgJ2hEQfBLf2QqClvi+4y9RjKMlidPOGWU9UkIjia5w RCSbfMTARJpjSuYBjmwqMcQq2YYIU8S7kE2oFTkhF3LhAM9FEGVkq4dJpovb I7ckPokcCzl+TKIFtshBcqvAIxLXowQLl7z7pRNLNLJ4i6shcWLyFI84CFwR +7aYUhRpSCxn8YhpNdfPsbygVY0TR4If0XdFIAL0iC0GSRwmMWdfrVYFGuKN v0d0HvnBI/rzxHHtBxyqVfaP9TFji/4GfrZItHGMRduJiBUH0f0Xk94nUxGu xzPuVM+v+5enqF2V69VWrcrcs9aQayJQqgi9ILyPnOUqRs97p9x1wacJQXqw iDdgbHQVJL7Nfe8lGvpWtSKMHIv4lKDr6WjdeNFBjA3AaE0iyhyogcDaLgbd ob+s4jjsSBJ4SzWIlpKbTqXSMnSrq9hzf6wIxgrCAv4tGFuase2g+yBBjD/v jgNkrbC/JAjsjsAmDo0jZ57EBDlxldEAQzEi4wl609W07th495LNilcEkW1M /BhiNvKcOCY2C2AXb6oIGfchQc/oKthAoIb34CvPKgLjkPaBIBH24/tn3H9t EmPHpdVMYtApINA8woEutJ49Ed/P2JQyp9KWkJLe3yUKRlcwNk+WsOAwiGLm yo4PC08svhW8RKFLIKoRJaRTEXa63mw21Z2+d+rkvgKUqPQjI+vAEplm2Bo8 7CfY5XoNoA/WGViJBwpLhYkIDZLIIhR2O1gRGCA+htcekZQprGVF3BDMwnXB 4EIzOIyCMKBoE0T2M2Y4SnBkrTLteCCkTUEW5lU2G37GEWH6c+B2CtgxEOdu XCv3bRw7XhVdjCeYHlyLeX7qUEwPaRfbaDegmmDDdD+jeAlumA2FEVmjX5AP vgR//pL2mj72yI8IIiJFYk3KnBY0BJs0bDDwu4P6Dg1hAkWpJrmqszWV+AEq pt7+BHBzTCnx5u794VmA68SP2bw8bnZElnSPJ3RAcIEfpGhVNFxABEEXc7+d 7lDxcXYMpR19MNmO767vJVfz3rwHfBgdO5WB2JwpzNibkHF5SBo95wo43SPw cp8XY/45ftAHbvJoSoYZrzB4Fwv1JIrYTuIGS8eCmFmAkzM15h7Hwpv4aycK fOb8FeFt/9p8bYw1RYbdeGiYU1029cHkTX+oGe90o2uobORqovVUc9rVuqOR OlIqwt9mw5FhauqVpuoDs6td64oIG/tiQSGgkCj6gRg74Gsx9kKatkFUAieJ SGGjQGIoww/Cc/Dyt29NoG8aQEU1lOWLFxVBZ0Sv1THIM+wr9Vqtnkqqq7o+ nIxN6ASpbvqqeTsbGcOB2u0rC+xSsEdf/WsX9nulfESR2JIoHEHsgKwIg4lu jLu3qmJhamGHAruBOhop0tzx2SVklfK6VcczcwpLHL5V7hYtsSLcdm/U4fhq onj4jjj+ImCrYaYVqfOJKK0a/8CGoWq3yjqWGczmXI26oB84SUUWpQtnq0hB GPMDlmyJZT7sxEvMdlEF9XrK998/7/VK+jlFe01laVmolzIQl40PSJzUEGiU z9tT7Cl6rGjW9WDucAxGZ8pglymmECYJdl0YtXaDoJXJtda9/TxSv2t0n8SA H+8DOms20SOFfnhSoxxvYNyOfgXvA4L+/qD7Gtwio2z2RsPeDUNnZznSZmND 1Q0FLsnsXrJrpzpAD7wcsSFd+SG7bf2Qec8QOod/h7Dgtr42buqmBiYZjlRd 4Z62jO/EerXG/kZWp+yHVd7FBg90i3c2ae6PZdfLHAXcfjLWJyPV7F/OdIgI 7fWwpyoduVpvnReDYCImkskdfRoF/JL7Z5kL/Fjeg7IelgUC96EjVoQ3w3F/ 8oZFZ7MJV7jmqwZsFQbsJakjuM78rCn9HIuNaiMNjT2rPm38p02aWTSL3b2N Ab9qvmotyJmNF00gMG8tAGxaMpbr9dZZjUk0HPceSwQ+armJTfa3mt6oq+tK QkmUbjhXs4KdAjcdki5k8lrVtGEfdPr9/4k/iNnWL/K0aO4SCn3/D8K+Hptq f2hMNAVuiLD9zsB+CtduRVDfqupbAzbXkW72JqOJpisRVWod21Fq8kWj2XF9 Dpx1vJVSq3VCR2nWLhqNDg14f6tj74C5nQ5d1OSOVYKDiMMygz2HEaGJ0mhf NOUOXSqN2kWz0bEwB+ROvOFAvRMA0GQA7EkMudkhW86o3vmhCikOh2UGLz/l MFyOSvDHAgcXOO4KF/CnZglelWCvQIrdYnK8LcGfggJuF/2fnLCAc+jvOWQX nSXR3agEl8GCSYn3/FO9BBdi7MP1kqwFezLP4Sj0cvhjSaebEkxKMC3BUQnG JYkh0SyWHxTSW6FTNErqKq3bwoVoH8Nl5lcMJkVj6SxyeO6FORzOvQJeluCw gOMlzuFtCX9bxinRB7hohH4hBF3vwZ/yhldCCq1t0R+sC7i0NK+8NK9eQror 4A0pyRqU1uaFzQJuljmUGutgnsM/xznoJyUGXgFjWiw58krguiCzcK0Cf+2U +stwQXPp5qBdgFur4LTd2Dl8X5LMKq2WeIuSFtYluNAzxiBZje1XACc5uHBL /V4TF7Bjl2GnaNyVkMJGCS4IBctlDkcF+gavSyhFfxAmNG/QcJvDWxousgZs xH1zNLzUuto7uBUYA+UrKipwdyBW3PkKCnBU0di2Xrz4GiJw1LNC1VeRsNyv pjFf2F8zPQitwCa0w87MqdozlFS7+wd3ajGW97MCDaDfxUEoZVnkLfYheY4k nVBWEeKXArM7Myam3tNUdQx/unB7uur22Fld21HuGseSxXEtS2NmxsDUJ70b RYq9UKJ0JXaHtNW27940J21HAnw/rsqv2nAj6umaOp0odO2/ADxWlcIx2eD7 Kl8uzy4j1vAkn8QSoIm8oOhjV6LJPKtuSRoJA8h2eIHtySts+dbPLv0gaKaz 2+4Y0i5NcQPIHlMr/w8Xuwp3TJG1pXqt3X7JodQJHo+mF6KR+hru0Oyal/Ha pErsTcZXw2sT7oTZ9XNrLzul0i3cgEVKYpbMU94I08urZJMFTtyY4bMsT78x JtP8IlYisKWpTakEFqEergiZySC7YnqcE99aAW5W/nKZW0GG0nmAYAWuvXAi 8git5LY9wNYzs0g7wGS9l4yGOYJJ5iKIoMu1r4CYCZkp9ALBp1iGwYZEj/jx ayq3Rz4lr5g/kIfVna0VSx6lgG7ZjxUFlEppGfpz6LkQnLHoOSEV6zW5UZVl aa/xGRqQATDhcRSIOPKK6iLBc2e1EJvV85RK7VxyCxU8Tct3AlqXdi4PqWo2 tfW5STG4SYT5H3AaMS10HisxK+adNQupS/K2jkY0n16Y51CLV/MfDrC+n2Gb i8UsPy5sHAfQXjtkwwXeBNEdLfqq59U2ZIttnlrv76Q7l+FA3qIcog8cKm3z fdZ2IqlacrO8M53o45BBLLSHI0WCtEaiIcgledhxpSyB+bXyAOT++1u08W6q KlsZstLpm/4Xna67SlR/eHW1K0P9au0JsjMXMiGcxMGuCLWXU6dZrCK9ScuQ Esi3l7SNuuNrpZemg7ulzFjmySsC0JtubrD6irBUquk3KftffSiPvgkp1d5m Y0Pr9m7Ufpqky49S/mzP03cbXbMiREEQe+QLdchqGrAvG9pkpDhLP4iInYS0 k4I0hDQiO8v0mynLhnPD3sExheldiCnlx0pavRtMbtWyJMXpqdD0YLzu38BB oMGCVFa9MOGsGBt8pfpg9HqknAE1lgFfXV9eK3LroravbMi1uQZaqS1mcGZB 2gzBBApVjvwuDTg8OATf9maazgoaAxXkn8Pp/omYVhKB09B9A4Gb64O8OHqo ZMbd/akC334QZEeZAguE5UyuecUm0xuYHwTUKsJeoYpdVuBe+kQFAxoV4RG3 3mvd1PSBQllpc8/RprqhqRCpLBSK+H2ycsdKe6LHynap+AzJzB19t6HwE7h8 nHf4XgFy8T3ElrILE5zgJVc2Gdzt9zW2XH6twHDXjbAVp5cme57ACRQ0Rtp5 Y7QxXi4TSBWsRrs9t85xA+N6a1FrNOyG3LRajdb53G7g9jzV3mSqjpVffslX 40LMhE5IqnSF/pvmit1VBCvCrvi621ng8tAbmJOpwbYWkG3hEFuMyEcIXPb9 K6Fp7IF/fd7zUq0xdsNb1eQlMeApscKSlG4cWcmORw/oZ6hPR913SqfGKm1p eY3fn2aaxgrje27zlt0yJ9rQeJcqbAsGXYmMrGjy+d3eQDUH4LWMcd4BPLqX I+7Eo57JfLjHoR7fmHvMI6YzQ+spYLa15CeuC/4DV1SmDjAb88TRcAxbVL3J A3Z2C31yq777uoFtFh30619adx59MSEAMrRZ6awinDy/PDmtnbyXL+rN6OS9 96eT9z+1V/BLXp0oJ+8HJ+//CoOty5P3tQv5ou39aRz4BI0DBLcAC+yNhn4H /Ys+o59+gt/TXgcBAFK2L+RBuoQB9IPE3n+5P//xPncgYP2iOeACbqEhN9u9 vNE4ONI8ONI6OHJ2cKR9cOT84MirgyNy7fCQfHjosBrkw3qQDytCzjXh/aut /MTnI5NwJyBXdKs5eM+CKc1vUHcNNz4Wl+h/s9EDnr/z8M9TGDCEdnuQRXMF DHiZhvS38PidwoMbILXnQTO0W98i6Hf68Ag649s8SPjvcCblRxKPRAjB88v8 eOLC/2Fj0CviMBV0m3Vm/rLf2Tgas3k0ZutozLOjMdtHY54/hbmL97SXdx5w hF3c789/dTT73X5wDKp8POrxFpWPN6l8vE3lPaP+UfcYrzipS5Y+4ryVzy5/ 6/W8uI0L/KaevmSrCOPEm5OIPUtjL+9o+kB45fh3/JEZcnyEUYiX/OHjefUL 04KUmcBeywEtx0+f/QX+F5B7SEIoPcur8yTsS0iWCHwjWDtp8zSHpWrnkLvt srZ6E46ZlNVVdzj6IlboOSvsAcKpEEaOHy/4I003+OBvgsi1P/jPctYpP0Eo CVCHDo5eETj6b1+5FUSsYMedHc0jgu+owKoGFnvj+ju+4bYCL3QJe0gKESTX QA1W4Nu0/AxfTzwPR/fpQ/w/swhMvwODOawaR+h3371K+xM/H1nARpBEMCYL 6pZYCX8xCYGwCmjc+eO/F0eiuHvBDZ+dLyAFNWq10+zRu5gWLZE+vB7Mpv9O a/r2Gv7ba/j//NfwvyFqWCjk8f5UNPyzQ1MQdu9Eiw0Zx4//R1Uj+x9V/wBE XFn6gDUAAA== --------------218D37B818F6EB628434423C--